Skip to contentSkip to conversation

check: new package

PATCH New gustavo.zacarias at free-electrons.com 2 participants 5 messages Sep 7, 2015 – Sep 8, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 check: new package

From: Gustavo Zacarias <[email protected]>

---
 package/Config.in        |  1 +
 package/check/Config.in  |  6 ++++++
 package/check/check.hash |  3 +++
 package/check/check.mk   | 21 +++++++++++++++++++++
 4 files changed, 31 insertions(+)
 create mode 100644 package/check/Config.in
 create mode 100644 package/check/check.hash
 create mode 100644 package/check/check.mk
package/Config.in +1 -0
index 5a4e9c3..bd5897d 100644
@@ -110,6 +110,7 @@ menu "Development tools"
 	source "package/binutils/Config.in"
 	source "package/bsdiff/Config.in"
 	source "package/bustle/Config.in"
+	source "package/check/Config.in"
 	source "package/cmake/Config.in"
 	source "package/cppunit/Config.in"
 	source "package/cvs/Config.in"
package/check/Config.in new file +6 -0
new file mode 100644
index 0000000..04682e1
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_CHECK
+	bool "check"
+	help
+	  Check is a unit testing framework for C.
+
+	  http://check.sourceforge.net/
package/check/check.hash new file +3 -0
new file mode 100644
index 0000000..0c3a924
@@ -0,0 +1,3 @@
+# From http://sourceforge.net/projects/check/files/check/0.10.0/
+md5	53c5e5c77d090e103a17f3ed7fd7d8b8	check-0.10.0.tar.gz
+sha1	35d3a53446aea7b21a770faedb358d0fc7cba76d	check-0.10.0.tar.gz
package/check/check.mk new file +21 -0
new file mode 100644
index 0000000..9b88321
@@ -0,0 +1,21 @@
+################################################################################
+#
+# check
+#
+################################################################################
+
+CHECK_VERSION = 0.10.0
+CHECK_SITE = http://downloads.sourceforge.net/project/check/check/$(CHECK_VERSION)
+CHECK_INSTALL_STAGING = YES
+CHECK_DEPENDENCIES = host-pkgconf
+CHECK_LICENSE = LGPLv2.1+
+CHECK_LICENSE_FILES = COPYING.LESSER
+
+# Having checkmk in the target makes no sense
+define CHECK_REMOVE_CHECKMK
+	rm -f $(TARGET_DIR)/usr/bin/checkmk
+endef
+CHECK_POST_INSTALL_TARGET_HOOKS += CHECK_REMOVE_CHECKMK
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))
Signature · 1 line
2.4.6
#1 lore raw

PATCH 1/1 check: new package

On 07-09-15 15:37, gustavo.zacarias at free-electrons.com wrote:
[snip]

package/check/check.hash line 3

Quoted 9 lines
package/check/check.hash new file +3 -0
new file mode 100644
index 0000000..0c3a924
@@ -0,0 +1,3 @@
+# From http://sourceforge.net/projects/check/files/check/0.10.0/
+md5	53c5e5c77d090e103a17f3ed7fd7d8b8	check-0.10.0.tar.gz
+sha1	35d3a53446aea7b21a770faedb358d0fc7cba76d	check-0.10.0.tar.gz

Don't we usually add a locally calculated sha256 if only sha1 is available
upstream? (Honest question, I don't remember.)

Quoted 17 lines
package/check/check.mk new file +11 -0
new file mode 100644
index 0000000..9b88321
@@ -0,0 +1,21 @@
+################################################################################
+#
+# check
+#
+################################################################################
+
+CHECK_VERSION = 0.10.0
+CHECK_SITE = http://downloads.sourceforge.net/project/check/check/$(CHECK_VERSION)
+CHECK_INSTALL_STAGING = YES
+CHECK_DEPENDENCIES = host-pkgconf
+CHECK_LICENSE = LGPLv2.1+

package/check/check.mk line 21

Quoted 10 lines
package/check/check.mk new file +10 -0
+CHECK_LICENSE_FILES = COPYING.LESSER
+
+# Having checkmk in the target makes no sense
+define CHECK_REMOVE_CHECKMK
+	rm -f $(TARGET_DIR)/usr/bin/checkmk
+endef
+CHECK_POST_INSTALL_TARGET_HOOKS += CHECK_REMOVE_CHECKMK
+
+$(eval $(autotools-package))
+$(eval $(host-autotools-package))

Why do we need a host package?

Regards,
Arnout

Quoted 1 line
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#2 lore raw

PATCH 1/1 check: new package

Quoted 6 lines · Arnout Vandecappelle

package/check/check.hash line 3

Quoted 3 lines
package/check/check.hash new file +3 -0
+# From http://sourceforge.net/projects/check/files/check/0.10.0/
+md5	53c5e5c77d090e103a17f3ed7fd7d8b8	check-0.10.0.tar.gz
+sha1	35d3a53446aea7b21a770faedb358d0fc7cba76d	check-0.10.0.tar.gz

Don't we usually add a locally calculated sha256 if only sha1 is available
upstream? (Honest question, I don't remember.)

Hi Arnout.
We normally consider md5 weak (docs), sha1 is so-so but we don't (yet) consider it too weak.
For sourceforge they normally provide md5 and sha1, given than an intersection of hashes is harder to crack than any single one alone it's good to add md5 - as long as there's another better one backing it up as well.

Quoted 1 line

Why do we need a host package?

Some people may use checkmk which is a host tool, which i remove for the target (probably needs full gawk instead of busybox awk, and not very useful in the target IMO).
Regards.

#3 lore raw

PATCH 1/1 check: new package

Quoted 9 lines · Gustavo Zacarias
Quoted 6 lines · Arnout Vandecappelle

package/check/check.hash line 3

Quoted 3 lines
package/check/check.hash new file +3 -0
+# From http://sourceforge.net/projects/check/files/check/0.10.0/
+md5    53c5e5c77d090e103a17f3ed7fd7d8b8    check-0.10.0.tar.gz
+sha1    35d3a53446aea7b21a770faedb358d0fc7cba76d    check-0.10.0.tar.gz

Don't we usually add a locally calculated sha256 if only sha1 is available
upstream? (Honest question, I don't remember.)

Quoted 6 lines

Hi Arnout.
We normally consider md5 weak (docs), sha1 is so-so but we don't (yet) consider it too weak.
For sourceforge they normally provide md5 and sha1, given than an intersection of hashes is harder to crack than any single one alone it's good to add md5 - as long as there's another better one backing it up as well.

OK, thanks for the reminder.

Quoted 6 lines
Quoted 2 lines

Why do we need a host package?

Some people may use checkmk which is a host tool, which i remove for the target (probably needs full gawk instead of busybox awk, and not very useful in the target IMO).

I fully agree on removing checkmk on the target. I can also see that you'd want
it on the host, but the user has no way to select it since there is no Config.in.host... So the user would have to do an explicit 'make host-check' to get it. It also won't be tested in the autobuilders.

So in principle, we only have host packages that are dependencies of other
packages or that have a Config.in.host entry. An exception is when there is another package that uses it but that has not yet been accepted. Probably the reverse also exists: a host dependency that is no longer needed but the host package still exists.

Thomas recently proposed to violate this principle in the context of the
python-colorama package [1], to which I replied no [2]. But of course that's still open for discussion.

Regards,
Arnout

[1] http://lists.busybox.net/pipermail/buildroot/2015-August/135344.html
[2] http://lists.busybox.net/pipermail/buildroot/2015-September/138893.html

Quoted 2 lines

Regards.

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#4 lore raw

PATCH 1/1 check: new package

Quoted 15 lines · Arnout Vandecappelle
Quoted 3 lines

Some people may use checkmk which is a host tool, which i remove for the target (probably needs full gawk instead of busybox awk, and not very useful in the target IMO).

I fully agree on removing checkmk on the target. I can also see that you'd want
it on the host, but the user has no way to select it since there is no Config.in.host... So the user would have to do an explicit 'make host-check' to get it. It also won't be tested in the autobuilders.

So in principle, we only have host packages that are dependencies of other
packages or that have a Config.in.host entry. An exception is when there is another package that uses it but that has not yet been accepted. Probably the reverse also exists: a host dependency that is no longer needed but the host package still exists.

Quoted 3 lines

Thomas recently proposed to violate this principle in the context of the
python-colorama package [1], to which I replied no [2]. But of course that's still open for discussion.

Hi Arnout.
I don't have any particular use for the host variant, so no plan on arguing too much for it.
I'll spin v2 unless someone objects the other way around with a valid argument.
Regards.