gdb: prevent building the documentation
PATCH 1/1 gdb: prevent building the documentation
gdb needs makeinfo to build the documentation. Since we do not provide a host-makeinfo package this will fail in any system where makeinfo is missing. However, we can workaround this problem by preventing gdb to build the documentation.
Fixes:
http://autobuild.buildroot.net/results/dd5/dd50ed99abb2c8495def826866b184030953f90e/
--- package/gdb/gdb.mk | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
package/gdb/gdb.mk +6 -0
@@ -114,6 +114,12 @@ else GDB_CONF_OPTS += --without-zlib endif +# Prevent gdb to build the documentation +define GDB_DISABLE_DOC +$(SED) '/^SUBDIRS =/ s/doc//' $(@D)/gdb/Makefile.in +endef +GDB_PRE_CONFIGURE_HOOKS += GDB_DISABLE_DOC + # This removes some unneeded Python scripts and XML target description # files that are not useful for a normal usage of the debugger. define GDB_REMOVE_UNNEEDED_FILES
Signature · 1 line
1.7.1
PATCH 1/1 gdb: prevent building the documentation
Quoted 19 lines · Vicente Olivert Riera
gdb needs makeinfo to build the documentation. Since we do not provide a host-makeinfo package this will fail in any system where makeinfo is missing. However, we can workaround this problem by preventing gdb to build the documentation.
Fixes:
http://autobuild.buildroot.net/results/dd5/dd50ed99abb2c8495def826866b184030953f90e/
Signed-off-by Vicente Olivert Riera <[email protected]>--- package/gdb/gdb.mk | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)package/gdb/gdb.mk +0
-0
package/gdb/gdb.mk else · line 121
Quoted 8 lines
package/gdb/gdb.mk +5
-0@@ -114,6 +114,12 @@ else GDB_CONF_OPTS += --without-zlib endif +# Prevent gdb to build the documentation +define GDB_DISABLE_DOC +$(SED) '/^SUBDIRS =/ s/doc//' $(@D)/gdb/Makefile.in +endef +GDB_PRE_CONFIGURE_HOOKS += GDB_DISABLE_DOC
Since it is patching the source, it should be POST_PATCH_HOOKS rather thanPRE_CONFIGURE_HOOKS.
That does mean that people using OVERRIDE_SRCDIR should do this fix in the
overridden source, but I think that's OK.
Regards,
Arnout
Quoted 5 lines
package/gdb/gdb.mk +1
-0+ # This removes some unneeded Python scripts and XML target description # files that are not useful for a normal usage of the debugger. define GDB_REMOVE_UNNEEDED_FILES
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/1 gdb: prevent building the documentation
Quoted 5 lines
Since it is patching the source, it should be
POST_PATCH_HOOKSrather thanPRE_CONFIGURE_HOOKS.That does mean that people using
OVERRIDE_SRCDIRshould do this fix in the
overridden source, but I think that's OK.
I was looking at this in parallel and was about to start looking at adding a host-texinfo package (which includes makeinfo).
I was a little hesitant, as I think most buildroot users don't care about building documentation. On the other hand, adding the dependency avoids patches and makes life a little easier when using OVERRIDE_SRCDIR as you noted.
regards
Brendan
PATCH 1/1 gdb: prevent building the documentation
Quoted 2 lines
I was looking at this in parallel and was about to start looking at adding a host-texinfo package (which includes makeinfo).
Stop press. There is already a host-texinfo package, and making host-gdb dependent on it fixes this build problem. Just running a few tests at the moment.
I think this is a cleaner and better way to solve this one ...
regards
Brendan
PATCH 1/1 gdb: prevent building the documentation
Dear Brendan Heading,
Quoted 8 lines · Brendan Heading
Quoted 2 lines
I was looking at this in parallel and was about to start looking at adding a host-texinfo package (which includes makeinfo).
Stop press. There is already a host-texinfo package, and making host-gdb dependent on it fixes this build problem. Just running a few tests at the moment.
I think this is a cleaner and better way to solve this one ...
yes, it is. Please complete your tests and feel free to submit a patch. When you do it, I will test it and mark mine as superseded.
Thanks,
Vincent.
Quoted 4 lines
regards
Brendan
PATCH 1/1 gdb: prevent building the documentation
In reply to Vicente Olivert RieraQuoted 8 lines · Vicente Olivert Riera
gdb needs makeinfo to build the documentation. Since we do not provide a host-makeinfo package this will fail in any system where makeinfo is missing. However, we can workaround this problem by preventing gdb to build the documentation.
Fixes:
http://autobuild.buildroot.net/results/dd5/dd50ed99abb2c8495def826866b184030953f90e/
Thomas prefers this solution and I agree.
However, there is one thing missing in this patch: removing the now-redundant
dependency on host-texinfo.
Still, that can be done as a follow-up patch, so:
Regards,
Arnout
Quoted 24 lines
Signed-off-by Vicente Olivert Riera <[email protected]>--- package/gdb/gdb.mk | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)package/gdb/gdb.mk +6
-0@@ -114,6 +114,12 @@ else GDB_CONF_OPTS += --without-zlib endif +# Prevent gdb to build the documentation +define GDB_DISABLE_DOC +$(SED) '/^SUBDIRS =/ s/doc//' $(@D)/gdb/Makefile.in +endef +GDB_PRE_CONFIGURE_HOOKS += GDB_DISABLE_DOC + # This removes some unneeded Python scripts and XML target description # files that are not useful for a normal usage of the debugger. define GDB_REMOVE_UNNEEDED_FILES
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/1 gdb: prevent building the documentation
Dear Arnout Vandecappelle,
Quoted 8 lines · Arnout Vandecappelle
Quoted 7 lines · Vicente Olivert Riera
gdb needs makeinfo to build the documentation. Since we do not provide a host-makeinfo package this will fail in any system where makeinfo is missing. However, we can workaround this problem by preventing gdb to build the documentation.
Fixes:
Quoted 8 lines
Thomas prefers this solution and I agree.
However, there is one thing missing in this patch: removing the now-redundant
dependency on host-texinfo.Still, that can be done as a follow-up patch, so:
nah..., I will send a v2. Note the sed command is not indented ;-)
Regards,
Vincent.
Quoted 32 lines
Regards,
ArnoutQuoted 24 lines
Signed-off-by Vicente Olivert Riera <[email protected]>--- package/gdb/gdb.mk | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)package/gdb/gdb.mk +6
-0@@ -114,6 +114,12 @@ else GDB_CONF_OPTS += --without-zlib endif +# Prevent gdb to build the documentation +define GDB_DISABLE_DOC +$(SED) '/^SUBDIRS =/ s/doc//' $(@D)/gdb/Makefile.in +endef +GDB_PRE_CONFIGURE_HOOKS += GDB_DISABLE_DOC + # This removes some unneeded Python scripts and XML target description # files that are not useful for a normal usage of the debugger. define GDB_REMOVE_UNNEEDED_FILES
PATCH 1/1 gdb: prevent building the documentation
Quoted 3 lines
Quoted 1 line
Still, that can be done as a follow-up patch, so:
nah..., I will send a v2. Note the sed command is not indented ;-)
I will help test depending on when the patch comes through.
It'd be nice to get this in quick - there's a huge amount of noise related to this in the autobuild output.
Brendan