Skip to contentSkip to conversation

backport devcoredump

DISCUSSION Arend van Spriel 2 participants 7 messages Sep 9, 2015

lore
Share & tools
lore
#0 lore raw

Hi Johannes,

I noticed that devcoredump has been added to backports project through backport-adjustment patch. brcmfmac now select WANT_DEV_COREDUMP. However, when I run gentree.py the devcoredump patch is not applied. Also Kconfig of brcm80211 still shows WANT_DEV_COREDUMP. I tried changing it to BPAUTO_WANT_DEV_COREDUMP, but that did not help.

CC [M]
/iscsi/arend/git/brcm80211-backport/drivers/net/wireless/brcm80211/brcmfmac/debug.o /iscsi/arend/git/brcm80211-backport/drivers/net/wireless/brcm80211/brcmfmac/debug.c:19:31: fatal error: linux/devcoredump.h: No such file or directory

 #include <linux/devcoredump.h>
                               ^

compilation terminated.

Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe backports" in

#1 lore raw
Quoted 7 lines · Arend van Spriel

Hi Johannes,

I noticed that devcoredump has been added to backports project through
backport-adjustment patch. brcmfmac now select WANT_DEV_COREDUMP. However, when I run gentree.py the devcoredump patch is not applied. Also Kconfig of brcm80211 still shows WANT_DEV_COREDUMP.

That's strange.

I guess I'll need to run that - are you using a special copy-list?

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in

#2 lore raw
Quoted 9 lines · Johannes Berg
Quoted 7 lines · Arend van Spriel

Hi Johannes,

I noticed that devcoredump has been added to backports project through
backport-adjustment patch. brcmfmac now select WANT_DEV_COREDUMP. However, when I run gentree.py the devcoredump patch is not applied. Also Kconfig of brcm80211 still shows WANT_DEV_COREDUMP.

Quoted 3 lines

That's strange.

I guess I'll need to run that - are you using a special copy-list?

I do and maybe that is causing it. I attached it.

Gr. AvS

#
# This file specifies which sources are copied from the kernel

# into the backports package.
#
# Directories must end with a slash (e.g. "net/wireless/") and
# are then copied with all their contents.
#
# It is also possible to rename while copying, to do so list
# old name -> new name
# Note that in this case the spaces are needed: " -> "
#

COPYING
MAINTAINERS
include/linux/unaligned/
include/linux/hashtable.h

# 802.11
drivers/net/wireless/Kconfig
drivers/net/wireless/Makefile

include/linux/wireless.h
include/uapi/linux/wireless.h
include/linux/ieee80211.h
include/linux/pci_ids.h
include/uapi/linux/pci_regs.h
include/linux/mmc/sdio_ids.h
include/linux/ath9k_platform.h
include/uapi/linux/wil6210_uapi.h
include/linux/wl12xx.h
include/linux/rndis.h
include/linux/bcm47xx_wdt.h
include/linux/usb/usbnet.h
include/linux/usb/rndis_host.h
include/linux/spi/libertas_spi.h
include/linux/platform_data/brcmfmac-sdio.h
include/uapi/linux/nl80211.h

include/net/cfg80211.h
include/net/cfg80211-wext.h
include/net/ieee80211_radiotap.h
include/net/lib80211.h
include/net/mac80211.h
include/net/regulatory.h

net/Makefile
net/Kconfig
net/wireless/
net/mac80211/

include/linux/ssb/
drivers/bcma/
include/linux/bcma/
include/linux/bcm47xx_nvram.h
drivers/net/wireless/brcm80211/

include/net/netns/ieee802154_6lowpan.h

# MPLS labels, checked on skb->protocol on the

# respective 802 family, only ethernet seems to use
# this right now, see 960d97f95
include/linux/mpls.h
include/uapi/linux/mpls.h
#3 lore raw
Quoted 5 lines · Arend van Spriel
Quoted 2 lines

I guess I'll need to run that - are you using a special copy-list?

I do and maybe that is causing it. I attached it.

Unlikely. However, I can't reproduce your issue - if I just add "select WANT_DEV_COREDUMP" to your driver (brcmsmac) in my tree and compile with that I do get it enabled.

Can you share your driver changes for it?

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in

#4 lore raw
Quoted 10 lines · Johannes Berg
Quoted 5 lines · Arend van Spriel
Quoted 2 lines

I guess I'll need to run that - are you using a special copy-list?

I do and maybe that is causing it. I attached it.

Unlikely. However, I can't reproduce your issue - if I just add "select WANT_DEV_COREDUMP" to your driver (brcmsmac) in my tree and compile with that I do get it enabled.

Thanks for checking.

Quoted 1 line

Can you share your driver changes for it?

I will dig a bit deeper here. It must be something trivial. If I run with backports/master I do get drivers-base-devcoredump.c in compat folder so it must be in my branch which includes the copy-list change.

Gr. AvS

--
To unsubscribe from this list: send the line "unsubscribe backports" in

#5 lore raw
Quoted 11 lines · Arend van Spriel
Quoted 10 lines · Johannes Berg
Quoted 5 lines · Arend van Spriel
Quoted 2 lines

I guess I'll need to run that - are you using a special copy-list?

I do and maybe that is causing it. I attached it.

Unlikely. However, I can't reproduce your issue - if I just add "select WANT_DEV_COREDUMP" to your driver (brcmsmac) in my tree and compile with that I do get it enabled.

I guess the WANT_DEV_COREDUMP must be in the source tree to generate drivers-base-devcoredump.c etc. I used backports generated tree using my copy-list so not driver selects WANT_DEV_COREDUMP, because I applied the brcmfmac devcoredump patch on the backports generated tree.

Gr. AvS

Quoted 4 lines

Thanks for checking.

Quoted 1 line

Can you share your driver changes for it?

Quoted 8 lines

I will dig a bit deeper here. It must be something trivial. If I run with backports/master I do get drivers-base-devcoredump.c in compat folder so it must be in my branch which includes the copy-list change.

Gr. AvS

--
To unsubscribe from this list: send the line "unsubscribe backports" in

--
To unsubscribe from this list: send the line "unsubscribe backports" in

#6 lore raw
Quoted 7 lines

I guess the WANT_DEV_COREDUMP must be in the source tree to generate drivers-base-devcoredump.c etc. I used backports generated tree using my copy-list so not driver selects WANT_DEV_COREDUMP, because I applied the brcmfmac devcoredump patch on the backports generated tree.

Yes, I think you're right - I changed that at some point because I explicitly didn't want all the unused requirements to be pulled in.

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in