Skip to contentSkip to conversation

modem-manager: now needs libgudev under systemd

PATCH New yegorslists at googlemail.com 3 participants 4 messages Sep 10, 2015 – Sep 11, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 modem-manager: now needs libgudev under systemd

From: Yegor Yefremov <[email protected]>

---
 package/modem-manager/Config.in        | 3 ++-
 package/modem-manager/modem-manager.mk | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)
package/modem-manager/Config.in +2 -1
index 59b8d88..1cd502b 100644
@@ -1,11 +1,12 @@
 config BR2_PACKAGE_MODEM_MANAGER
 	bool "modemmanager"
 	depends on BR2_PACKAGE_HAS_UDEV
-	select BR2_PACKAGE_DBUS
 	depends on BR2_USE_WCHAR # libglib2 and gnutls
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
 	depends on BR2_USE_MMU # dbus
+	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_DBUS_GLIB
+	select BR2_PACKAGE_LIBGUDEV if BR2_INIT_SYSTEMD
 	help
 	  ModemManager is a DBus-activated daemon which controls mobile
 	  broadband (2G/3G/4G) devices and connections.
package/modem-manager/modem-manager.mk +4 -0
index 0e6b36a..36c8c0d 100644
@@ -12,6 +12,10 @@ MODEM_MANAGER_LICENSE_FILES = COPYING
 MODEM_MANAGER_DEPENDENCIES = host-pkgconf udev dbus-glib host-intltool
 MODEM_MANAGER_INSTALL_STAGING = YES
 
+ifeq ($(BR2_INIT_SYSTEMD),y)
+MODEM_MANAGER_DEPENDENCIES += libgudev
+endif
+
 ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
 MODEM_MANAGER_DEPENDENCIES += libqmi
 MODEM_MANAGER_CONF_OPTS += --with-qmi
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 modem-manager: now needs libgudev under systemd

Dear Yegor Yefremov,

when you say that "modem-manager: now needs libgudev for systemd", what do you mean exactly by "now"? I would expect something like "since version X" or a better explanation.

Quoted 15 lines · yegorslists at googlemail.com

From: Yegor Yefremov <[email protected]>

---
 package/modem-manager/Config.in        | 3 ++-
 package/modem-manager/modem-manager.mk | 4 ++++
 2 files changed, 6 insertions(+), 1 deletion(-)
package/modem-manager/Config.in +0 -0
index 59b8d88..1cd502b 100644

package/modem-manager/Config.in line 7

Quoted 8 lines
package/modem-manager/Config.in +1 -1
@@ -1,11 +1,12 @@
 config BR2_PACKAGE_MODEM_MANAGER
 	bool "modemmanager"
 	depends on BR2_PACKAGE_HAS_UDEV
-	select BR2_PACKAGE_DBUS
 	depends on BR2_USE_WCHAR # libglib2 and gnutls
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
 	depends on BR2_USE_MMU # dbus
+	select BR2_PACKAGE_DBUS

I know you are trying to keep all the depends together and all the selects together, but since this is not related with the goal that your patch is trying to achieve, I would do it in a separate patch.

Quoted 10 lines
package/modem-manager/Config.in +1 -0
 	select BR2_PACKAGE_DBUS_GLIB
+	select BR2_PACKAGE_LIBGUDEV if BR2_INIT_SYSTEMD
 	help
 	  ModemManager is a DBus-activated daemon which controls mobile
 	  broadband (2G/3G/4G) devices and connections.
package/modem-manager/modem-manager.mk +0 -0
index 0e6b36a..36c8c0d 100644

package/modem-manager/modem-manager.mk MODEM_MANAGER_LICENSE_FILES = COPYING · line 18

Quoted 7 lines
package/modem-manager/modem-manager.mk +4 -0
@@ -12,6 +12,10 @@ MODEM_MANAGER_LICENSE_FILES = COPYING
 MODEM_MANAGER_DEPENDENCIES = host-pkgconf udev dbus-glib host-intltool
 MODEM_MANAGER_INSTALL_STAGING = YES
 
+ifeq ($(BR2_INIT_SYSTEMD),y)
+MODEM_MANAGER_DEPENDENCIES += libgudev
+endif
+

Perhaps an explanation like the one included in this patch would useful to understand why libgudev is needed:

http://git.buildroot.net/buildroot/commit/?id=46a615bb6439a4fe69f1bfc6a347852b993d46a2

Regards,

Vincent.

Quoted 4 lines
package/modem-manager/modem-manager.mk +0 -0
 ifeq ($(BR2_PACKAGE_MODEM_MANAGER_LIBQMI),y)
 MODEM_MANAGER_DEPENDENCIES += libqmi
 MODEM_MANAGER_CONF_OPTS += --with-qmi
#2 lore raw

PATCH 1/1 modem-manager: now needs libgudev under systemd

Vicente, Yegor,

Quoted 3 lines · Vicente Olivert Riera

when you say that "modem-manager: now needs libgudev for systemd", what do you mean exactly by "now"? I would expect something like "since version X" or a better explanation.

Well, I think you're being a bit too picky here. It is indeed nicer when the information is more specific, but since there is a clear autobuilder failure, I think Yegor's commit log is good enough. Better is better, for sure :-)

Quoted 5 lines
Quoted 5 lines
package/modem-manager/Config.in +0 -1
@@ -1,11 +1,12 @@
 config BR2_PACKAGE_MODEM_MANAGER
 	bool "modemmanager"
 	depends on BR2_PACKAGE_HAS_UDEV
-	select BR2_PACKAGE_DBUS
Quoted 8 lines

package/modem-manager/Config.in line 7

Quoted 4 lines
package/modem-manager/Config.in +1 -0
 	depends on BR2_USE_WCHAR # libglib2 and gnutls
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
 	depends on BR2_USE_MMU # dbus
+	select BR2_PACKAGE_DBUS

I know you are trying to keep all the depends together and all the selects together, but since this is not related with the goal that your patch is trying to achieve, I would do it in a separate patch.

While I do agree that separating logical changes into separate commits is important, we shouldn't be too zealous about that either. So I'm personally fine with such small (but related) side changes. It's better when the commit log contains something such as:

While at it, group the existing dbus select together with the dbus-glib select, so that all "select" statements are together.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 modem-manager: now needs libgudev under systemd

Quoted 28 lines · Thomas Petazzoni

Vicente, Yegor,

Quoted 3 lines · Vicente Olivert Riera

when you say that "modem-manager: now needs libgudev for systemd", what do you mean exactly by "now"? I would expect something like "since version X" or a better explanation.

Well, I think you're being a bit too picky here. It is indeed nicer when the information is more specific, but since there is a clear autobuilder failure, I think Yegor's commit log is good enough. Better is better, for sure :-)

Quoted 5 lines
Quoted 5 lines
package/modem-manager/Config.in +0 -1
@@ -1,11 +1,12 @@
 config BR2_PACKAGE_MODEM_MANAGER
    bool "modemmanager"
    depends on BR2_PACKAGE_HAS_UDEV
-   select BR2_PACKAGE_DBUS
Quoted 8 lines

package/modem-manager/Config.in line 7

Quoted 4 lines
package/modem-manager/Config.in +1 -0
    depends on BR2_USE_WCHAR # libglib2 and gnutls
    depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
    depends on BR2_USE_MMU # dbus
+   select BR2_PACKAGE_DBUS

I know you are trying to keep all the depends together and all the selects together, but since this is not related with the goal that your patch is trying to achieve, I would do it in a separate patch.

Quoted 7 lines

While I do agree that separating logical changes into separate commits is important, we shouldn't be too zealous about that either. So I'm personally fine with such small (but related) side changes. It's better when the commit log contains something such as:

While at it, group the existing dbus select together with the dbus-glib select, so that all "select" statements are together.

So. I've sent v3. Patch description provides the whole story and if someone will want to know, why BR2_PACKAGE_LIBGUDEV is selected, he can use "git blame".

Yegor