Skip to contentSkip to conversation

vim2m: small cleanup: use assignment instead of memcpy

PATCH Hans Verkuil 1 participant 1 message Sep 15, 2015 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Use a type-safe assignment instead of memcpy. And it is easier to read as well.

drivers/media/platform/vim2m.c +2 -5
index 295fde5..d47cfba 100644
@@ -233,12 +233,9 @@ static int device_process(struct vim2m_ctx *ctx,
 
 	out_vb->v4l2_buf.sequence = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE)->sequence++;
 	in_vb->v4l2_buf.sequence = q_data->sequence++;
-	memcpy(&out_vb->v4l2_buf.timestamp,
-			&in_vb->v4l2_buf.timestamp,
-			sizeof(struct timeval));
+	out_vb->v4l2_buf.timestamp = in_vb->v4l2_buf.timestamp;
 	if (in_vb->v4l2_buf.flags & V4L2_BUF_FLAG_TIMECODE)
-		memcpy(&out_vb->v4l2_buf.timecode, &in_vb->v4l2_buf.timecode,
-			sizeof(struct v4l2_timecode));
+		out_vb->v4l2_buf.timecode = in_vb->v4l2_buf.timecode;
 	out_vb->v4l2_buf.field = in_vb->v4l2_buf.field;
 	out_vb->v4l2_buf.flags = in_vb->v4l2_buf.flags &
 		(V4L2_BUF_FLAG_TIMECODE |