.git/hooks/commit-msg.sample test is reversed
Hello everyone
In file commit-msg.sample, grep test is reversed. It greps '^Signed-off-by: '
while it should grep
'Signed-off-by: '
If you run the sample against attached file, it won't complain. Remove the ^ and it will work as expected
Regards
Federico
Commit message
Signed-off-by Me <[email protected]>
Signed-off-by Me <[email protected]>
Quoted 9 lines · Federico Fissore
Hello everyone
In file commit-msg.sample, grep test is reversed. It greps '^Signed-off-by: '
while it should grep
'Signed-off-by: 'If you run the sample against attached file, it won't complain. Remove the ^ and it will work as expected
I think the test is correct.
In grep, ^ can have two meanings:
'^foo' means "foo at the start of a line"
'[^abc]' means "one character but not a, b or c"
The Signed-off-by: trailer is meant to be at the start of a line, hence the ^.
Signature · 2 lines
Matthieu Moy http://www-verimag.imag.fr/~moy/