openvpn: add option for --enable-password-save
PATCH 1/1 openvpn: add option for --enable-password-save
Added configuration option BR2_PACKAGE_OPENVPN_PWSAVE that adds --enable-password-save to OPENVPN_CONF_OPTS if selected.
--- package/openvpn/Config.in | 6 ++++++ package/openvpn/openvpn.mk | 4 ++++ 2 files changed, 10 insertions(+)
package/openvpn/Config.in +6 -0
@@ -27,6 +27,12 @@ config BR2_PACKAGE_OPENVPN_SMALL You loose eurephia, debugging info, help messages and more. It saves around 100 KiB in binary file size. +config BR2_PACKAGE_OPENVPN_PWSAVE + bool "Allow passwords in files" + help + Allow --askpass and --auth-user-pass passwords to be + read from a file. + choice prompt "Crypto backend" default BR2_PACKAGE_OPENVPN_CRYPTO_OPENSSL
package/openvpn/openvpn.mk +4 -0
@@ -41,6 +41,10 @@ else OPENVPN_CONF_OPTS += --disable-lzo endif +ifeq ($(BR2_PACKAGE_OPENVPN_PWSAVE),y) +OPENVPN_CONF_OPTS += --enable-password-save +endif + ifeq ($(BR2_PACKAGE_OPENVPN_CRYPTO_OPENSSL),y) OPENVPN_CONF_OPTS += --with-crypto-library=openssl OPENVPN_DEPENDENCIES += openssl
Signature · 1 line
2.1.4
PATCH 1/1 openvpn: add option for --enable-password-save
Dear Wetzel Andreas,
your patch cannot be applied because your email client converted tabs to spaces:
-----------------------
Applying: openvpn: add option for --enable-password-save
error: patch failed: package/openvpn/Config.in:27
error: package/openvpn/Config.in: patch does not apply
-----------------------
Please send your patches using "git send-email".
More comments below. Please scroll down.
Quoted 14 lines · Wetzel Andreas
Added configuration option
BR2_PACKAGE_OPENVPN_PWSAVEthat adds --enable-password-save toOPENVPN_CONF_OPTSif selected.Signed-off-by Andreas Wetzel <[email protected]>--- package/openvpn/Config.in | 6 ++++++ package/openvpn/openvpn.mk | 4 ++++ 2 files changed, 10 insertions(+)package/openvpn/Config.in +0
-0
package/openvpn/Config.in config BR2_PACKAGE_OPENVPN_SMALL · line 34
Quoted 8 lines
package/openvpn/Config.in +5
-0@@ -27,6 +27,12 @@ config BR2_PACKAGE_OPENVPN_SMALL You loose eurephia, debugging info, help messages and more. It saves around 100 KiB in binary file size. +config BR2_PACKAGE_OPENVPN_PWSAVE + bool "Allow passwords in files" + help + Allow --askpass and --auth-user-pass passwords to be + read from a file.
You can still put more words in the first line of this comment if your plan is to cut it to 72 or 80 characters.
Quoted 9 lines
package/openvpn/Config.in +1
-0+ choice prompt "Crypto backend" default BR2_PACKAGE_OPENVPN_CRYPTO_OPENSSLpackage/openvpn/openvpn.mk +0
-0
package/openvpn/openvpn.mk else · line 46
Quoted 6 lines
package/openvpn/openvpn.mk +3
-0@@ -41,6 +41,10 @@ else OPENVPN_CONF_OPTS += --disable-lzo endif +ifeq ($(BR2_PACKAGE_OPENVPN_PWSAVE),y) +OPENVPN_CONF_OPTS += --enable-password-save +endif
Perhaps adding an else clause to explicitly disable password save just in case upstream changes the default behavior in the future?
Regards,
Vincent.
Quoted 5 lines
package/openvpn/openvpn.mk +1
-0+ ifeq ($(BR2_PACKAGE_OPENVPN_CRYPTO_OPENSSL),y) OPENVPN_CONF_OPTS += --with-crypto-library=openssl OPENVPN_DEPENDENCIES += openssl