Enable vlc to run as root
PATCH 1/1 Enable vlc to run as root
A great number of embedded system only include the root user. This patch has the goal of enabling vlc to be ran as root.
--- package/vlc/vlc.mk | 1 + 1 file changed, 1 insertion(+)
package/vlc/vlc.mk +1 -0
@@ -54,6 +54,7 @@ VLC_CONF_OPTS += \ --disable-mfx \ --disable-vdpau \ --disable-addonmanagermodules \ + --enable-run-as-root \ # Building static and shared doesn't work, so force static off. ifeq ($(BR2_STATIC_LIBS),)
Signature · 1 line
1.8.1.5
PATCH 1/1 Enable vlc to run as root
Dear Joao Pinto,
Regards,
Vincent.
Quoted 1 line · jpinto
A great number of embedded system only include the root user.
systems
Quoted 4 lines
This patch has the goal of enabling vlc to be ran as root.
Signed-off-by jpinto <[email protected]>Tested-by jpinto <[email protected]>
Use your full name here.
package/vlc/vlc.mk VLC_CONF_OPTS += \ · line 57
Quoted 13 lines
--- package/vlc/vlc.mk | 1 + 1 file changed, 1 insertion(+)package/vlc/vlc.mk +1
-0@@ -54,6 +54,7 @@ VLC_CONF_OPTS += \ --disable-mfx \ --disable-vdpau \ --disable-addonmanagermodules \ + --enable-run-as-root \
I don't know if running vlc as root is disabled by default due to security reasons, but if so, perhaps we could do this selectable by the user via menuconfig.
Also, there is a guy here [1] saying that although he configured it with --enable-run-as-root, it still not working:
[1]
http://www.hackersgarage.com/vlc-is-not-supposed-to-be-run-as-root-sorry-solution.html
Have you done a runtime test to check that it actually works?
Regards,
Vincent.
Quoted 4 lines
package/vlc/vlc.mk +0
-0# Building static and shared doesn't work, so force static off. ifeq ($(BR2_STATIC_LIBS),)
PATCH 1/1 Enable vlc to run as root
Hi Vicent,
Quoted 9 lines · Vicente Olivert Riera
Dear Joao Pinto,
Regards,
Vincent.
Quoted 1 line · jpinto
A great number of embedded system only include the root user.
Quoted 8 lines
systems
Quoted 4 lines
This patch has the goal of enabling vlc to be ran as root.
Signed-off-by jpinto <[email protected]>Tested-by jpinto <[email protected]>Use your full name here.
Ok, in future patches I will do it.
Quoted 5 lines
Quoted 5 lines
--- package/vlc/vlc.mk | 1 + 1 file changed, 1 insertion(+)
Quoted 13 lines
package/vlc/vlc.mk VLC_CONF_OPTS += \ · line 57
Quoted 9 lines
package/vlc/vlc.mk +1
-0@@ -54,6 +54,7 @@ VLC_CONF_OPTS += \ --disable-mfx \ --disable-vdpau \ --disable-addonmanagermodules \ + --enable-run-as-root \I don't know if running vlc as root is disabled by default due to security reasons, but if so, perhaps we could do this selectable by the user via menuconfig.
I understand that security might be an issue since VLC is not used only for reproducing video.
Quoted 3 lines
Also, there is a guy here [1] saying that although he configured it with --enable-run-as-root, it still not working:
For me worked fine with this change.
Quoted 5 lines
[1]
http://www.hackersgarage.com/vlc-is-not-supposed-to-be-run-as-root-sorry-solution.htmlHave you done a runtime test to check that it actually works?
Yes, I made a project using the ARM Juno r1 board and worked perfectly.
Quoted 9 lines
Regards,
Vincent.
Quoted 4 lines
package/vlc/vlc.mk +0
-0# Building static and shared doesn't work, so force static off. ifeq ($(BR2_STATIC_LIBS),)
Thanks,
Joao Pinto
PATCH 1/1 Enable vlc to run as root
Hello,
Quoted 8 lines · Joao Pinto
Quoted 6 lines
Quoted 4 lines
This patch has the goal of enabling vlc to be ran as root.
Signed-off-by jpinto <[email protected]>Tested-by jpinto <[email protected]>Use your full name here.
Ok, in future patches I will do it.
We actually need your full name for this patch as well. Signed-off-by is a legal statement, so we need people to use their full name.
Can you send a v2 of your patch?
Quoted 3 lines
Quoted 3 lines
I don't know if running vlc as root is disabled by default due to security reasons, but if so, perhaps we could do this selectable by the user via menuconfig.
I don't think this is necessary. We don't do that for any of the other packages in Buildroot. So from my point of view, the patch is OK, it only needs to be resubmitted with a full name (as the From and in Signed-off-by).
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com