Signed-off-by: Hiroshi Kawashima <[email protected]>
PATCH 1/1 Signed-off-by: Hiroshi Kawashima <[email protected]>
Adding new package, squeezelite is a sound client for Logitech Media Server.
--- package/squeezelite/Config.in | 30 ++++++++++++++++++++++++++++++ package/squeezelite/squeezelite.mk | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+), 0 deletions(-) create mode 100644 package/squeezelite/Config.in create mode 100644 package/squeezelite/squeezelite.mk
package/squeezelite/Config.in new file +30 -0
@@ -0,0 +1,30 @@ +config BR2_PACKAGE_SQUEEZELITE + bool "squeezelite" + depends on BR2_USE_WCHAR # flac + select BR2_PACKAGE_ALSA_LIB + select BR2_PACKAGE_FLAC + select BR2_PACKAGE_LIBMAD + select BR2_PACKAGE_LIBVORBIS + select BR2_PACKAGE_FAAD2 + select BR2_PACKAGE_MPG123 + select BR2_PACKAGE_LIBSOXR + help + Logitech Media Server client + https://code.google.com/p/squeezelite/ + +config BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE + bool "Enable resampling function" + default y + depends on BR2_PACKAGE_SQUEEZELITE + help + Enable resampling function + +config BR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP + bool "Use OpenMP for resampling" + default y + depends on BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE + help + Enable OpenMP support for resampling + +comment "squeezelite needs a toolchain w/ wchar (incur from flac)" + depends on !BR2_USE_WCHAR
package/squeezelite/squeezelite.mk new file +34 -0
@@ -0,0 +1,34 @@ +################################################################################ +# +# squeezelite -- Logitech Media Server client +# +################################################################################ + +SQUEEZELITE_VERSION = v1.8 +SQUEEZELITE_SITE = https://code.google.com/p/squeezelite +SQUEEZELITE_SITE_METHOD = git +SQUEEZELITE_LICENSE = GPLv3 +SQUEEZELITE_LICENSE_FILE = LICENSE.txt +SQUEEZELITE_INSTALL_STAGING = NO +SQUEEZELITE_DEPENDENCIES = alsa-lib flac libmad libvorbis faad2 mpg123 libsoxr + +#SQUEEZELITE_OPTS = "-DLINKALL" +SQUEEZELITE_OPTS = "" + +ifeq ($(BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE),y) + SQUEEZELITE_OPTS += -DRESAMPLE + ifeq ($(BR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP),y) + SQUEEZELITE_OPTS += -DRESAMPLE_MP + endif +endif + +define SQUEEZELITE_BUILD_CMDS + $(MAKE) OPTS="$(SQUEEZELITE_OPTS)" \ + CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all +endef + +define SQUEEZELITE_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/squeezelite $(TARGET_DIR)/usr/bin +endef + +$(eval $(generic-package))
Signature · 4 lines
1.7.1
============================================================
Hiroshi KawashimaPATCH 1/1 Signed-off-by: Hiroshi Kawashima <[email protected]>
Dear Hiroshi Kawashima,
you have put your SoB in the subject, when it should be at the bottom of your commit log.
Also, it's good to use the standard subject when adding new packages:
<PKG>: new package
See an example here:
http://git.buildroot.net/buildroot/commit
/?id=9646e80fca281030eb5d3125f499a60231476373
Also, when sending a new version, you have to add v2 (or the version number) after PATCH in your subject and a small changelog so other can know what changed between versions. And don't forget yo mark your previous patch as superseded in Patchwork. Worth reading this:
http://nightly.buildroot.org/manual.html#submitting-patches
More comments below; please keep reading.
Quoted 14 lines · Hiroshi Kawashima
Adding new package, squeezelite is a sound client for Logitech Media Server.
--- package/squeezelite/Config.in | 30 ++++++++++++++++++++++++++++++ package/squeezelite/squeezelite.mk | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+), 0 deletions(-)create mode 100644 package/squeezelite/Config.in create mode 100644
package/squeezelite/squeezelite.mkpackage/squeezelite/Config.in new file +0
-0
package/squeezelite/Config.in line 3
Quoted 3 lines
package/squeezelite/Config.in new file +3
-0@@ -0,0 +1,30 @@ +config BR2_PACKAGE_SQUEEZELITE + bool "squeezelite" + depends on BR2_USE_WCHAR # flac
No tab before the comment. Just a space.
You are also missing a dependency on MMU introduced by MPG123, so:
depends on BR2_USE_MMU # mpg123
And you are also missing a dependency on THREADS introduced by ALSA_LIB, so:
depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
Quoted 16 lines
package/squeezelite/Config.in new file +16
-0+ select BR2_PACKAGE_ALSA_LIB + select BR2_PACKAGE_FLAC + select BR2_PACKAGE_LIBMAD + select BR2_PACKAGE_LIBVORBIS + select BR2_PACKAGE_FAAD2 + select BR2_PACKAGE_MPG123 + select BR2_PACKAGE_LIBSOXR + help + Logitech Media Server client + https://code.google.com/p/squeezelite/ + +config BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE + bool "Enable resampling function" + default y + depends on BR2_PACKAGE_SQUEEZELITE + help
package/squeezelite/Config.in line 29
Quoted 10 lines
package/squeezelite/Config.in new file +10
-0+ Enable resampling function + +config BR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP + bool "Use OpenMP for resampling" + default y + depends on BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE + help + Enable OpenMP support for resampling + +comment "squeezelite needs a toolchain w/ wchar (incur from flac)"
I would place this comment at the end of the BR2_PACKAGE_SQUEEZELITE, before defining the BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE and BR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP.
The "(incur from flac)" comment is not needed.
You need to add "threads" to the comment as well. It should look like this:
comment "squeezelite needs a toolchain w/ wchar, threads"
package/squeezelite/Config.in line 30
Quoted 1 line
package/squeezelite/Config.in new file +1
-0+ depends on !BR2_USE_WCHAR
And you also need to put the MMU and THREAD dependencies here, so it should look like this:
depends on BR2_USE_MMU
depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
package/squeezelite/squeezelite.mk line 3
Quoted 9 lines
package/squeezelite/squeezelite.mk new file +3
-0@@ -0,0 +1,34 @@ +################################################################################ +# +# squeezelite -- Logitech Media Server client
Only the package name here. No description.
package/squeezelite/squeezelite.mk line 12
Quoted 9 lines
package/squeezelite/squeezelite.mk new file +9
-0+# +################################################################################ + +SQUEEZELITE_VERSION = v1.8 +SQUEEZELITE_SITE = https://code.google.com/p/squeezelite +SQUEEZELITE_SITE_METHOD = git +SQUEEZELITE_LICENSE = GPLv3 +SQUEEZELITE_LICENSE_FILE = LICENSE.txt +SQUEEZELITE_INSTALL_STAGING = NO
It won't be installed in staging by default, so this line is not needed.
package/squeezelite/squeezelite.mk line 15
Quoted 3 lines
package/squeezelite/squeezelite.mk new file +3
-0+SQUEEZELITE_DEPENDENCIES = alsa-lib flac libmad libvorbis faad2 mpg123 libsoxr + +#SQUEEZELITE_OPTS = "-DLINKALL"
What's this? If it's not used, then remove it.
package/squeezelite/squeezelite.mk line 16
Quoted 1 line
package/squeezelite/squeezelite.mk new file +1
-0+SQUEEZELITE_OPTS = ""
You don't need to initialize this. Anyway, keep reading as there are more comments regarding this variable.
package/squeezelite/squeezelite.mk line 19
Quoted 3 lines
package/squeezelite/squeezelite.mk new file +3
-0+ +ifeq ($(BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE),y) + SQUEEZELITE_OPTS += -DRESAMPLE
Better to use a variable name like SQUEEZELITE_MAKE_OPTS which is commonly used in Buildroot.
package/squeezelite/squeezelite.mk line 21
Quoted 2 lines
package/squeezelite/squeezelite.mk new file +2
-0+ ifeq ($(BR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP),y) + SQUEEZELITE_OPTS += -DRESAMPLE_MP
Same here.
package/squeezelite/squeezelite.mk line 26
Quoted 5 lines
package/squeezelite/squeezelite.mk new file +5
-0+ endif +endif + +define SQUEEZELITE_BUILD_CMDS + $(MAKE) OPTS="$(SQUEEZELITE_OPTS)" \
$(TARGET_MAKE_ENV) always in front of $(MAKE). And also use $(SQUEEZELITE_MAKE_OPTS).
package/squeezelite/squeezelite.mk line 34
Quoted 9 lines
package/squeezelite/squeezelite.mk new file +8
-0+ CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all +endef + +define SQUEEZELITE_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/squeezelite $(TARGET_DIR)/usr/bin +endef + +$(eval $(generic-package))
Also, when you add a new package, you need to add it to the right category in package/Config.in, otherwise the users won't be able to select it from the menuconfig.
Regards,
Vincent.
PATCH 1/1 Signed-off-by: Hiroshi Kawashima <[email protected]>
Dear, Vincent.
I will post improved patch later.
Thank you again.
Quoted 174 lines
2015/09/19 17:34?Vincent Olivert Riera <[email protected]> ?????
Dear Hiroshi Kawashima,
you have put your SoB in the subject, when it should be at the bottom of your commit log.
Also, it's good to use the standard subject when adding new packages:
<PKG>: new package
See an example here:
http://git.buildroot.net/buildroot/commit
/?id=9646e80fca281030eb5d3125f499a60231476373Also, when sending a new version, you have to add v2 (or the version number) after PATCH in your subject and a small changelog so other can know what changed between versions. And don't forget yo mark your previous patch as superseded in Patchwork. Worth reading this:
http://nightly.buildroot.org/manual.html#submitting-patches
More comments below; please keep reading.
Quoted 14 lines · Hiroshi Kawashima
Adding new package, squeezelite is a sound client for Logitech Media Server.
--- package/squeezelite/Config.in | 30 ++++++++++++++++++++++++++++++ package/squeezelite/squeezelite.mk | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+), 0 deletions(-) create mode 100644 package/squeezelite/Config.in create mode 100644 package/squeezelite/squeezelite.mkpackage/squeezelite/Config.in new file +0
-0package/squeezelite/Config.in line 3
Quoted 3 lines
package/squeezelite/Config.in new file +3
-0@@ -0,0 +1,30 @@ +config BR2_PACKAGE_SQUEEZELITE + bool "squeezelite" + depends on BR2_USE_WCHAR # flacNo tab before the comment. Just a space.
You are also missing a dependency on MMU introduced by MPG123, so:
depends on
BR2_USE_MMU# mpg123And you are also missing a dependency on THREADS introduced by
ALSA_LIB, so:depends on
BR2_TOOLCHAIN_HAS_THREADS# alsa-libQuoted 16 lines
package/squeezelite/Config.in new file +16
-0+ select BR2_PACKAGE_ALSA_LIB + select BR2_PACKAGE_FLAC + select BR2_PACKAGE_LIBMAD + select BR2_PACKAGE_LIBVORBIS + select BR2_PACKAGE_FAAD2 + select BR2_PACKAGE_MPG123 + select BR2_PACKAGE_LIBSOXR + help + Logitech Media Server client + https://code.google.com/p/squeezelite/ + +config BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE + bool "Enable resampling function" + default y + depends on BR2_PACKAGE_SQUEEZELITE + helppackage/squeezelite/Config.in line 29
Quoted 10 lines
package/squeezelite/Config.in new file +10
-0+ Enable resampling function + +config BR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP + bool "Use OpenMP for resampling" + default y + depends on BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE + help + Enable OpenMP support for resampling + +comment "squeezelite needs a toolchain w/ wchar (incur from flac)"I would place this comment at the end of the
BR2_PACKAGE_SQUEEZELITE, before defining theBR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLEandBR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP.The "(incur from flac)" comment is not needed.
You need to add "threads" to the comment as well. It should look like this:
comment "squeezelite needs a toolchain w/ wchar, threads"
package/squeezelite/Config.in line 30
Quoted 1 line
package/squeezelite/Config.in new file +1
-0+ depends on !BR2_USE_WCHARAnd you also need to put the MMU and THREAD dependencies here, so it should look like this:
depends on
BR2_USE_MMU
depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADSpackage/squeezelite/squeezelite.mk line 3
Quoted 9 lines
package/squeezelite/squeezelite.mk new file +3
-0@@ -0,0 +1,34 @@ +################################################################################ +# +# squeezelite -- Logitech Media Server clientOnly the package name here. No description.
package/squeezelite/squeezelite.mk line 12
Quoted 9 lines
package/squeezelite/squeezelite.mk new file +9
-0+# +################################################################################ + +SQUEEZELITE_VERSION = v1.8 +SQUEEZELITE_SITE = https://code.google.com/p/squeezelite +SQUEEZELITE_SITE_METHOD = git +SQUEEZELITE_LICENSE = GPLv3 +SQUEEZELITE_LICENSE_FILE = LICENSE.txt +SQUEEZELITE_INSTALL_STAGING = NOIt won't be installed in staging by default, so this line is not needed.
package/squeezelite/squeezelite.mk line 15
Quoted 3 lines
package/squeezelite/squeezelite.mk new file +3
-0+SQUEEZELITE_DEPENDENCIES = alsa-lib flac libmad libvorbis faad2 mpg123 libsoxr + +#SQUEEZELITE_OPTS = "-DLINKALL"What's this? If it's not used, then remove it.
package/squeezelite/squeezelite.mk line 16
Quoted 1 line
package/squeezelite/squeezelite.mk new file +1
-0+SQUEEZELITE_OPTS = ""You don't need to initialize this. Anyway, keep reading as there are more comments regarding this variable.
package/squeezelite/squeezelite.mk line 19
Quoted 3 lines
package/squeezelite/squeezelite.mk new file +3
-0+ +ifeq ($(BR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLE),y) + SQUEEZELITE_OPTS += -DRESAMPLEBetter to use a variable name like
SQUEEZELITE_MAKE_OPTSwhich is commonly used in Buildroot.package/squeezelite/squeezelite.mk line 21
Quoted 2 lines
package/squeezelite/squeezelite.mk new file +2
-0+ ifeq ($(BR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP),y) + SQUEEZELITE_OPTS += -DRESAMPLE_MPSame here.
package/squeezelite/squeezelite.mk line 26
Quoted 5 lines
package/squeezelite/squeezelite.mk new file +5
-0+ endif +endif + +define SQUEEZELITE_BUILD_CMDS + $(MAKE) OPTS="$(SQUEEZELITE_OPTS)" \$(TARGET_MAKE_ENV) always in front of $(MAKE). And also use $(SQUEEZELITE_MAKE_OPTS).
package/squeezelite/squeezelite.mk line 34
Quoted 9 lines
package/squeezelite/squeezelite.mk new file +8
-0+ CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all +endef + +define SQUEEZELITE_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/squeezelite $(TARGET_DIR)/usr/bin +endef + +$(eval $(generic-package))Also, when you add a new package, you need to add it to the right category in package/Config.in, otherwise the users won't be able to select it from the menuconfig.
Regards,
Vincent.
PATCH 1/1 Signed-off-by: Hiroshi Kawashima <[email protected]>
In reply to Vincent Olivert RieraOn 19-09-15 10:34, Vincent Olivert Riera wrote:
[snip]
Quoted 1 line · Hiroshi Kawashima
[snip]
Quoted 5 lines
Quoted 1 line
+comment "squeezelite needs a toolchain w/ wchar (incur from flac)"
I would place this comment at the end of the
BR2_PACKAGE_SQUEEZELITE, before defining theBR2_PACKAGE_SQUEEZELITE_ENABLE_RESAMPLEandBR2_PACKAGE_SQUEEZELITE_WITH_RESAMPLE_MP.
No, wrong. The comment should always be either at the beginning or at the end
of the file. Otherwise, the indentation of the sub-options will be wrong (i.e., they won't be indented).
Regards,
Arnout
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF