mx6ul_14x14_evk: Remove dead code
PATCH 1/3 mx6ul_14x14_evk: Remove dead code
iox74lv_set() is not used anywhere, so let's remove it.
--- board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 43 ----------------------- 1 file changed, 43 deletions(-)
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c +0 -43
@@ -155,49 +155,6 @@ static void iox74lv_init(void)gpio_direction_output (IOX_OE ,1 ); }; -void iox74lv_set (int index) -{ -int i; - -gpio_direction_output (IOX_OE ,0 ); - -for (i =7 ; i >=0 ; i--) { -gpio_direction_output (IOX_SHCP ,0 ); - -if (i == index) -gpio_direction_output (IOX_SDI , seq[qn_output[i]][0 ]); -else -gpio_direction_output (IOX_SDI , seq[qn_output[i]][1 ]); -udelay (500 ); -gpio_direction_output (IOX_SHCP ,1 ); -udelay (500 ); - } - -gpio_direction_output (IOX_STCP ,0 ); -udelay (500 ); -/* -* shift register will be output to pins -*/ -gpio_direction_output (IOX_STCP ,1 ); - -for (i =7 ; i >=0 ; i--) { -gpio_direction_output (IOX_SHCP ,0 ); -gpio_direction_output (IOX_SDI , seq[qn_output[i]][1 ]); -udelay (500 ); -gpio_direction_output (IOX_SHCP ,1 ); -udelay (500 ); - } - -gpio_direction_output (IOX_STCP ,0 ); -udelay (500 ); -/* -* shift register will be output to pins -*/ -gpio_direction_output (IOX_STCP ,1 ); - -gpio_direction_output (IOX_OE ,1 ); -}; -#ifdef CONFIG_SYS_I2C_MXC #define PC MUX_PAD_CTRL(I2C_PAD_CTRL)/* I2C1 for PMIC and EEPROM */
Signature · 1 line
1.9.1
PATCH 2/3 mx6ul_14x14_evk: Staticize when possible
Make the internal symbols static when possible.
This prevents sparse build warnings.
--- board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c +2 -2
@@ -158,7 +158,7 @@ static void iox74lv_init(void) #ifdef CONFIG_SYS_I2C_MXC #define PC MUX_PAD_CTRL(I2C_PAD_CTRL) /* I2C1 for PMIC and EEPROM */ -struct i2c_pads_info i2c_pad_info1 = { +static struct i2c_pads_info i2c_pad_info1 = { .scl = { .i2c_mode = MX6_PAD_UART4_TX_DATA__I2C1_SCL | PC, .gpio_mode = MX6_PAD_UART4_TX_DATA__GPIO1_IO28 | PC,
@@ -313,7 +313,7 @@ static iomux_v3_cfg_t const quadspi_pads[] = { MX6_PAD_NAND_DQS__QSPI_A_SS0_B | MUX_PAD_CTRL(QSPI_PAD_CTRL1), }; -int board_qspi_init (void ) +static int board_qspi_init (void ) {/* Set the iomux */ imx_iomux_v3_setup_multiple_pads(quadspi_pads,
Signature · 1 line
1.9.1
PATCH 2/3 mx6ul_14x14_evk: Staticize when possible
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c
Quoted 11 lines · Fabio Estevam
Make the internal symbols static when possible.
This prevents sparse build warnings.
Signed-off-by Fabio Estevam <[email protected]>--- board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c +0
-0
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 3/3 mx6ul_14x14_evk: Remove get_board_rev()
In reply to Fabio Estevamget_board_rev() is not actually providing the board revision.
It just returns the CPU revision instead.
As the CPU revision is already printed on boot, there is no reason to have get_board_rev(), so let's remove it.
--- board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c | 5 ----- 1 file changed, 5 deletions(-)
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c +0 -5
@@ -631,11 +631,6 @@ int board_late_init(void)return 0 ; } -u32 get_board_rev (void ) -{ -return get_cpu_rev (); -} -int checkboard (void ) {if (is_mx6ul_9x9_evk ())
Signature · 1 line
1.9.1
PATCH 3/3 mx6ul_14x14_evk: Remove get_board_rev()
Quoted 9 lines · Fabio Estevam
get_board_rev()is not actually providing the board revision.It just returns the CPU revision instead.
As the CPU revision is already printed on boot, there is no reason to have
get_board_rev(), so let's remove it.Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/3 mx6ul_14x14_evk: Remove dead code
In reply to Fabio EstevamQuoted 4 lines · Fabio Estevam
iox74lv_set()is not used anywhere, so let's remove it.Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================