Skip to contentSkip to conversation

mtd: nand: mxs check maximum ecc that platfrom supports

PATCH New Peng Fan 2 participants 2 messages Sep 7, 2015 – Sep 20, 2015

Subsystems (3)
lore
Share & tools
lore

Peng Fan

author
#0 lore raw

PATCH v3 1/1 mtd: nand: mxs check maximum ecc that platfrom supports

Check maximum ecc strength for each platfrom to avoid the calculated ecc exceed the limitation.

---

Original V2 mail thread:
http://lists.denx.de/pipermail/u-boot/2015-August/225362.html

Because is_cpu_type was not merged to uboot upstream at that time, this patch can not be compiled successfully. Since now is_cpu_type is already in uboot upstream master branch, this patch can be applied and built without failure.

Changes v3:
Add Scott's Acked by
Add Tim's Tested by

Changes v2:
Add Marek's reviewed by.

 drivers/mtd/nand/mxs_nand.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
drivers/mtd/nand/mxs_nand.c +8 -1
index 1d68901..f15cf36 100644
@@ -149,6 +149,13 @@ static inline uint32_t mxs_nand_get_ecc_strength(uint32_t page_data_size,
 						uint32_t page_oob_size)
 {
 	int ecc_strength;
+	int max_ecc_strength_supported;
+
+	/* Refer to Chapter 17 for i.MX6DQ, Chapter 18 for i.MX6SX */
+	if (is_cpu_type(MXC_CPU_MX6SX))
+		max_ecc_strength_supported = 62;
+	else
+		max_ecc_strength_supported = 40;
 
 	/*
 	 * Determine the ECC layout with the formula:
@@ -162,7 +169,7 @@ static inline uint32_t mxs_nand_get_ecc_strength(uint32_t page_data_size,
 			/ (galois_field *
 			   mxs_nand_ecc_chunk_cnt(page_data_size));
 
-	return round_down(ecc_strength, 2);
+	return min(round_down(ecc_strength, 2), max_ecc_strength_supported);
 }
 
 static inline uint32_t mxs_nand_get_mark_offset(uint32_t page_data_size,
Signature · 1 line
1.8.4
#1 lore raw

PATCH v3 1/1 mtd: nand: mxs check maximum ecc that platfrom supports

Quoted 11 lines · Peng Fan

Check maximum ecc strength for each platfrom to avoid the calculated ecc exceed the limitation.

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================