Skip to contentSkip to conversation

Kconfig: net: give PHYLIB to designware driver

PATCH New Olliver Schinagl 3 participants 5 messages Sep 18, 2015 – Sep 21, 2015 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Kconfig: net: give PHYLIB to designware driver

From: Olliver Schinagl <[email protected]>

The designware driver has a build guard which makes it to only work when using the PHYLIB. With b68fe152272 the PHYLIB was added to the net Kconfig but not selected by all hardware depending on it.

This patch enables PHYLIB for the Designware MAC

---
 drivers/net/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/Kconfig +2 -2
index bbec6a6..51b1668 100644
@@ -79,10 +79,10 @@ config ETH_SANDBOX_RAW
 
 config ETH_DESIGNWARE
 	bool "Synopsys Designware Ethernet MAC"
+	select PHYLIB
 	help
 	  This MAC is present in SoCs from various vendors. It supports
-	  100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
-	  provide the PHY (physical media interface).
+	  100Mbit and 1 Gbit operation.
 
 config PCH_GBE
 	bool "Intel Platform Controller Hub EG20T GMAC driver"
Signature · 1 line
2.5.1
#1 lore raw

PATCH 1/1 Kconfig: net: give PHYLIB to designware driver

Hi Olliver,

Quoted 21 lines · Olliver Schinagl

From: Olliver Schinagl <[email protected]>

The designware driver has a build guard which makes it to only work when using the PHYLIB. With b68fe152272 the PHYLIB was added to the net Kconfig but not selected by all hardware depending on it.

This patch enables PHYLIB for the Designware MAC

---
 drivers/net/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/Kconfig +0 -0
index bbec6a6..51b1668 100644
@@ -79,10 +79,10 @@ config ETH_SANDBOX_RAW
 
 config ETH_DESIGNWARE
        bool "Synopsys Designware Ethernet MAC"

drivers/net/Kconfig config ETH_SANDBOX_RAW

Quoted 10 lines
drivers/net/Kconfig +2 -3
+       select PHYLIB
        help
          This MAC is present in SoCs from various vendors. It supports
-         100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
-         provide the PHY (physical media interface).
+         100Mbit and 1 Gbit operation.
 
 config PCH_GBE
        bool "Intel Platform Controller Hub EG20T GMAC driver"
--

This is not enough. You need update all borads' config.h files to remove CONFIG_PHYLIB, otherwise it causes redefinition warnings.

Regards,
Bin

#2 lore raw

PATCH 1/1 Kconfig: net: give PHYLIB to designware driver

Hey Bin,

Quoted 32 lines · Bin Meng

Hi Olliver,

Quoted 28 lines · Olliver Schinagl

From: Olliver Schinagl <[email protected]>

The designware driver has a build guard which makes it to only work when using the PHYLIB. With b68fe152272 the PHYLIB was added to the net Kconfig but not selected by all hardware depending on it.

This patch enables PHYLIB for the Designware MAC

---
  drivers/net/Kconfig | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/Kconfig +2 -2
index bbec6a6..51b1668 100644
@@ -79,10 +79,10 @@ config ETH_SANDBOX_RAW
 
  config ETH_DESIGNWARE
         bool "Synopsys Designware Ethernet MAC"
+       select PHYLIB
         help
           This MAC is present in SoCs from various vendors. It supports
-         100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
-         provide the PHY (physical media interface).
+         100Mbit and 1 Gbit operation.
 
Quoted 5 lines

drivers/net/Kconfig config ETH_SANDBOX_RAW

Quoted 3 lines
drivers/net/Kconfig +0 -1
  config PCH_GBE
         bool "Intel Platform Controller Hub EG20T GMAC driver"
--

This is not enough. You need update all borads' config.h files to remove CONFIG_PHYLIB, otherwise it causes redefinition warnings.

I was being conservative here,

Is it enough to only do the boards that are featured using Kconfig?

Quoted 3 lines

Regards,
Bin

Signature · 5 lines
Met vriendelijke groeten, Kind regards, ??????

Olliver Schinagl
Research & Development
Ultimaker B.V.
#3 lore raw

PATCH 1/1 Kconfig: net: give PHYLIB to designware driver

Hi Olliver,

Quoted 45 lines · Olliver Schinagl

Hey Bin,

Quoted 34 lines · Bin Meng

Hi Olliver,

Quoted 29 lines · Olliver Schinagl

From: Olliver Schinagl <[email protected]>

The designware driver has a build guard which makes it to only work when using the PHYLIB. With b68fe152272 the PHYLIB was added to the net Kconfig but not selected by all hardware depending on it.

This patch enables PHYLIB for the Designware MAC

---
  drivers/net/Kconfig | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/Kconfig +2 -2
index bbec6a6..51b1668 100644
@@ -79,10 +79,10 @@ config ETH_SANDBOX_RAW
 
  config ETH_DESIGNWARE
         bool "Synopsys Designware Ethernet MAC"
+       select PHYLIB
         help
           This MAC is present in SoCs from various vendors. It supports
-         100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
-         provide the PHY (physical media interface).
+         100Mbit and 1 Gbit operation.
 
Quoted 6 lines

drivers/net/Kconfig config ETH_SANDBOX_RAW

Quoted 3 lines
drivers/net/Kconfig +0 -1
  config PCH_GBE
         bool "Intel Platform Controller Hub EG20T GMAC driver"
--

This is not enough. You need update all borads' config.h files to remove CONFIG_PHYLIB, otherwise it causes redefinition warnings.

Quoted 3 lines

I was being conservative here,

Is it enough to only do the boards that are featured using Kconfig?

I think all boards have been converted to Kconfig, no?

Quoted 8 lines
Quoted 4 lines

Regards,
Bin

--
Met vriendelijke groeten, Kind regards, ??????

Ah, you know Chinese :-)

Quoted 5 lines

Olliver Schinagl
Research & Development
Ultimaker B.V.

Regards,
Bin

#4 lore raw

PATCH 1/1 Kconfig: net: give PHYLIB to designware driver

Hey Bin,

Quoted 45 lines · Bin Meng

Hi Olliver,

Quoted 41 lines · Olliver Schinagl

Hey Bin,

Quoted 37 lines · Bin Meng

Hi Olliver,

Quoted 21 lines · Olliver Schinagl

From: Olliver Schinagl <[email protected]>

The designware driver has a build guard which makes it to only work when using the PHYLIB. With b68fe152272 the PHYLIB was added to the net Kconfig but not selected by all hardware depending on it.

This patch enables PHYLIB for the Designware MAC

---
   drivers/net/Kconfig | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/Kconfig +0 -0
index bbec6a6..51b1668 100644
@@ -79,10 +79,10 @@ config ETH_SANDBOX_RAW
 
   config ETH_DESIGNWARE
          bool "Synopsys Designware Ethernet MAC"

drivers/net/Kconfig config ETH_SANDBOX_RAW

Quoted 10 lines
drivers/net/Kconfig +2 -3
+       select PHYLIB
          help
            This MAC is present in SoCs from various vendors. It supports
-         100Mbit and 1 Gbit operation. You must enable CONFIG_PHYLIB to
-         provide the PHY (physical media interface).
+         100Mbit and 1 Gbit operation.
 
   config PCH_GBE
          bool "Intel Platform Controller Hub EG20T GMAC driver"
--

This is not enough. You need update all borads' config.h files to remove CONFIG_PHYLIB, otherwise it causes redefinition warnings.

Quoted 4 lines
Quoted 3 lines

I was being conservative here,

Is it enough to only do the boards that are featured using Kconfig?

I think all boards have been converted to Kconfig, no?

I'm not sure but will check and work this out.

Quoted 8 lines
Quoted 7 lines
Quoted 4 lines

Regards,
Bin

--
Met vriendelijke groeten, Kind regards, ??????

Ah, you know Chinese :-)

Copy paste style yeah ;)

Olliver

Quoted 11 lines
Quoted 5 lines

Olliver Schinagl
Research & Development
Ultimaker B.V.

Regards,
Bin

Signature · 2 lines
Visit us at
http://linux-sunxi.org