common/board_f.c: modify the macro to use get_clocks() more common
PATCH v2 2/16 common/board_f.c: modify the macro to use get_clocks() more common
get_clocks() should not be limited by ESDHC.
--- common/board_f.c | 2 +- include/configs/BSC9132QDS.h | 1 + include/configs/MPC8308RDB.h | 1 + include/configs/MPC837XEMDS.h | 1 + include/configs/MPC837XERDB.h | 1 + include/configs/MPC8536DS.h | 1 + include/configs/MPC8569MDS.h | 1 + include/configs/P1010RDB.h | 1 + include/configs/P1022DS.h | 1 + include/configs/P2041RDB.h | 1 + include/configs/T102xQDS.h | 1 + include/configs/T102xRDB.h | 1 + include/configs/T1040QDS.h | 1 + include/configs/T104xRDB.h | 1 + include/configs/T208xQDS.h | 1 + include/configs/T208xRDB.h | 1 + include/configs/T4240QDS.h | 1 + include/configs/T4240RDB.h | 1 + include/configs/UCP1020.h | 1 + include/configs/colibri_vf.h | 1 + include/configs/controlcenterd.h | 1 + include/configs/corenet_ds.h | 1 + include/configs/hrcon.h | 1 + include/configs/ima3-mx53.h | 1 + include/configs/ls1021aqds.h | 1 + include/configs/ls1021atwr.h | 1 + include/configs/ls2085aqds.h | 1 + include/configs/ls2085ardb.h | 1 + include/configs/m53evk.h | 1 + include/configs/mx25pdk.h | 1 + include/configs/mx35pdk.h | 1 + include/configs/mx51_efikamx.h | 1 + include/configs/mx51evk.h | 1 + include/configs/mx53ard.h | 1 + include/configs/mx53evk.h | 1 + include/configs/mx53loco.h | 1 + include/configs/mx53smd.h | 1 + include/configs/mx6_common.h | 1 + include/configs/p1_p2_rdb_pc.h | 1 + include/configs/p1_twr.h | 1 + include/configs/usbarmory.h | 1 + include/configs/vf610twr.h | 1 + include/configs/vision2.h | 1 + include/configs/woodburn_common.h | 1 + 44 files changed, 44 insertions(+), 1 deletion(-)
common/board_f.c +1 -1
@@ -806,7 +806,7 @@ static init_fnc_t init_sequence_f[] = {#if defined(CONFIG_BOARD_POSTCLK_INIT ) board_postclk_init,#endif -#ifdef CONFIG_FSL_ESDHC +#ifdef CONFIG_FSL_CLK get_clocks,#endif #ifdef CONFIG_M68K
include/configs/BSC9132QDS.h +1 -0
@@ -18,6 +18,7 @@#define CONFIG_BSC9132 #endif +#define CONFIG_FSL_CLK #define CONFIG_MISC_INIT_R #ifdef CONFIG_SDCARD
include/configs/MPC8308RDB.h +1 -0
@@ -11,6 +11,7 @@#define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK /* * High Level Configuration Options
include/configs/MPC837XEMDS.h +1 -0
@@ -10,6 +10,7 @@#define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK /* * High Level Configuration Options
include/configs/MPC837XERDB.h +1 -0
@@ -17,6 +17,7 @@#define CONFIG_MPC837XERDB 1#define CONFIG_DISPLAY_BOARDINFO #define CONFIG_SYS_GENERIC_BOARD +#define CONFIG_FSL_CLK #define CONFIG_SYS_TEXT_BASE 0xFE000000
include/configs/MPC8536DS.h +1 -0
@@ -13,6 +13,7 @@#define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #include "../board/freescale/common/ics307_clk.h" #ifdef CONFIG_36BIT
include/configs/MPC8569MDS.h +1 -0
@@ -13,6 +13,7 @@#define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK /* High Level Configuration Options */ #define CONFIG_BOOKE 1/* BOOKE */ #define CONFIG_E500 1/* BOOKE e500 family */
include/configs/P1010RDB.h +1 -0
@@ -16,6 +16,7 @@#endif #define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #define CONFIG_P1010 #define CONFIG_E500 /* BOOKE e500 family */
include/configs/P1022DS.h +1 -0
@@ -13,6 +13,7 @@#define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #ifdef CONFIG_36BIT #define CONFIG_PHYS_64BIT
include/configs/P2041RDB.h +1 -0
@@ -16,6 +16,7 @@#define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO #define CONFIG_PPC_P2041 +#define CONFIG_FSL_CLK #ifdef CONFIG_RAMBOOT_PBL #define CONFIG_RAMBOOT_TEXT_BASE CONFIG_SYS_TEXT_BASE
include/configs/T102xQDS.h +1 -0
@@ -21,6 +21,7 @@#define CONFIG_MP /* support multiple processors */ #define CONFIG_PHYS_64BIT #define CONFIG_ENABLE_36BIT_PHYS +#define CONFIG_FSL_CLK #ifdef CONFIG_PHYS_64BIT #define CONFIG_ADDR_MAP 1
include/configs/T102xRDB.h +1 -0
@@ -21,6 +21,7 @@#define CONFIG_MP /* support multiple processors */ #define CONFIG_PHYS_64BIT #define CONFIG_ENABLE_36BIT_PHYS +#define CONFIG_FSL_CLK #ifdef CONFIG_PHYS_64BIT #define CONFIG_ADDR_MAP 1
include/configs/T1040QDS.h +1 -0
@@ -30,6 +30,7 @@#define CONFIG_PHYS_64BIT #define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #ifdef CONFIG_RAMBOOT_PBL #define CONFIG_RAMBOOT_TEXT_BASE CONFIG_SYS_TEXT_BASE
include/configs/T104xRDB.h +1 -0
@@ -14,6 +14,7 @@#define CONFIG_PHYS_64BIT #define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #define CONFIG_E500 /* BOOKE e500 family */ #include <asm/config_mpc85xx.h>
include/configs/T208xQDS.h +1 -0
@@ -14,6 +14,7 @@#define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO #define CONFIG_ICS307_REFCLK_HZ 25000000/* ICS307 ref clk freq */ +#define CONFIG_FSL_CLK #define CONFIG_MMC #define CONFIG_USB_EHCI #if defined(CONFIG_PPC_T2080 )
include/configs/T208xRDB.h +1 -0
@@ -15,6 +15,7 @@#define CONFIG_DISPLAY_BOARDINFO #define CONFIG_T2080RDB #define CONFIG_ICS307_REFCLK_HZ 25000000/* ICS307 ref clk freq */ +#define CONFIG_FSL_CLK #define CONFIG_MMC #define CONFIG_USB_EHCI #define CONFIG_FSL_SATA_V2
include/configs/T4240QDS.h +1 -0
@@ -12,6 +12,7 @@#define CONFIG_T4240QDS #define CONFIG_PHYS_64BIT +#define CONFIG_FSL_CLK #define CONFIG_FSL_SATA_V2 #define CONFIG_PCIE4
include/configs/T4240RDB.h +1 -0
@@ -14,6 +14,7 @@#define CONFIG_PHYS_64BIT #define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #define CONFIG_FSL_SATA_V2 #define CONFIG_PCIE4
include/configs/UCP1020.h +1 -0
@@ -16,6 +16,7 @@#define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #define CONFIG_FSL_ELBC #define CONFIG_PCI
include/configs/colibri_vf.h +1 -0
@@ -18,6 +18,7 @@#define CONFIG_SYS_THUMB_BUILD #define CONFIG_USE_ARCH_MEMCPY #define CONFIG_USE_ARCH_MEMSET +#define CONFIG_FSL_CLK #define CONFIG_SYS_GENERIC_BOARD #define CONFIG_ARCH_MISC_INIT
include/configs/controlcenterd.h +1 -0
@@ -44,6 +44,7 @@#define CONFIG_P1022 #define CONFIG_CONTROLCENTERD #define CONFIG_MP /* support multiple processors */ +#define CONFIG_FSL_CLK #define CONFIG_SYS_GENERIC_BOARD
include/configs/corenet_ds.h +1 -0
@@ -12,6 +12,7 @@#define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #include "../board/freescale/common/ics307_clk.h"
include/configs/hrcon.h +1 -0
@@ -24,6 +24,7 @@#define CONFIG_SYS_GENERIC_BOARD +#define CONFIG_FSL_CLK #define CONFIG_BOARD_EARLY_INIT_F #define CONFIG_BOARD_EARLY_INIT_R #define CONFIG_LAST_STAGE_INIT
include/configs/ima3-mx53.h +1 -0
@@ -17,6 +17,7 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #define CONFIG_CMDLINE_TAG /* enable passing of ATAGs */ #define CONFIG_SETUP_MEMORY_TAGS
include/configs/ls1021aqds.h +1 -0
@@ -12,6 +12,7 @@#define CONFIG_ARMV7_PSCI #define CONFIG_SYS_GENERIC_BOARD +#define CONFIG_FSL_CLK #define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO
include/configs/ls1021atwr.h +1 -0
@@ -12,6 +12,7 @@#define CONFIG_ARMV7_PSCI #define CONFIG_SYS_GENERIC_BOARD +#define CONFIG_FSL_CLK #define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO
include/configs/ls2085aqds.h +1 -0
@@ -16,6 +16,7 @@ unsigned long get_board_sys_clk(void);unsigned long get_board_ddr_clk (void );#endif +#define CONFIG_FSL_CLK #define CONFIG_SYS_CLK_FREQ get_board_sys_clk()#define CONFIG_DDR_CLK_FREQ get_board_ddr_clk()#define COUNTER_FREQUENCY_REAL (CONFIG_SYS_CLK_FREQ/4)
include/configs/ls2085ardb.h +1 -0
@@ -18,6 +18,7 @@unsigned long get_board_sys_clk (void );#endif +#define CONFIG_FSL_CLK #define CONFIG_SYS_CLK_FREQ get_board_sys_clk()#define CONFIG_DDR_CLK_FREQ 133333333#define COUNTER_FREQUENCY_REAL (CONFIG_SYS_CLK_FREQ/4)
include/configs/m53evk.h +1 -0
@@ -18,6 +18,7 @@#define CONFIG_BOARD_EARLY_INIT_F #define CONFIG_REVISION_TAG #define CONFIG_SYS_NO_FLASH +#define CONFIG_FSL_CLK #define CONFIG_FIT
include/configs/mx25pdk.h +1 -0
@@ -15,6 +15,7 @@#define CONFIG_SYS_TEXT_BASE 0x81200000#define CONFIG_MXC_GPIO #define CONFIG_SYS_GENERIC_BOARD +#define CONFIG_FSL_CLK #define CONFIG_SYS_TIMER_RATE 32768#define CONFIG_SYS_TIMER_COUNTER \
include/configs/mx35pdk.h +1 -0
@@ -20,6 +20,7 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_SYS_GENERIC_BOARD +#define CONFIG_FSL_CLK /* Set TEXT at the beginning of the NOR flash */ #define CONFIG_SYS_TEXT_BASE 0xA0000000
include/configs/mx51_efikamx.h +1 -0
@@ -25,6 +25,7 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #define CONFIG_SYS_TEXT_BASE 0x97800000#define CONFIG_SYS_ICACHE_OFF
include/configs/mx51evk.h +1 -0
@@ -18,6 +18,7 @@#define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #define CONFIG_SYS_TEXT_BASE 0x97800000#include <asm/arch/imx-regs.h>
include/configs/mx53ard.h +1 -0
@@ -24,6 +24,7 @@#define CONFIG_REVISION_TAG #define CONFIG_SYS_GENERIC_BOARD +#define CONFIG_FSL_CLK /* Size of malloc() pool */ #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 2 * 1024 * 1024)
include/configs/mx53evk.h +1 -0
@@ -24,6 +24,7 @@#define CONFIG_REVISION_TAG #define CONFIG_SYS_GENERIC_BOARD +#define CONFIG_FSL_CLK #define CONFIG_OF_LIBFDT
include/configs/mx53loco.h +1 -0
@@ -23,6 +23,7 @@#define CONFIG_INITRD_TAG #define CONFIG_SYS_GENERIC_BOARD +#define CONFIG_FSL_CLK /* Size of malloc() pool */ #define CONFIG_SYS_MALLOC_LEN (10 * 1024 * 1024)
include/configs/mx53smd.h +1 -0
@@ -24,6 +24,7 @@#define CONFIG_REVISION_TAG #define CONFIG_SYS_GENERIC_BOARD +#define CONFIG_FSL_CLK /* Size of malloc() pool */ #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 2 * 1024 * 1024)
include/configs/mx6_common.h +1 -0
@@ -46,6 +46,7 @@#define CONFIG_DISPLAY_BOARDINFO #define CONFIG_DISPLAY_CPUINFO #define CONFIG_SYS_GENERIC_BOARD +#define CONFIG_FSL_CLK /* ATAGs */ #define CONFIG_CMDLINE_TAG
include/configs/p1_p2_rdb_pc.h +1 -0
@@ -12,6 +12,7 @@#define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #ifdef CONFIG_36BIT #define CONFIG_PHYS_64BIT
include/configs/p1_twr.h +1 -0
@@ -12,6 +12,7 @@#define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #if defined(CONFIG_TWR_P1025 )#define CONFIG_BOARDNAME "TWR-P1025"#define CONFIG_P1025
include/configs/usbarmory.h +1 -0
@@ -14,6 +14,7 @@#define CONFIG_MX53 #define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #define CONFIG_BOARD_EARLY_INIT_F #define CONFIG_OF_LIBFDT #define CONFIG_SYS_GENERIC_BOARD
include/configs/vf610twr.h +1 -0
@@ -16,6 +16,7 @@#define CONFIG_SYS_GENERIC_BOARD #define CONFIG_DISPLAY_CPUINFO #define CONFIG_DISPLAY_BOARDINFO +#define CONFIG_FSL_CLK #define CONFIG_MACH_TYPE 4146
include/configs/vision2.h +1 -0
@@ -14,6 +14,7 @@#define CONFIG_MX51 /* in a mx51 */ #define CONFIG_SYS_TEXT_BASE 0x97800000 +#define CONFIG_FSL_CLK #include <asm/arch/imx-regs.h>
include/configs/woodburn_common.h +1 -0
@@ -16,6 +16,7 @@/* High Level Configuration Options */ #define CONFIG_MX35 #define CONFIG_MX35_HCLK_FREQ 24000000 +#define CONFIG_FSL_CLK #define CONFIG_SYS_DCACHE_OFF #define CONFIG_SYS_CACHELINE_SIZE 32
Signature · 1 line
2.1.0.27.g96db324
PATCH v2 2/16 common/board_f.c: modify the macro to use get_clocks() more common
Quoted 41 lines · Gong Qianyu
get_clocks()should not be limited by ESDHC.Signed-off-by Gong Qianyu <[email protected]>--- common/board_f.c | 2 +- include/configs/BSC9132QDS.h | 1 + include/configs/MPC8308RDB.h | 1 + include/configs/MPC837XEMDS.h | 1 + include/configs/MPC837XERDB.h | 1 + include/configs/MPC8536DS.h | 1 + include/configs/MPC8569MDS.h | 1 + include/configs/P1010RDB.h | 1 + include/configs/P1022DS.h | 1 + include/configs/P2041RDB.h | 1 + include/configs/T102xQDS.h | 1 + include/configs/T102xRDB.h | 1 + include/configs/T1040QDS.h | 1 + include/configs/T104xRDB.h | 1 + include/configs/T208xQDS.h | 1 + include/configs/T208xRDB.h | 1 + include/configs/T4240QDS.h | 1 + include/configs/T4240RDB.h | 1 + include/configs/UCP1020.h | 1 + include/configs/colibri_vf.h | 1 + include/configs/controlcenterd.h | 1 + include/configs/corenet_ds.h | 1 + include/configs/hrcon.h | 1 + include/configs/ima3-mx53.h | 1 + include/configs/ls1021aqds.h | 1 + include/configs/ls1021atwr.h | 1 + include/configs/ls2085aqds.h | 1 + include/configs/ls2085ardb.h | 1 + include/configs/m53evk.h | 1 + include/configs/mx25pdk.h | 1 + include/configs/mx35pdk.h | 1 + include/configs/mx51_efikamx.h | 1 + include/configs/mx51evk.h | 1 + include/configs/mx53ard.h | 1 + include/configs/mx53evk.h | 1 + include/configs/mx53loco.h | 1 + include/configs/mx53smd.h | 1 +
Quoted 8 lines
include/configs/mx6_common.h | 1 + include/configs/p1_p2_rdb_pc.h | 1 + include/configs/p1_twr.h | 1 + include/configs/usbarmory.h | 1 + include/configs/vf610twr.h | 1 + include/configs/vision2.h | 1 + include/configs/woodburn_common.h | 1 + 44 files changed, 44 insertions(+), 1 deletion(-)
Can you take a closer look at the powerpc boards? I think most of them already calling get_clocks under this
defined(CONFIG_PPC) && !defined(CONFIG_8xx_CPUCLK_DEFAULT)
York
PATCH v2 2/16 common/board_f.c: modify the macro to use get_clocks() more common
Quoted 63 lines
-----Original Message-----
From: Sun York-R58495
Sent: Tuesday, September 22, 2015 1:27 AM
To: Gong Qianyu-B52263; u-boot at lists.denx.de
Cc: Hu Mingkai-B21284; Sun York-R58495; Hou Zhiqiang-B48286; Xie Shaohui- B21989; Song Wenbin-B53747; Wood Scott-B07421
Subject: Re: [Patch v2 02/16]common/board_f.c: modify the macro to useget_clocks()more commonQuoted 41 lines · Gong Qianyu
get_clocks()should not be limited by ESDHC.Signed-off-by Gong Qianyu <[email protected]>--- common/board_f.c | 2 +- include/configs/BSC9132QDS.h | 1 + include/configs/MPC8308RDB.h | 1 + include/configs/MPC837XEMDS.h | 1 + include/configs/MPC837XERDB.h | 1 + include/configs/MPC8536DS.h | 1 + include/configs/MPC8569MDS.h | 1 + include/configs/P1010RDB.h | 1 + include/configs/P1022DS.h | 1 + include/configs/P2041RDB.h | 1 + include/configs/T102xQDS.h | 1 + include/configs/T102xRDB.h | 1 + include/configs/T1040QDS.h | 1 + include/configs/T104xRDB.h | 1 + include/configs/T208xQDS.h | 1 + include/configs/T208xRDB.h | 1 + include/configs/T4240QDS.h | 1 + include/configs/T4240RDB.h | 1 + include/configs/UCP1020.h | 1 + include/configs/colibri_vf.h | 1 + include/configs/controlcenterd.h | 1 + include/configs/corenet_ds.h | 1 + include/configs/hrcon.h | 1 + include/configs/ima3-mx53.h | 1 + include/configs/ls1021aqds.h | 1 + include/configs/ls1021atwr.h | 1 + include/configs/ls2085aqds.h | 1 + include/configs/ls2085ardb.h | 1 + include/configs/m53evk.h | 1 + include/configs/mx25pdk.h | 1 + include/configs/mx35pdk.h | 1 + include/configs/mx51_efikamx.h | 1 + include/configs/mx51evk.h | 1 + include/configs/mx53ard.h | 1 + include/configs/mx53evk.h | 1 + include/configs/mx53loco.h | 1 + include/configs/mx53smd.h | 1 +Quoted 8 lines
include/configs/mx6_common.h | 1 + include/configs/p1_p2_rdb_pc.h | 1 + include/configs/p1_twr.h | 1 + include/configs/usbarmory.h | 1 + include/configs/vf610twr.h | 1 + include/configs/vision2.h | 1 + include/configs/woodburn_common.h | 1 + 44 files changed, 44 insertions(+), 1 deletion(-)
Quoted 6 lines
Can you take a closer look at the powerpc boards? I think most of them already calling
get_clocksunder this
defined(CONFIG_PPC)&& !defined(CONFIG_8xx_CPUCLK_DEFAULT)York
I'm also confused about this. They have called get_clocks() twice on PPC before even though they use CONFIG_FSL_ESDHC. I just made a replacement for it to keep the original meaning.
So where should get_clocks() be called correctly on PPC?
PATCH v2 2/16 common/board_f.c: modify the macro to use get_clocks() more common
Quoted 66 lines · On 09/21/2015 07:59 PM, Gong Qianyu-B52263 wrote:
Quoted 66 lines
-----Original Message-----
From: Sun York-R58495
Sent: Tuesday, September 22, 2015 1:27 AM
To: Gong Qianyu-B52263; u-boot at lists.denx.de
Cc: Hu Mingkai-B21284; Sun York-R58495; Hou Zhiqiang-B48286; Xie Shaohui- B21989; Song Wenbin-B53747; Wood Scott-B07421
Subject: Re: [Patch v2 02/16]common/board_f.c: modify the macro to useget_clocks()more commonQuoted 41 lines · Gong Qianyu
get_clocks()should not be limited by ESDHC.Signed-off-by Gong Qianyu <[email protected]>--- common/board_f.c | 2 +- include/configs/BSC9132QDS.h | 1 + include/configs/MPC8308RDB.h | 1 + include/configs/MPC837XEMDS.h | 1 + include/configs/MPC837XERDB.h | 1 + include/configs/MPC8536DS.h | 1 + include/configs/MPC8569MDS.h | 1 + include/configs/P1010RDB.h | 1 + include/configs/P1022DS.h | 1 + include/configs/P2041RDB.h | 1 + include/configs/T102xQDS.h | 1 + include/configs/T102xRDB.h | 1 + include/configs/T1040QDS.h | 1 + include/configs/T104xRDB.h | 1 + include/configs/T208xQDS.h | 1 + include/configs/T208xRDB.h | 1 + include/configs/T4240QDS.h | 1 + include/configs/T4240RDB.h | 1 + include/configs/UCP1020.h | 1 + include/configs/colibri_vf.h | 1 + include/configs/controlcenterd.h | 1 + include/configs/corenet_ds.h | 1 + include/configs/hrcon.h | 1 + include/configs/ima3-mx53.h | 1 + include/configs/ls1021aqds.h | 1 + include/configs/ls1021atwr.h | 1 + include/configs/ls2085aqds.h | 1 + include/configs/ls2085ardb.h | 1 + include/configs/m53evk.h | 1 + include/configs/mx25pdk.h | 1 + include/configs/mx35pdk.h | 1 + include/configs/mx51_efikamx.h | 1 + include/configs/mx51evk.h | 1 + include/configs/mx53ard.h | 1 + include/configs/mx53evk.h | 1 + include/configs/mx53loco.h | 1 + include/configs/mx53smd.h | 1 +Quoted 8 lines
include/configs/mx6_common.h | 1 + include/configs/p1_p2_rdb_pc.h | 1 + include/configs/p1_twr.h | 1 + include/configs/usbarmory.h | 1 + include/configs/vf610twr.h | 1 + include/configs/vision2.h | 1 + include/configs/woodburn_common.h | 1 + 44 files changed, 44 insertions(+), 1 deletion(-)Can you take a closer look at the powerpc boards? I think most of them already calling
get_clocksunder this
Quoted 8 lines
Quoted 3 lines
defined(CONFIG_PPC)&& !defined(CONFIG_8xx_CPUCLK_DEFAULT)York
I'm also confused about this. They have called
get_clocks()twice on PPC before even though they useCONFIG_FSL_ESDHC. I just made a replacement for it to keep the original meaning.
So where shouldget_clocks()be called correctly on PPC?
It doesn't hurt to run twice for ppc. The second call is needed for Freescale i.mx SoCs since it doesn't active the first one.
Please test ppc targets without the change in header file.
York
PATCH v2 2/16 common/board_f.c: modify the macro to use get_clocks() more common
Quoted 78 lines · York Sun
Quoted 67 lines · On 09/21/2015 07:59 PM, Gong Qianyu-B52263 wrote:
Quoted 67 lines
-----Original Message-----
From: Sun York-R58495
Sent: Tuesday, September 22, 2015 1:27 AM
To: Gong Qianyu-B52263; u-boot at lists.denx.de
Cc: Hu Mingkai-B21284; Sun York-R58495; Hou Zhiqiang-B48286; Xie Shaohui-
B21989; Song Wenbin-B53747; Wood Scott-B07421
Subject: Re: [Patch v2 02/16]common/board_f.c: modify the macro to useget_clocks()more commonQuoted 41 lines · Gong Qianyu
get_clocks()should not be limited by ESDHC.Signed-off-by Gong Qianyu <[email protected]>--- common/board_f.c | 2 +- include/configs/BSC9132QDS.h | 1 + include/configs/MPC8308RDB.h | 1 + include/configs/MPC837XEMDS.h | 1 + include/configs/MPC837XERDB.h | 1 + include/configs/MPC8536DS.h | 1 + include/configs/MPC8569MDS.h | 1 + include/configs/P1010RDB.h | 1 + include/configs/P1022DS.h | 1 + include/configs/P2041RDB.h | 1 + include/configs/T102xQDS.h | 1 + include/configs/T102xRDB.h | 1 + include/configs/T1040QDS.h | 1 + include/configs/T104xRDB.h | 1 + include/configs/T208xQDS.h | 1 + include/configs/T208xRDB.h | 1 + include/configs/T4240QDS.h | 1 + include/configs/T4240RDB.h | 1 + include/configs/UCP1020.h | 1 + include/configs/colibri_vf.h | 1 + include/configs/controlcenterd.h | 1 + include/configs/corenet_ds.h | 1 + include/configs/hrcon.h | 1 + include/configs/ima3-mx53.h | 1 + include/configs/ls1021aqds.h | 1 + include/configs/ls1021atwr.h | 1 + include/configs/ls2085aqds.h | 1 + include/configs/ls2085ardb.h | 1 + include/configs/m53evk.h | 1 + include/configs/mx25pdk.h | 1 + include/configs/mx35pdk.h | 1 + include/configs/mx51_efikamx.h | 1 + include/configs/mx51evk.h | 1 + include/configs/mx53ard.h | 1 + include/configs/mx53evk.h | 1 + include/configs/mx53loco.h | 1 + include/configs/mx53smd.h | 1 +Quoted 8 lines
include/configs/mx6_common.h | 1 + include/configs/p1_p2_rdb_pc.h | 1 + include/configs/p1_twr.h | 1 + include/configs/usbarmory.h | 1 + include/configs/vf610twr.h | 1 + include/configs/vision2.h | 1 + include/configs/woodburn_common.h | 1 + 44 files changed, 44 insertions(+), 1 deletion(-)Can you take a closer look at the powerpc boards? I think most of them already calling
get_clocksunder thisQuoted 9 lines
Quoted 3 lines
defined(CONFIG_PPC)&& !defined(CONFIG_8xx_CPUCLK_DEFAULT)York
I'm also confused about this. They have called
get_clocks()twice on PPC before even though they useCONFIG_FSL_ESDHC.
I just made a replacement for it to keep the original meaning. So where shouldget_clocks()be called correctly on PPC?
Quoted 5 lines
It doesn't hurt to run twice for ppc. The second call is needed for Freescale
i.mx SoCs since it doesn't active the first one.Please test ppc targets without the change in header file.
Is there a reason why i.mx needs to call it later? Is there a reason why PPC needs to call it sooner?
-Scott
PATCH v2 2/16 common/board_f.c: modify the macro to use get_clocks() more common
Quoted 79 lines · Scott Wood
Quoted 78 lines · York Sun
Quoted 76 lines · On 09/21/2015 07:59 PM, Gong Qianyu-B52263 wrote:
Quoted 64 lines
-----Original Message-----
From: Sun York-R58495
Sent: Tuesday, September 22, 2015 1:27 AM
To: Gong Qianyu-B52263; u-boot at lists.denx.de
Cc: Hu Mingkai-B21284; Sun York-R58495; Hou Zhiqiang-B48286; Xie Shaohui-
B21989; Song Wenbin-B53747; Wood Scott-B07421
Subject: Re: [Patch v2 02/16]common/board_f.c: modify the macro to useget_clocks()more commonQuoted 41 lines · Gong Qianyu
get_clocks()should not be limited by ESDHC.Signed-off-by Gong Qianyu <[email protected]>--- common/board_f.c | 2 +- include/configs/BSC9132QDS.h | 1 + include/configs/MPC8308RDB.h | 1 + include/configs/MPC837XEMDS.h | 1 + include/configs/MPC837XERDB.h | 1 + include/configs/MPC8536DS.h | 1 + include/configs/MPC8569MDS.h | 1 + include/configs/P1010RDB.h | 1 + include/configs/P1022DS.h | 1 + include/configs/P2041RDB.h | 1 + include/configs/T102xQDS.h | 1 + include/configs/T102xRDB.h | 1 + include/configs/T1040QDS.h | 1 + include/configs/T104xRDB.h | 1 + include/configs/T208xQDS.h | 1 + include/configs/T208xRDB.h | 1 + include/configs/T4240QDS.h | 1 + include/configs/T4240RDB.h | 1 + include/configs/UCP1020.h | 1 + include/configs/colibri_vf.h | 1 + include/configs/controlcenterd.h | 1 + include/configs/corenet_ds.h | 1 + include/configs/hrcon.h | 1 + include/configs/ima3-mx53.h | 1 + include/configs/ls1021aqds.h | 1 + include/configs/ls1021atwr.h | 1 + include/configs/ls2085aqds.h | 1 + include/configs/ls2085ardb.h | 1 + include/configs/m53evk.h | 1 + include/configs/mx25pdk.h | 1 + include/configs/mx35pdk.h | 1 + include/configs/mx51_efikamx.h | 1 + include/configs/mx51evk.h | 1 + include/configs/mx53ard.h | 1 + include/configs/mx53evk.h | 1 + include/configs/mx53loco.h | 1 + include/configs/mx53smd.h | 1 +Quoted 8 lines
include/configs/mx6_common.h | 1 + include/configs/p1_p2_rdb_pc.h | 1 + include/configs/p1_twr.h | 1 + include/configs/usbarmory.h | 1 + include/configs/vf610twr.h | 1 + include/configs/vision2.h | 1 + include/configs/woodburn_common.h | 1 + 44 files changed, 44 insertions(+), 1 deletion(-)Quoted 6 lines
Can you take a closer look at the powerpc boards? I think most of them already calling
get_clocksunder this
defined(CONFIG_PPC)&& !defined(CONFIG_8xx_CPUCLK_DEFAULT)York
I'm also confused about this. They have called
get_clocks()twice on PPC before even though they useCONFIG_FSL_ESDHC.
I just made a replacement for it to keep the original meaning. So where shouldget_clocks()be called correctly on PPC?
Quoted 8 lines
Quoted 5 lines
It doesn't hurt to run twice for ppc. The second call is needed for Freescale
i.mx SoCs since it doesn't active the first one.Please test ppc targets without the change in header file.
Is there a reason why i.mx needs to call it later? Is there a reason why PPC needs to call it sooner?
I don't believe so. I prefer to see get_clocks moved under arch_cpu_init (we need to make one for ppc though).
York
PATCH v2 2/16 common/board_f.c: modify the macro to use get_clocks() more common
In reply to Gong QianyuQuoted 55 lines · Gong Qianyu
get_clocks()should not be limited by ESDHC.Signed-off-by Gong Qianyu <[email protected]>--- common/board_f.c | 2 +- include/configs/BSC9132QDS.h | 1 + include/configs/MPC8308RDB.h | 1 + include/configs/MPC837XEMDS.h | 1 + include/configs/MPC837XERDB.h | 1 + include/configs/MPC8536DS.h | 1 + include/configs/MPC8569MDS.h | 1 + include/configs/P1010RDB.h | 1 + include/configs/P1022DS.h | 1 + include/configs/P2041RDB.h | 1 + include/configs/T102xQDS.h | 1 + include/configs/T102xRDB.h | 1 + include/configs/T1040QDS.h | 1 + include/configs/T104xRDB.h | 1 + include/configs/T208xQDS.h | 1 + include/configs/T208xRDB.h | 1 + include/configs/T4240QDS.h | 1 + include/configs/T4240RDB.h | 1 + include/configs/UCP1020.h | 1 + include/configs/colibri_vf.h | 1 + include/configs/controlcenterd.h | 1 + include/configs/corenet_ds.h | 1 + include/configs/hrcon.h | 1 + include/configs/ima3-mx53.h | 1 + include/configs/ls1021aqds.h | 1 + include/configs/ls1021atwr.h | 1 + include/configs/ls2085aqds.h | 1 + include/configs/ls2085ardb.h | 1 + include/configs/m53evk.h | 1 + include/configs/mx25pdk.h | 1 + include/configs/mx35pdk.h | 1 + include/configs/mx51_efikamx.h | 1 + include/configs/mx51evk.h | 1 + include/configs/mx53ard.h | 1 + include/configs/mx53evk.h | 1 + include/configs/mx53loco.h | 1 + include/configs/mx53smd.h | 1 + include/configs/mx6_common.h | 1 + include/configs/p1_p2_rdb_pc.h | 1 + include/configs/p1_twr.h | 1 + include/configs/usbarmory.h | 1 + include/configs/vf610twr.h | 1 + include/configs/vision2.h | 1 + include/configs/woodburn_common.h | 1 + 44 files changed, 44 insertions(+), 1 deletion(-)common/board_f.c +0
-0
common/board_f.c static init_fnc_t init_sequence_f[] = { · line 812
Quoted 8 lines
common/board_f.c +1
-1@@ -806,7 +806,7 @@ static init_fnc_t init_sequence_f[] = {#if defined(CONFIG_BOARD_POSTCLK_INIT ) board_postclk_init,#endif -#ifdef CONFIG_FSL_ESDHC +#ifdef CONFIG_FSL_CLK get_clocks,#endif #ifdef CONFIG_M68K
Symbol name is either too vague or too specific, and needs documentation. Maybe just make it unconditional, and add an empty weak function? Is there a good reason some configs call get_clocks earlier than others?
-Scott