cm-fx6 updates for Utilite
v2 cover cm-fx6 updates for Utilite
This series provides a fix necessary for early models of Utilite, a miniature desktop based on CM-FX6. It implements a dynamic modification to the device tree that is necessary for mmc boot.
Changes in V2:
- New patch: compulab: eeprom: propagate error value in read_mac_addr()
- s/BOARD_PRODUCT_NAME_*/PRODUCT_NAME_*
- rewrote cl_eeprom_get_product_name() to take a buffer parameter and added documentation
- #define USDHC3_PATH instead of const variable usdhc3_path
- Do not update device tree on eeprom read failures in a more explicit way
Nikita Kiryanov (4):
compulab: eeprom: select i2c bus when querying for board rev
compulab: eeprom: propagate error value in read_mac_addr()
compulab: eeprom: add support for obtaining product name
arm: mx6: cm-fx6: modify device tree for old revisions of utilite
board/compulab/cm_fx6/cm_fx6.c | 22 +++++++++++++++++++++- board/compulab/cm_t35/cm_t35.c | 2 +- board/compulab/common/eeprom.c | 40 ++++++++++++++++++++++++++++++++++++---- board/compulab/common/eeprom.h | 10 ++++++++-- 4 files changed, 66 insertions(+), 8 deletions(-)
Signature · 1 line
1.9.1
PATCH v2 1/4 compulab: eeprom: select i2c bus when querying for board rev
Add support for selecting which eeprom is queried for board revision by extending cl_eeprom_get_board_rev() to accept an i2c bus number.
---
Changes in V2:
- No changes
board/compulab/cm_fx6/cm_fx6.c | 2 +- board/compulab/cm_t35/cm_t35.c | 2 +- board/compulab/common/eeprom.c | 4 ++-- board/compulab/common/eeprom.h | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-)
board/compulab/cm_fx6/cm_fx6.c +1 -1
@@ -708,7 +708,7 @@ int dram_init(void)u32 get_board_rev (void ) { -return cl_eeprom_get_board_rev (); +return cl_eeprom_get_board_rev (CONFIG_SYS_I2C_EEPROM_BUS ); }static struct mxc_serial_platdata cm_fx6_mxc_serial_plat = {
board/compulab/cm_t35/cm_t35.c +1 -1
@@ -105,7 +105,7 @@ int board_init(void)*/ u32 get_board_rev (void ) { -return cl_eeprom_get_board_rev (); +return cl_eeprom_get_board_rev (CONFIG_SYS_I2C_EEPROM_BUS ); };int misc_init_r (void )
board/compulab/common/eeprom.c +2 -2
@@ -121,7 +121,7 @@ static u32 board_rev;* Routine: cl_eeprom_get_board_rev * Description: read system revision from eeprom */ -u32 cl_eeprom_get_board_rev (void ) +u32 cl_eeprom_get_board_rev (uint eeprom_bus) {char str[5 ];/* Legacy representation can contain at most 4 digits */ uint offset =BOARD_REV_OFFSET_LEGACY ;
@@ -129,7 +129,7 @@ u32 cl_eeprom_get_board_rev(void)if (board_rev)return board_rev; -if (cl_eeprom_setup (CONFIG_SYS_I2C_EEPROM_BUS )) +if (cl_eeprom_setup (eeprom_bus))return 0 ;if (cl_eeprom_layout !=LAYOUT_LEGACY )
board/compulab/common/eeprom.h +2 -2
@@ -12,13 +12,13 @@#ifdef CONFIG_SYS_I2C int cl_eeprom_read_mac_addr (uchar *buf,uint eeprom_bus); -u32 cl_eeprom_get_board_rev (void ); +u32 cl_eeprom_get_board_rev (uint eeprom_bus);#else static inline int cl_eeprom_read_mac_addr (uchar *buf,uint eeprom_bus) {return 1 ; } -static inline u32 cl_eeprom_get_board_rev (void ) +static inline u32 cl_eeprom_get_board_rev (uint eeprom_bus) {return 0 ; }
Signature · 1 line
1.9.1
PATCH v2 2/4 compulab: eeprom: propagate error value in read_mac_addr()
In reply to Nikita Kiryanovcl_eeprom_read_mac_addr() doesn't differentiate between success case and inability to access eeprom. Fix this by propagating the return value of cl_eeprom_setup().
---
Changes in V2:
- New patch
board/compulab/common/eeprom.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
board/compulab/common/eeprom.c +4 -2
@@ -105,9 +105,11 @@ void get_board_serial(struct tag_serialnr *serialnr)int cl_eeprom_read_mac_addr (uchar *buf,uint eeprom_bus) {uint offset; +int err; -if (cl_eeprom_setup (eeprom_bus)) -return 0 ; + err =cl_eeprom_setup (eeprom_bus); +if (err) +return err; offset = (cl_eeprom_layout !=LAYOUT_LEGACY ) ?MAC_ADDR_OFFSET :MAC_ADDR_OFFSET_LEGACY ;
Signature · 1 line
1.9.1
PATCH v2 2/4 compulab: eeprom: propagate error value in read_mac_addr()
Quoted 7 lines · Nikita Kiryanov
cl_eeprom_read_mac_addr()doesn't differentiate between success case and inability to access eeprom. Fix this by propagating the return value ofcl_eeprom_setup().Cc Stefano Babic <[email protected]>Cc Igor Grinberg <[email protected]>Signed-off-by Nikita Kiryanov <[email protected]>
Quoted 26 lines
---
Changes in V2:
- New patchboard/compulab/common/eeprom.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)board/compulab/common/eeprom.c +4
-2@@ -105,9 +105,11 @@ void get_board_serial(struct tag_serialnr *serialnr)int cl_eeprom_read_mac_addr (uchar *buf,uint eeprom_bus) {uint offset; +int err; -if (cl_eeprom_setup (eeprom_bus)) -return 0 ; + err =cl_eeprom_setup (eeprom_bus); +if (err) +return err; offset = (cl_eeprom_layout !=LAYOUT_LEGACY ) ?MAC_ADDR_OFFSET :MAC_ADDR_OFFSET_LEGACY ;
Signature · 2 lines
Regards, Igor.
PATCH v2 3/4 compulab: eeprom: add support for obtaining product name
In reply to Nikita KiryanovIntroduce cl_eeprom_get_product_name() for obtaining product name from the eeprom.
---
Changes in V2:
- s/BOARD_PRODUCT_NAME_*/PRODUCT_NAME_*
- Added documentation
- rewrote cl_eeprom_get_product_name() to take a buffer parameter
board/compulab/common/eeprom.c | 30 ++++++++++++++++++++++++++++++ board/compulab/common/eeprom.h | 6 ++++++ 2 files changed, 36 insertions(+)
board/compulab/common/eeprom.c +30 -0
@@ -9,6 +9,7 @@#include <common.h> #include <i2c.h> +#include "eeprom.h" #ifndef CONFIG_SYS_I2C_EEPROM_ADDR # define CONFIG_SYS_I2C_EEPROM_ADDR 0x50
@@ -25,6 +26,8 @@#define BOARD_REV_OFFSET 0#define BOARD_REV_OFFSET_LEGACY 6#define BOARD_REV_SIZE 2 +#define PRODUCT_NAME_OFFSET 128 +#define PRODUCT_NAME_SIZE 16#define MAC_ADDR_OFFSET 4#define MAC_ADDR_OFFSET_LEGACY 0
@@ -151,3 +154,30 @@ u32 cl_eeprom_get_board_rev(uint eeprom_bus)return board_rev; }; + +/* +* Routine: cl_eeprom_get_board_rev +* Description: read system revision from eeprom +* +* @buf: buffer to store the product name +* @eeprom_bus: i2c bus num of the eeprom +* +* @return: 0 on success, < 0 on failure +*/ +int cl_eeprom_get_product_name (uchar *buf,uint eeprom_bus) +{ +int err; + +if (buf ==NULL ) +return -EINVAL ; + + err =cl_eeprom_setup (eeprom_bus); +if (err) +return err; + + err =cl_eeprom_read (PRODUCT_NAME_OFFSET , buf,PRODUCT_NAME_SIZE ); +if (!err)/* Protect ourselves from invalid data (unterminated str) */ + buf[PRODUCT_NAME_SIZE -1 ] ='\0' ; + +return err; +}
board/compulab/common/eeprom.h +6 -0
@@ -9,10 +9,12 @@ #ifndef _EEPROM_ #define _EEPROM_ +#include <errno.h> #ifdef CONFIG_SYS_I2C int cl_eeprom_read_mac_addr(uchar *buf, uint eeprom_bus); u32 cl_eeprom_get_board_rev(uint eeprom_bus); +int cl_eeprom_get_product_name(uchar *buf, uint eeprom_bus); #else static inline int cl_eeprom_read_mac_addr(uchar *buf, uint eeprom_bus) {
@@ -22,6 +24,10 @@ static inline u32 cl_eeprom_get_board_rev(uint eeprom_bus) {return 0 ; } +static inline int cl_eeprom_get_product_name (uchar *buf,uint eeprom_bus) +{ +return -ENOSYS ; +}#endif #endif
Signature · 1 line
1.9.1
PATCH v2 3/4 compulab: eeprom: add support for obtaining product name
Hi Nikita,
Quoted 29 lines · Nikita Kiryanov
Introduce
cl_eeprom_get_product_name()for obtaining product name from the eeprom.Cc Stefano Babic <[email protected]>Cc Igor Grinberg <[email protected]>Signed-off-by Nikita Kiryanov <[email protected]>---
Changes in V2:
- s/BOARD_PRODUCT_NAME_*/PRODUCT_NAME_*
- Added documentation
- rewrotecl_eeprom_get_product_name()to take a buffer parameterboard/compulab/common/eeprom.c | 30 ++++++++++++++++++++++++++++++ board/compulab/common/eeprom.h | 6 ++++++ 2 files changed, 36 insertions(+)board/compulab/common/eeprom.c +1
-0@@ -9,6 +9,7 @@#include <common.h> #include <i2c.h> +#include "eeprom.h" #ifndef CONFIG_SYS_I2C_EEPROM_ADDR # define CONFIG_SYS_I2C_EEPROM_ADDR 0x50
board/compulab/common/eeprom.c line 32
Quoted 7 lines
board/compulab/common/eeprom.c +2
-0@@ -25,6 +26,8 @@#define BOARD_REV_OFFSET 0#define BOARD_REV_OFFSET_LEGACY 6#define BOARD_REV_SIZE 2 +#define PRODUCT_NAME_OFFSET 128 +#define PRODUCT_NAME_SIZE 16#define MAC_ADDR_OFFSET 4#define MAC_ADDR_OFFSET_LEGACY 0
It seems that the time has come to move the above constants out of this file into the eeprom.h, so they can be used by users of this "lib". Don't you think?
board/compulab/common/eeprom.c u32 cl_eeprom_get_board_rev(uint eeprom_bus) · line 160
Quoted 9 lines
board/compulab/common/eeprom.c +4
-0@@ -151,3 +154,30 @@ u32 cl_eeprom_get_board_rev(uint eeprom_bus)return board_rev; }; + +/* +* Routine: cl_eeprom_get_board_rev +* Description: read system revision from eeprom
Seems like you have a successful copy/paste problem ;-)
board/compulab/common/eeprom.c u32 cl_eeprom_get_board_rev(uint eeprom_bus) · line 172
Quoted 12 lines
board/compulab/common/eeprom.c +12
-0+* +* @buf: buffer to store the product name +* @eeprom_bus: i2c bus num of the eeprom +* +* @return: 0 on success, < 0 on failure +*/ +int cl_eeprom_get_product_name (uchar *buf,uint eeprom_bus) +{ +int err; + +if (buf ==NULL ) +return -EINVAL ;
I think that this check is not really necessary. If someone passes NULL instead of buf - let it crash, no?
board/compulab/common/eeprom.c u32 cl_eeprom_get_board_rev(uint eeprom_bus) · line 179
Quoted 7 lines
board/compulab/common/eeprom.c +7
-0+ + err =cl_eeprom_setup (eeprom_bus); +if (err) +return err; + + err =cl_eeprom_read (PRODUCT_NAME_OFFSET , buf,PRODUCT_NAME_SIZE ); +if (!err)/* Protect ourselves from invalid data (unterminated str) */
Why do you need the above check?
I think, you can just write '\0' anyway, no?
Quoted 33 lines
board/compulab/common/eeprom.c +4
-0+ buf[PRODUCT_NAME_SIZE -1 ] ='\0' ; + +return err; +}board/compulab/common/eeprom.h +6
-0@@ -9,10 +9,12 @@ #ifndef _EEPROM_ #define _EEPROM_ +#include <errno.h> #ifdef CONFIG_SYS_I2C int cl_eeprom_read_mac_addr(uchar *buf, uint eeprom_bus); u32 cl_eeprom_get_board_rev(uint eeprom_bus); +int cl_eeprom_get_product_name(uchar *buf, uint eeprom_bus); #else static inline int cl_eeprom_read_mac_addr(uchar *buf, uint eeprom_bus) {@@ -22,6 +24,10 @@ static inline u32 cl_eeprom_get_board_rev(uint eeprom_bus) {return 0 ; } +static inline int cl_eeprom_get_product_name (uchar *buf,uint eeprom_bus) +{ +return -ENOSYS ; +}#endif #endif
Signature · 2 lines
Regards, Igor.
PATCH v2 4/4 arm: mx6: cm-fx6: modify device tree for old revisions of utilite
In reply to Nikita KiryanovOld revisions of Utilite (a miniature PC based on cm-fx6) do not have a card detect for mmc, and thus the kernel needs to be told that there's a persistent storage on usdhc3 to force it to probe the mmc card.
Check the baseboard revision and modify the device tree accordingly if needed.
---
Changes in V2:
- #define USDHC3_PATH instead of const variable usdhc3_path
- Do not update device tree on eeprom read failures in a more explicit way
board/compulab/cm_fx6/cm_fx6.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
board/compulab/cm_fx6/cm_fx6.c +20 -0
@@ -580,9 +580,14 @@ int cm_fx6_setup_ecspi(void) { return 0; }#endif #ifdef CONFIG_OF_BOARD_SETUP +#define USDHC3_PATH "/soc/aips-bus at 02100000/usdhc at 02198000/"int ft_board_setup (void *blob,bd_t *bd) { +u32 baseboard_rev; +int nodeoffset;uint8_t enetaddr[6 ]; +char baseboard_name[16 ]; +int err;/* MAC addr */ if (eth_getenv_enetaddr ("ethaddr" , enetaddr)) {
@@ -596,6 +601,21 @@ int ft_board_setup(void *blob, bd_t *bd) enetaddr, 6, 1); } + baseboard_rev =cl_eeprom_get_board_rev (0 ); + err =cl_eeprom_get_product_name ((uchar *)baseboard_name,0 ); +if (err || baseboard_rev ==0 ) +return 0 ;/* Assume not an early revision SB-FX6m baseboard */ + +if (!strncmp ("SB-FX6m" , baseboard_name,7 ) && baseboard_rev <=120 ) { +fdt_shrink_to_minimum (blob);/* Make room for new properties */ + nodeoffset =fdt_path_offset (blob,USDHC3_PATH ); +fdt_delprop (blob, nodeoffset,"cd-gpios" ); +fdt_find_and_setprop (blob,USDHC3_PATH ,"non-removable" , +NULL ,0 ,1 ); +fdt_find_and_setprop (blob,USDHC3_PATH ,"keep-power-in-suspend" , +NULL ,0 ,1 ); + } +return 0 ; }#endif
Signature · 1 line
1.9.1
PATCH v2 4/4 arm: mx6: cm-fx6: modify device tree for old revisions of utilite
Quoted 25 lines · Nikita Kiryanov
Old revisions of Utilite (a miniature PC based on cm-fx6) do not have a card detect for mmc, and thus the kernel needs to be told that there's a persistent storage on usdhc3 to force it to probe the mmc card.
Check the baseboard revision and modify the device tree accordingly if needed.
Cc Stefano Babic <[email protected]>Cc Igor Grinberg <[email protected]>Signed-off-by Nikita Kiryanov <[email protected]>---
Changes in V2:
- #defineUSDHC3_PATHinstead of const variableusdhc3_path
- Do not update device tree on eeprom read failures in a more explicit wayboard/compulab/cm_fx6/cm_fx6.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)board/compulab/cm_fx6/cm_fx6.c +0
-0
board/compulab/cm_fx6/cm_fx6.c int cm_fx6_setup_ecspi(void) { return 0; } · line 589
Quoted 10 lines
board/compulab/cm_fx6/cm_fx6.c +4
-0@@ -580,9 +580,14 @@ int cm_fx6_setup_ecspi(void) { return 0; }#endif #ifdef CONFIG_OF_BOARD_SETUP +#define USDHC3_PATH "/soc/aips-bus at 02100000/usdhc at 02198000/"int ft_board_setup (void *blob,bd_t *bd) { +u32 baseboard_rev; +int nodeoffset;uint8_t enetaddr[6 ]; +char baseboard_name[16 ];
That would probably have the actual size (macro).
board/compulab/cm_fx6/cm_fx6.c int ft_board_setup(void *blob, bd_t *bd) · line 605
Quoted 10 lines
board/compulab/cm_fx6/cm_fx6.c +3
-0+int err;/* MAC addr */ if (eth_getenv_enetaddr ("ethaddr" , enetaddr)) {@@ -596,6 +601,21 @@ int ft_board_setup(void *blob, bd_t *bd) enetaddr, 6, 1); } + baseboard_rev =cl_eeprom_get_board_rev (0 ); + err =cl_eeprom_get_product_name ((uchar *)baseboard_name,0 );
I would replace the 0 with a define explaining what that is.
Quoted 17 lines
board/compulab/cm_fx6/cm_fx6.c +13
-0+if (err || baseboard_rev ==0 ) +return 0 ;/* Assume not an early revision SB-FX6m baseboard */ + +if (!strncmp ("SB-FX6m" , baseboard_name,7 ) && baseboard_rev <=120 ) { +fdt_shrink_to_minimum (blob);/* Make room for new properties */ + nodeoffset =fdt_path_offset (blob,USDHC3_PATH ); +fdt_delprop (blob, nodeoffset,"cd-gpios" ); +fdt_find_and_setprop (blob,USDHC3_PATH ,"non-removable" , +NULL ,0 ,1 ); +fdt_find_and_setprop (blob,USDHC3_PATH ,"keep-power-in-suspend" , +NULL ,0 ,1 ); + } + return 0; }#endif
Signature · 2 lines
Regards, Igor.
v2 cover cm-fx6 updates for Utilite
In reply to Nikita KiryanovQuoted 22 lines · Nikita Kiryanov
This series provides a fix necessary for early models of Utilite, a miniature desktop based on CM-FX6. It implements a dynamic modification to the device tree that is necessary for mmc boot.
Cc Stefano Babic <[email protected]>Cc Igor Grinberg <[email protected]>Changes in V2:
- New patch: compulab: eeprom: propagate error value inread_mac_addr()
- s/BOARD_PRODUCT_NAME_*/PRODUCT_NAME_*
- rewrotecl_eeprom_get_product_name()to take a buffer parameter and added documentation
- #defineUSDHC3_PATHinstead of const variableusdhc3_path
- Do not update device tree on eeprom read failures in a more explicit wayNikita Kiryanov (4):
compulab: eeprom: select i2c bus when querying for board rev
compulab: eeprom: propagate error value inread_mac_addr()
compulab: eeprom: add support for obtaining product name
arm: mx6: cm-fx6: modify device tree for old revisions of utilite
Quoted 6 lines
board/compulab/cm_fx6/cm_fx6.c | 22 +++++++++++++++++++++- board/compulab/cm_t35/cm_t35.c | 2 +- board/compulab/common/eeprom.c | 40 ++++++++++++++++++++++++++++++++++++---- board/compulab/common/eeprom.h | 10 ++++++++-- 4 files changed, 66 insertions(+), 8 deletions(-)
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
v2 cover cm-fx6 updates for Utilite
Hi Stefano,
Quoted 33 lines · Stefano Babic
Quoted 22 lines · Nikita Kiryanov
This series provides a fix necessary for early models of Utilite, a miniature desktop based on CM-FX6. It implements a dynamic modification to the device tree that is necessary for mmc boot.
Cc Stefano Babic <[email protected]>Cc Igor Grinberg <[email protected]>Changes in V2:
- New patch: compulab: eeprom: propagate error value inread_mac_addr()
- s/BOARD_PRODUCT_NAME_*/PRODUCT_NAME_*
- rewrotecl_eeprom_get_product_name()to take a buffer parameter and added documentation
- #defineUSDHC3_PATHinstead of const variableusdhc3_path
- Do not update device tree on eeprom read failures in a more explicit wayNikita Kiryanov (4):
compulab: eeprom: select i2c bus when querying for board rev
compulab: eeprom: propagate error value inread_mac_addr()
compulab: eeprom: add support for obtaining product name
arm: mx6: cm-fx6: modify device tree for old revisions of utiliteQuoted 6 lines
board/compulab/cm_fx6/cm_fx6.c | 22 +++++++++++++++++++++- board/compulab/cm_t35/cm_t35.c | 2 +- board/compulab/common/eeprom.c | 40 ++++++++++++++++++++++++++++++++++++---- board/compulab/common/eeprom.h | 10 ++++++++-- 4 files changed, 66 insertions(+), 8 deletions(-)
Quoted 1 line
Applied to u-boot-imx, thanks !
IMO, this was a bit early...
We haven't received any answer from Nikita yet. I tend to think that he is preparing a newer version. Nikita?
Signature · 2 lines
Regards, Igor.
v2 cover cm-fx6 updates for Utilite
Quoted 36 lines · Igor Grinberg
Hi Stefano,
Quoted 33 lines · Stefano Babic
Quoted 28 lines · Nikita Kiryanov
This series provides a fix necessary for early models of Utilite, a miniature desktop based on CM-FX6. It implements a dynamic modification to the device tree that is necessary for mmc boot.
Cc Stefano Babic <[email protected]>Cc Igor Grinberg <[email protected]>Changes in V2:
- New patch: compulab: eeprom: propagate error value inread_mac_addr()
- s/BOARD_PRODUCT_NAME_*/PRODUCT_NAME_*
- rewrotecl_eeprom_get_product_name()to take a buffer parameter and added documentation
- #defineUSDHC3_PATHinstead of const variableusdhc3_path
- Do not update device tree on eeprom read failures in a more explicit wayNikita Kiryanov (4):
compulab: eeprom: select i2c bus when querying for board rev
compulab: eeprom: propagate error value inread_mac_addr()
compulab: eeprom: add support for obtaining product name
arm: mx6: cm-fx6: modify device tree for old revisions of utiliteboard/compulab/cm_fx6/cm_fx6.c | 22 +++++++++++++++++++++- board/compulab/cm_t35/cm_t35.c | 2 +- board/compulab/common/eeprom.c | 40 ++++++++++++++++++++++++++++++++++++---- board/compulab/common/eeprom.h | 10 ++++++++-- 4 files changed, 66 insertions(+), 8 deletions(-)
Quoted 6 lines
Quoted 1 line
Applied to u-boot-imx, thanks !
IMO, this was a bit early...
We haven't received any answer from Nikita yet. I tend to think that he is preparing a newer version. Nikita?
Yes, I was planning to submit a new version. Since V2 is already in mainline though, I guess I'll submit a followup patch.
Quoted 5 lines
Signature · 3 lines
-- Regards, Igor.
v2 cover cm-fx6 updates for Utilite
Quoted 39 lines · Nikita Kiryanov
Quoted 38 lines · Igor Grinberg
Hi Stefano,
Quoted 34 lines · Stefano Babic
Quoted 22 lines · Nikita Kiryanov
This series provides a fix necessary for early models of Utilite, a miniature desktop based on CM-FX6. It implements a dynamic modification to the device tree that is necessary for mmc boot.
Cc Stefano Babic <[email protected]>Cc Igor Grinberg <[email protected]>Changes in V2:
- New patch: compulab: eeprom: propagate error value inread_mac_addr()
- s/BOARD_PRODUCT_NAME_*/PRODUCT_NAME_*
- rewrotecl_eeprom_get_product_name()to take a buffer parameter and added documentation
- #defineUSDHC3_PATHinstead of const variableusdhc3_path
- Do not update device tree on eeprom read failures in a more explicit wayNikita Kiryanov (4):
compulab: eeprom: select i2c bus when querying for board rev
compulab: eeprom: propagate error value inread_mac_addr()
compulab: eeprom: add support for obtaining product name
arm: mx6: cm-fx6: modify device tree for old revisions of utiliteQuoted 6 lines
board/compulab/cm_fx6/cm_fx6.c | 22 +++++++++++++++++++++- board/compulab/cm_t35/cm_t35.c | 2 +- board/compulab/common/eeprom.c | 40 ++++++++++++++++++++++++++++++++++++---- board/compulab/common/eeprom.h | 10 ++++++++-- 4 files changed, 66 insertions(+), 8 deletions(-)Applied to u-boot-imx, thanks !
Quoted 7 lines
Quoted 4 lines
IMO, this was a bit early...
We haven't received any answer from Nikita yet. I tend to think that he is preparing a newer version. Nikita?Yes, I was planning to submit a new version. Since V2 is already in mainline though, I guess I'll submit a followup patch.
Ok, thanks - I missed that a new version was in preparation, sorry for that.
Regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================