Skip to contentSkip to conversation

arm: wire up userfaultfd and membarrier syscalls

PATCH In review Andre Przywara 2 participants 4 messages Sep 21, 2015 – Sep 22, 2015 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: wire up userfaultfd and membarrier syscalls

Add the syscall numbers to the ARM syscall table. Both have been briefly tested using the provided selftests from the tools directory.

---
Hi Russell,

I saw that Thierry sent something similar beginning of August already (which is now outdated), is there any issue with enabling syscalls?

Cheers,
Andre.

 arch/arm/include/asm/unistd.h      | 2 +-
 arch/arm/include/uapi/asm/unistd.h | 2 ++
 arch/arm/kernel/calls.S            | 2 ++
 3 files changed, 5 insertions(+), 1 deletion(-)
arch/arm/include/asm/unistd.h +1 -1
index 32640c4..7cba573 100644
@@ -19,7 +19,7 @@
  * This may need to be greater than __NR_last_syscall+1 in order to
  * account for the padding in the syscall table
  */
-#define __NR_syscalls  (388)
+#define __NR_syscalls  (392)
 
 /*
  * *NOTE*: This is a ghost syscall private to the kernel.  Only the
arch/arm/include/uapi/asm/unistd.h +2 -0
index 0c3f5a0..7a2a32a 100644
@@ -414,6 +414,8 @@
 #define __NR_memfd_create		(__NR_SYSCALL_BASE+385)
 #define __NR_bpf			(__NR_SYSCALL_BASE+386)
 #define __NR_execveat			(__NR_SYSCALL_BASE+387)
+#define __NR_userfaultfd		(__NR_SYSCALL_BASE+388)
+#define __NR_membarrier			(__NR_SYSCALL_BASE+389)
 
 /*
  * The following SWIs are ARM private.
arch/arm/kernel/calls.S +2 -0
index 05745eb..fde6c88 100644
@@ -397,6 +397,8 @@
 /* 385 */	CALL(sys_memfd_create)
 		CALL(sys_bpf)
 		CALL(sys_execveat)
+		CALL(sys_userfaultfd)
+		CALL(sys_membarrier)
 #ifndef syscalls_counted
 .equ syscalls_padding, ((NR_syscalls + 3) & ~3) - NR_syscalls
 #define syscalls_counted
Signature · 1 line
2.5.1
#1 lore raw
Quoted 10 lines · Andre Przywara

Add the syscall numbers to the ARM syscall table. Both have been briefly tested using the provided selftests from the tools directory.

---
Hi Russell,

I saw that Thierry sent something similar beginning of August already (which is now outdated), is there any issue with enabling syscalls?

The only issue there is is that this was mentioned last week, and I replied about it last week.

I already have a patch pending for it, but I've been unable to merge it into mainline as my tree became somewhat messy due to the fixes missing -rc1 - which meant that my fixes branch was not recent enough to take that patch. Now that those fixes are in, I can now start sorting my tree out, as I'd normally do after -rc1.

Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
#2 lore raw

Hi Russell,

Quoted 9 lines · Russell King - ARM Linux
Quoted 8 lines · Andre Przywara

Add the syscall numbers to the ARM syscall table. Both have been briefly tested using the provided selftests from the tools directory.

---
Hi Russell,

Quoted 5 lines
Quoted 2 lines

I saw that Thierry sent something similar beginning of August already (which is now outdated), is there any issue with enabling syscalls?

The only issue there is is that this was mentioned last week, and I replied about it last week.

I missed that because I only looked in the ARM kernel ML, sorry about that.

Quoted 5 lines

I already have a patch pending for it, but I've been unable to merge it into mainline as my tree became somewhat messy due to the fixes missing -rc1 - which meant that my fixes branch was not recent enough to take that patch. Now that those fixes are in, I can now start sorting my tree out, as I'd normally do after -rc1.

Fair enough and sorry for the noise.

Cheers,
Andre

#3 lore raw
Quoted 20 lines · Andre Przywara

Hi Russell,

Quoted 9 lines · Russell King - ARM Linux
Quoted 8 lines · Andre Przywara

Add the syscall numbers to the ARM syscall table. Both have been briefly tested using the provided selftests from the tools directory.

---
Hi Russell,

Quoted 5 lines
Quoted 2 lines

I saw that Thierry sent something similar beginning of August already (which is now outdated), is there any issue with enabling syscalls?

The only issue there is is that this was mentioned last week, and I replied about it last week.

I missed that because I only looked in the ARM kernel ML, sorry about that.

Quoted 7 lines
Quoted 5 lines

I already have a patch pending for it, but I've been unable to merge it into mainline as my tree became somewhat messy due to the fixes missing -rc1 - which meant that my fixes branch was not recent enough to take that patch. Now that those fixes are in, I can now start sorting my tree out, as I'd normally do after -rc1.

Fair enough and sorry for the noise.

It should be in tonights linux-next.

Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.