Skip to contentSkip to conversation

ARM: dts: exynos5420: fix wrong clock binding for sysmmu_fimd1_1

PATCH Superseded Joonyoung Shim 2 participants 2 messages Sep 23, 2015

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: exynos5420: fix wrong clock binding for sysmmu_fimd1_1

The sysmmu_fimd1_1 should bind the clock CLK_SMMU_FIMD1M1, not the clock CLK_SMMU_FIMD1M0. CLK_SMMU_FIMD1M0 is a clock for the sysmmu_fimd1_0.

---
 arch/arm/boot/dts/exynos5420.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos5420.dtsi +1 -1
index df9aee9..1b3d6c7 100644
@@ -1117,7 +1117,7 @@
 		interrupt-parent = <&combiner>;
 		interrupts = <3 0>;
 		clock-names = "sysmmu", "master";
-		clocks = <&clock CLK_SMMU_FIMD1M0>, <&clock CLK_FIMD1>;
+		clocks = <&clock CLK_SMMU_FIMD1M1>, <&clock CLK_FIMD1>;
 		power-domains = <&disp_pd>;
 		#iommu-cells = <0>;
 	};
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: dts: exynos5420: fix wrong clock binding for sysmmu_fimd1_1

Hello Joonyoung,

Quoted 3 lines · Joonyoung Shim

The sysmmu_fimd1_1 should bind the clock CLK_SMMU_FIMD1M1, not the clock CLK_SMMU_FIMD1M0. CLK_SMMU_FIMD1M0 is a clock for the sysmmu_fimd1_0.

Can you please mention in the commit message if this patch is solving an issue on a given machine or if it is just for the sake of correctness.

Git blame shows that this was added by commit b70045167815 ("ARM: dts: add sysmmu nodes for exynos5420") so please add a Fixes: tag.

Quoted 3 lines

---

Patch looks good to me.

Best regards,

Signature · 3 lines
Javier Martinez Canillas
Open Source Group
Samsung Research America