Skip to contentSkip to conversation

ARM: dts: exynos5420: fix wrong clock binding for sysmmu_fimd1_1

PATCH New Joonyoung Shim 3 participants 3 messages Sep 23, 2015 – Sep 29, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: dts: exynos5420: fix wrong clock binding for sysmmu_fimd1_1

The sysmmu_fimd1_1 should bind the clock CLK_SMMU_FIMD1M1, not the clock CLK_SMMU_FIMD1M0. CLK_SMMU_FIMD1M0 is a clock for the sysmmu_fimd1_0.

This wrong clock binding causes the problem that is blocked in iommu_map function when IOMMU is enabled and exynos-drm driver tries to allocate buffer via DMA mapping API on Odroid-XU3 board.

Fixes b70045167815 ("ARM: dts: add sysmmu nodes for exynos5420")
Cc <[email protected]> # v4.2

---
Changes for v2:
- Update the commit message
- Add Fixes: and Reviewed-by: tags

 arch/arm/boot/dts/exynos5420.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos5420.dtsi +1 -1
index df9aee9..1b3d6c7 100644
@@ -1117,7 +1117,7 @@
 		interrupt-parent = <&combiner>;
 		interrupts = <3 0>;
 		clock-names = "sysmmu", "master";
-		clocks = <&clock CLK_SMMU_FIMD1M0>, <&clock CLK_FIMD1>;
+		clocks = <&clock CLK_SMMU_FIMD1M1>, <&clock CLK_FIMD1>;
 		power-domains = <&disp_pd>;
 		#iommu-cells = <0>;
 	};
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 ARM: dts: exynos5420: fix wrong clock binding for sysmmu_fimd1_1

Hello,

Quoted 11 lines · Joonyoung Shim

The sysmmu_fimd1_1 should bind the clock CLK_SMMU_FIMD1M1, not the clock CLK_SMMU_FIMD1M0. CLK_SMMU_FIMD1M0 is a clock for the sysmmu_fimd1_0.

This wrong clock binding causes the problem that is blocked in iommu_map function when IOMMU is enabled and exynos-drm driver tries to allocate buffer via DMA mapping API on Odroid-XU3 board.

Fixes b70045167815 ("ARM: dts: add sysmmu nodes for exynos5420")
Cc <[email protected]> # v4.2
Quoted 13 lines

---
Changes for v2:
- Update the commit message
- Add Fixes: and Reviewed-by: tags

  arch/arm/boot/dts/exynos5420.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos5420.dtsi +0 -0
index df9aee9..1b3d6c7 100644

arch/arm/boot/dts/exynos5420.dtsi line 1123

Quoted 8 lines
arch/arm/boot/dts/exynos5420.dtsi +1 -1
@@ -1117,7 +1117,7 @@
  		interrupt-parent = <&combiner>;
  		interrupts = <3 0>;
  		clock-names = "sysmmu", "master";
-		clocks = <&clock CLK_SMMU_FIMD1M0>, <&clock CLK_FIMD1>;
+		clocks = <&clock CLK_SMMU_FIMD1M1>, <&clock CLK_FIMD1>;
  		power-domains = <&disp_pd>;
  		#iommu-cells = <0>;
  	};

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland
#2 lore raw

PATCH v2 1/1 ARM: dts: exynos5420: fix wrong clock binding for sysmmu_fimd1_1

In reply to Joonyoung Shim

2015-09-23 16:41 GMT+09:00 Joonyoung Shim <[email protected]>:

Quoted 12 lines

The sysmmu_fimd1_1 should bind the clock CLK_SMMU_FIMD1M1, not the clock CLK_SMMU_FIMD1M0. CLK_SMMU_FIMD1M0 is a clock for the sysmmu_fimd1_0.

This wrong clock binding causes the problem that is blocked in iommu_map function when IOMMU is enabled and exynos-drm driver tries to allocate buffer via DMA mapping API on Odroid-XU3 board.

Fixes b70045167815 ("ARM: dts: add sysmmu nodes for exynos5420")
Cc <[email protected]> # v4.2
Quoted 7 lines

---
Changes for v2:
- Update the commit message
- Add Fixes: and Reviewed-by: tags

 arch/arm/boot/dts/exynos5420.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Best regards,
Krzysztof