openvpn: add option for --enable-password-save
PATCH 1/1 openvpn: add option for --enable-password-save
Added configuration option BR2_PACKAGE_OPENVPN_PWSAVE that adds --enable-password-save to OPENVPN_CONF_OPTS if selected.
--- package/openvpn/Config.in | 5 +++++ package/openvpn/openvpn.mk | 6 ++++++ 2 files changed, 11 insertions(+)
package/openvpn/Config.in +5 -0
@@ -27,6 +27,11 @@ config BR2_PACKAGE_OPENVPN_SMALL You loose eurephia, debugging info, help messages and more. It saves around 100 KiB in binary file size. +config BR2_PACKAGE_OPENVPN_PWSAVE + bool "Allow passwords in files" + help + Allow --askpass and --auth-user-pass passwords to be read from a file. + choice prompt "Crypto backend" default BR2_PACKAGE_OPENVPN_CRYPTO_OPENSSL
package/openvpn/openvpn.mk +6 -0
@@ -41,6 +41,12 @@ else OPENVPN_CONF_OPTS += --disable-lzo endif +ifeq ($(BR2_PACKAGE_OPENVPN_PWSAVE),y) +OPENVPN_CONF_OPTS += --enable-password-save +else +OPENVPN_CONF_OPTS += --disable-password-save +endif + ifeq ($(BR2_PACKAGE_OPENVPN_CRYPTO_OPENSSL),y) OPENVPN_CONF_OPTS += --with-crypto-library=openssl OPENVPN_DEPENDENCIES += openssl
Signature · 1 line
2.1.4
PATCH 1/1 openvpn: add option for --enable-password-save
Dear Andreas Wetzel,
just a minor problems that (I think) will not prevent your patch to be applied by a maintaner:
The subject prefix of your patch should be "PATCH v2", as is the second version of your patch. This is explained in the Buildroot manual:
http://buildroot.org/downloads/manual/manual.html#submitting-patches
Subsection "21.5.2. Patch revision changelog".
Quoted 5 lines · Andreas Wetzel
Added configuration option
BR2_PACKAGE_OPENVPN_PWSAVEthat adds --enable-password-save toOPENVPN_CONF_OPTSif selected.Signed-off-by Andreas Wetzel <[email protected]>---
You should have added a changelog here explaining the changes between v1 and v2, as explained in the Buildroot manual, in the same subsection I mentioned above.
Quoted 9 lines
package/openvpn/Config.in | 5 +++++ package/openvpn/openvpn.mk | 6 ++++++ 2 files changed, 11 insertions(+)package/openvpn/Config.in +0
-0
package/openvpn/Config.in config BR2_PACKAGE_OPENVPN_SMALL · line 33
Quoted 7 lines
package/openvpn/Config.in +4
-0@@ -27,6 +27,11 @@ config BR2_PACKAGE_OPENVPN_SMALL You loose eurephia, debugging info, help messages and more. It saves around 100 KiB in binary file size. +config BR2_PACKAGE_OPENVPN_PWSAVE + bool "Allow passwords in files" + help + Allow --askpass and --auth-user-pass passwords to be read from a file.
As explained in the Buildroot manual, the help text should be wrapped at 72 characters, so the "file." should have been in the next line. I think a maintainer will not mind to fix it for you.
http://buildroot.org/downloads/manual/manual.html#writing-rules-config-in
Despite of those comments, I think your patch looks OK to be applied, so here you have my...
Regards,
Vincent.
Quoted 22 lines
package/openvpn/Config.in +1
-0+ choice prompt "Crypto backend" default BR2_PACKAGE_OPENVPN_CRYPTO_OPENSSLpackage/openvpn/openvpn.mk +6
-0@@ -41,6 +41,12 @@ else OPENVPN_CONF_OPTS += --disable-lzo endif +ifeq ($(BR2_PACKAGE_OPENVPN_PWSAVE),y) +OPENVPN_CONF_OPTS += --enable-password-save +else +OPENVPN_CONF_OPTS += --disable-password-save +endif + ifeq ($(BR2_PACKAGE_OPENVPN_CRYPTO_OPENSSL),y) OPENVPN_CONF_OPTS += --with-crypto-library=openssl OPENVPN_DEPENDENCIES += openssl
Thomas Petazzoni
AppliedPATCH 1/1 openvpn: add option for --enable-password-save
In reply to Andreas WetzelDear Andreas Wetzel,
Quoted 8 lines · Andreas Wetzel
Added configuration option
BR2_PACKAGE_OPENVPN_PWSAVEthat adds --enable-password-save toOPENVPN_CONF_OPTSif selected.Signed-off-by Andreas Wetzel <[email protected]>--- package/openvpn/Config.in | 5 +++++ package/openvpn/openvpn.mk | 6 ++++++ 2 files changed, 11 insertions(+)
Applied, thanks. I've just rewrapped the Config.in help text as suggested by Vicente.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com