i2c: enable i2c device to suspend/resume asynchronously

PATCH Superseded Fu, Zhonghui 2 participants 4 messages Sep 24, 2015 – Nov 23, 2015

Subsystems (2)

I2C subsystem host drivers I2C

lore

Share & tools

lore

Fu, Zhonghui

author

2015-09-24 06:26 UTC #0 lore raw

PATCH v2 1/1 i2c: enable i2c device to suspend/resume asynchronously

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition timing dependency between devices. This patch enables i2c device to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed.

Signed-off-by Zhonghui Fu <[email protected]>

---
Changes in v2:
- Amend commit message.

 drivers/i2c/i2c-core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

drivers/i2c/i2c-core.c +1 -0

index 5f89f1e..74e322b 100644
@@ -1036,6 +1036,7 @@ i2c_new_device(struct i2c_adapter *adap, struct i2c_board_info const *info)
 	client->dev.of_node = info->of_node;
 	client->dev.fwnode = info->fwnode;
 
+	device_enable_async_suspend(&client->dev);
 	i2c_dev_set_name(adap, client);
 	status = device_register(&client->dev);
 	if (status)

-- 1.7.1

Wolfram Sang

2015-10-20 15:02 UTC #1 lore raw

Quoted 8 lines · Zhonghui

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition timing dependency between devices. This patch enables i2c device to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed.
Signed-off-by Zhonghui Fu <[email protected]>

Does it always work when say a PMIC or clock controller is connected to the I2C bus?

Fu, Zhonghui

author

2015-11-23 06:25 UTC #2 lore raw

Quoted 11 lines · Wolfram Sang

Quoted 8 lines · Zhonghui
Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition timing dependency between devices. This patch enables i2c device to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed.
Signed-off-by Zhonghui Fu <[email protected]>
Does it always work when say a PMIC or clock controller is connected to the I2C bus?

Sorry for missing this mail.

Yes, it does not care about what device. The sole difference of asynchronous suspend/resume mode is that the suspend/resume operation of one device is carried out in a separate kernel thread, and PM core ensures all related dependency.

Thanks,
Zhonghui

Quoted 1 line

Fu, Zhonghui

author

2015-11-16 15:26 UTC #3 lore raw

In reply to Fu, Zhonghui

Hi,

Any comments are welcome.

Thanks,
Zhonghui

Quoted 29 lines · Zhonghui

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition timing dependency between devices. This patch enables i2c device to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed.
Signed-off-by Zhonghui Fu <[email protected]>
---
Changes in v2:
- Amend commit message.
 drivers/i2c/i2c-core.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/i2c/i2c-core.c +1 -1
index 5f89f1e..74e322b 100644
@@ -1036,6 +1036,7 @@ i2c_new_device(struct i2c_adapter *adap, struct i2c_board_info const *info)
 	client->dev.of_node = info->of_node;
 	client->dev.fwnode = info->fwnode;
 
+	device_enable_async_suspend(&client->dev);
 	i2c_dev_set_name(adap, client);
 	status = device_register(&client->dev);
 	if (status)
-- 1.7.1