Skip to contentSkip to conversation

video: fbdev: mb862xx: Fix module autoload for OF platform driver

PATCH In review Luis de Bethencourt 2 participants 2 messages Sep 18, 2015 – Sep 24, 2015 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: fbdev: mb862xx: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work.

---

Hello,

This patch adds the missing MODULE_DEVICE_TABLE() for OF to export that information so modules have the correct aliases built-in and autoloading works correctly.

A longer explanation by Javier Canillas can be found here:
https://lkml.org/lkml/2015/7/30/519

Thanks,
Luis

 drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/fbdev/mb862xx/mb862xxfbdrv.c +1 -0
index 9b8bebd..f9ec5c0 100644
@@ -831,6 +831,7 @@ static struct of_device_id of_platform_mb862xx_tbl[] = {
 	{ .compatible = "fujitsu,coral", },
 	{ /* end */ }
 };
+MODULE_DEVICE_TABLE(of, of_platform_mb862xx_tbl);
 
 static struct platform_driver of_platform_mb862xxfb_driver = {
 	.driver = {
Signature · 1 line
2.4.6
#1 lore raw
Quoted 27 lines · Luis de Bethencourt

This platform driver has a OF device ID table but the OF module alias information is not created so module autoloading won't work.

---

Hello,

This patch adds the missing MODULE_DEVICE_TABLE() for OF to export that information so modules have the correct aliases built-in and autoloading works correctly.

A longer explanation by Javier Canillas can be found here:
https://lkml.org/lkml/2015/7/30/519

Thanks,
Luis

 drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 1 +
 1 file changed, 1 insertion(+)
drivers/video/fbdev/mb862xx/mb862xxfbdrv.c +0 -0
index 9b8bebd..f9ec5c0 100644

drivers/video/fbdev/mb862xx/mb862xxfbdrv.c static struct of_device_id of_platform_mb862xx_tbl[] = { · line 837

Quoted 7 lines
drivers/video/fbdev/mb862xx/mb862xxfbdrv.c +1 -0
@@ -831,6 +831,7 @@ static struct of_device_id of_platform_mb862xx_tbl[] = {
 	{ .compatible = "fujitsu,coral", },
 	{ /* end */ }
 };
+MODULE_DEVICE_TABLE(of, of_platform_mb862xx_tbl);
 
 static struct platform_driver of_platform_mb862xxfb_driver = {
 	.driver = {

Thanks, queued for 4.3 fixes.

Tomi