Skip to contentSkip to conversation

parisc: math-emu: fcnvxf: Add space after that ','

PATCH In review [email protected] 2 participants 2 messages Jul 13, 2023 – Jul 20, 2023 1 message not in the archive PA-RISC architecture

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 parisc: math-emu: fcnvxf: Add space after that ','

Fix Error reported by checkpatch.pl

arch/parisc/math-emu/fcnvxf.c:99: ERROR: space required after that ',' (ctx:VxV )

---
 arch/parisc/math-emu/fcnvxf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/parisc/math-emu/fcnvxf.c +1 -1
index 6940179..f5f9376 100644
@@ -96,7 +96,7 @@
                     Sgl_increment(result);
                 break;
             case ROUNDNEAREST:
-                Sgl_roundnearest_from_int(src,result);
+                Sgl_roundnearest_from_int(src, result);
         }
         if (Is_inexacttrap_enabled()) {
             *dstptr = result;
maintainer
#2 lore raw

Hello hanyu001,

Quoted 7 lines · On 7/13/23 11:37, [email protected] wrote:

Fix Error reported by checkpatch.pl

arch/parisc/math-emu/fcnvxf.c:99: ERROR: space required after that ',' (ctx:VxV )

Thanks for that patch!

Your patch is correct and as such it should be applied.
But please notice the arch/parisc/math-emu/README file (in the same directory), which states:
All files except driver.c are snapshots from the HP-UX kernel. They've been modified as little as possible. Even though they don't fit the Linux coding style, please leave them in their funny format just in case someone in the future, with access to HP-UX source code, is generous enough to update our copies with later changes from HP-UX -- it'll make their 'diff' job easier if our code is relatively unmodified.

So, I won't apply any patch to that directory, unless it fixes a real bug or is required to compile the kernel.

Thanks,
Helge

Quoted 17 lines
---
  arch/parisc/math-emu/fcnvxf.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/parisc/math-emu/fcnvxf.c +1 -1
index 6940179..f5f9376 100644
@@ -96,7 +96,7 @@
                      Sgl_increment(result);
                  break;
              case ROUNDNEAREST:
-                Sgl_roundnearest_from_int(src,result);
+                Sgl_roundnearest_from_int(src, result);
          }
          if (Is_inexacttrap_enabled()) {
              *dstptr = result;