Skip to contentSkip to conversation

builtin/apply.c: make a file local symbol static

PATCH New Ramsay Jones 1 participant 1 message Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 builtin/apply.c: make a file local symbol static

Commit dddaaab62 ("apply: convert root string to strbuf", 24-09-2015) converted a <char *str, int len> combination of variables into a single 'struct strbuf' variable. In doing so, it unintentionally increased the visibility of the variable. In order to reduce the visibility to file local, add the static keyword to the declaration of the 'root' symbol.

---

Hi Jeff,

If you need to re-roll your 'jk/war-on-sprintf' series, could you please squash this into the relevant patch.

Thanks!

ATB,
Ramsay Jones

 builtin/apply.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
builtin/apply.c +1 -1
index 5dc908a..ec49658 100644
@@ -77,7 +77,7 @@ static enum ws_ignore {
 
 
 static const char *patch_input_file;
-struct strbuf root = STRBUF_INIT;
+static struct strbuf root = STRBUF_INIT;
 static int read_stdin = 1;
 static int options;
 
Signature · 1 line
2.5.0