glmark2: add missing dependencies
PATCH 1/1 glmark2: add missing dependencies
There are some missing dependencies which are in fact stated in the comment, and due to that you can select the package despite of not satisfying them.
Also propagate the !STATIC dependency from mesa3d and add some comments.
--- package/glmark2/Config.in | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-)
package/glmark2/Config.in +9 -3
@@ -15,6 +15,12 @@ comment "glmark2 needs an OpenGL or an openGL ES and EGL backend provided by mes config BR2_PACKAGE_GLMARK2 bool "glmark2" depends on BR2_PACKAGE_GLMARK2_GL || BR2_PACKAGE_GLMARK2_EGL_GLES + # glmark2-gl and glmark2-egl-gles depend on mesa3d, which intruduces + # dependencies on NPTL, STDCPP and !STATIC. + depends on BR2_INSTALL_LIBSTDCPP # mesa3d + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # mesa3d + depends on !BR2_STATIC_LIBS # mesa3d + depends on BR2_PACKAGE_HAS_UDEV select BR2_PACKAGE_JPEG select BR2_PACKAGE_LIBPNG help
@@ -22,6 +28,6 @@ config BR2_PACKAGE_GLMARK2 https://github.com/glmark2/glmark2 -comment "glmark2 needs udev /dev management and a toolchain w/ C++, NPTL" - depends on !BR2_INSTALL_LIBSTDCPP || \ - !BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_PACKAGE_HAS_UDEV +comment "glmark2 needs udev and a toolchain w/ C++, NPTL, shared library" + depends on !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP || \ + !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
Signature · 1 line
1.7.1
PATCH 1/1 glmark2: add missing dependencies
Hi Vincent,
Quoted 15 lines · Vicente Olivert Riera
There are some missing dependencies which are in fact stated in the comment, and due to that you can select the package despite of not satisfying them.
Also propagate the !STATIC dependency from mesa3d and add some comments.Signed-off-by Vicente Olivert Riera <[email protected]>--- package/glmark2/Config.in | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-)package/glmark2/Config.in +0
-0
package/glmark2/Config.in comment "glmark2 needs an OpenGL or an openGL ES and EGL backend provided by mes · line 23
Quoted 9 lines
package/glmark2/Config.in +6
-0@@ -15,6 +15,12 @@ comment "glmark2 needs an OpenGL or an openGL ES and EGL backend provided by mes config BR2_PACKAGE_GLMARK2 bool "glmark2" depends on BR2_PACKAGE_GLMARK2_GL || BR2_PACKAGE_GLMARK2_EGL_GLES + # glmark2-gl and glmark2-egl-gles depend on mesa3d, which intruduces + # dependencies on NPTL, STDCPP and !STATIC. + depends on BR2_INSTALL_LIBSTDCPP # mesa3d + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # mesa3d + depends on !BR2_STATIC_LIBS # mesa3d + depends on BR2_PACKAGE_HAS_UDEV
Why would that be needed? Kconfig 'depends' is transitive. That is, since glmark2 depends on glmark2-gl/glmark2-egl-gles, that in turn depend on mesa3d, glmark2 automatically also depends on mesa3d dependencies. It is only for 'select' that we need to manually propagate dependencies.
Did you hit any specific problem?
baruch
Quoted 13 lines
package/glmark2/Config.in +3
-3select BR2_PACKAGE_JPEG select BR2_PACKAGE_LIBPNG help@@ -22,6 +28,6 @@ config BR2_PACKAGE_GLMARK2 https://github.com/glmark2/glmark2 -comment "glmark2 needs udev /dev management and a toolchain w/ C++, NPTL" - depends on !BR2_INSTALL_LIBSTDCPP || \ - !BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_PACKAGE_HAS_UDEV +comment "glmark2 needs udev and a toolchain w/ C++, NPTL, shared library" + depends on !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP || \ + !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -PATCH 1/1 glmark2: add missing dependencies
Hello Baruch,
Quoted 33 lines · Baruch Siach
Hi Vincent,
Quoted 15 lines · Vicente Olivert Riera
There are some missing dependencies which are in fact stated in the comment, and due to that you can select the package despite of not satisfying them.
Also propagate the !STATIC dependency from mesa3d and add some comments.Signed-off-by Vicente Olivert Riera <[email protected]>--- package/glmark2/Config.in | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-)package/glmark2/Config.in +0
-0package/glmark2/Config.in comment "glmark2 needs an OpenGL or an openGL ES and EGL backend provided by mes · line 23
Quoted 9 lines
package/glmark2/Config.in +6
-0@@ -15,6 +15,12 @@ comment "glmark2 needs an OpenGL or an openGL ES and EGL backend provided by mes config BR2_PACKAGE_GLMARK2 bool "glmark2" depends on BR2_PACKAGE_GLMARK2_GL || BR2_PACKAGE_GLMARK2_EGL_GLES + # glmark2-gl and glmark2-egl-gles depend on mesa3d, which intruduces + # dependencies on NPTL, STDCPP and !STATIC. + depends on BR2_INSTALL_LIBSTDCPP # mesa3d + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # mesa3d + depends on !BR2_STATIC_LIBS # mesa3d + depends on BR2_PACKAGE_HAS_UDEVWhy would that be needed?
Kconfig'depends' is transitive. That is, since glmark2 depends on glmark2-gl/glmark2-egl-gles, that in turn depend on mesa3d, glmark2 automatically also depends on mesa3d dependencies. It is only for 'select' that we need to manually propagate dependencies.
Quoted 1 line
Did you hit any specific problem?
Yes, you can satisfy this dependency...
depends on BR2_PACKAGE_GLMARK2_GL || BR2_PACKAGE_GLMARK2_EGL_GLES
...and be able to select the glmark2 package from the menu despite of not satisfying the BR2_PACKAGE_HAS_UDEV dependency. In fact, you will still see the comment on the menu, but the comment about the opengl stuff will be replaced by the package so you can select it.
Regards,
Vincent.
Quoted 17 lines
baruch
Quoted 13 lines
package/glmark2/Config.in +3
-3select BR2_PACKAGE_JPEG select BR2_PACKAGE_LIBPNG help@@ -22,6 +28,6 @@ config BR2_PACKAGE_GLMARK2 https://github.com/glmark2/glmark2 -comment "glmark2 needs udev /dev management and a toolchain w/ C++, NPTL" - depends on !BR2_INSTALL_LIBSTDCPP || \ - !BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_PACKAGE_HAS_UDEV +comment "glmark2 needs udev and a toolchain w/ C++, NPTL, shared library" + depends on !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP || \ + !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
PATCH 1/1 glmark2: add missing dependencies
Quoted 39 lines · Vicente Olivert Riera
Hello Baruch,
Quoted 34 lines · Baruch Siach
Hi Vincent,
Quoted 19 lines · Vicente Olivert Riera
There are some missing dependencies which are in fact stated in the comment, and due to that you can select the package despite of not satisfying them.
Also propagate the !STATIC dependency from mesa3d and add some comments.Signed-off-by Vicente Olivert Riera <[email protected]>--- package/glmark2/Config.in | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-)package/glmark2/Config.in +0
-0@@ -15,6 +15,12 @@ comment "glmark2 needs an OpenGL or an openGL ES and EGLbackend provided by mes
configBR2_PACKAGE_GLMARK2bool "glmark2" depends on BR2_PACKAGE_GLMARK2_GL || BR2_PACKAGE_GLMARK2_EGL_GLESpackage/glmark2/Config.in comment "glmark2 needs an OpenGL or an openGL ES and EGL backend provided by mes · line 23
Quoted 6 lines
package/glmark2/Config.in +6
-0+ # glmark2-gl and glmark2-egl-gles depend on mesa3d, which intruduces + # dependencies on NPTL, STDCPP and !STATIC. + depends on BR2_INSTALL_LIBSTDCPP # mesa3d + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # mesa3d + depends on !BR2_STATIC_LIBS # mesa3d + depends on BR2_PACKAGE_HAS_UDEVWhy would that be needed?
Kconfig'depends' is transitive. That is, since glmark2 depends on glmark2-gl/glmark2-egl-gles, that in turn depend on mesa3d, glmark2 automatically also depends on mesa3d dependencies. It is only for 'select' that we need to manually propagate dependencies.Quoted 1 line
Did you hit any specific problem?
Quoted 8 lines
Yes, you can satisfy this dependency...
depends on
BR2_PACKAGE_GLMARK2_GL||BR2_PACKAGE_GLMARK2_EGL_GLES...and be able to select the glmark2 package from the menu despite of not satisfying the
BR2_PACKAGE_HAS_UDEVdependency. In fact, you will still see the comment on the menu, but the comment about the opengl stuff will be replaced by the package so you can select it.
The UDEV part of the comment is in fact wrong. UDEV dependency was removed from
mesa3d in f5fbb12da0f0f1dbf23cdd603f41103da41e4f68, but glmark2 was not updated.
Regards,
Arnout
Quoted 27 lines
Regards,
Vincent.
Quoted 8 lines
baruch
Quoted 5 lines
select
BR2_PACKAGE_JPEG
selectBR2_PACKAGE_LIBPNG
helppackage/glmark2/Config.in +0
-0@@ -22,6 +28,6 @@ config BR2_PACKAGE_GLMARK2Quoted 9 lines
package/glmark2/Config.in config BR2_PACKAGE_GLMARK2 · line 33
Quoted 8 lines
package/glmark2/Config.in +3
-3https://github.com/glmark2/glmark2 -comment "glmark2 needs udev /dev management and a toolchain w/ C++, NPTL" - depends on !BR2_INSTALL_LIBSTDCPP || \ - !BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_PACKAGE_HAS_UDEV +comment "glmark2 needs udev and a toolchain w/ C++, NPTL, shared library" + depends on !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP || \ + !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF