net: dsa: Complete and fix the dsa unbinding

In order to cleanly unbind the dsa core, either as a module removal, or a platform device unbind, switch the allocation the their devm_ counterparts and complete the destroy functions.

The last patch is an experimental way to exit the probe when no switch is found in the discover process.

The patches are based on the current net-next.

Neil Armstrong (3):
net: dsa: Use devm_ prefixed allocations
net: dsa: complete dsa_switch_destroy calls
net: dsa: exit probe if no switch were found

 net/dsa/dsa.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 60 insertions(+), 7 deletions(-)

Quoted 8 lines · Neil Armstrong

In order to cleanly unbind the dsa core, either as a module removal, or a platform device unbind, switch the allocation the their devm_ counterparts and complete the destroy functions.

The last patch is an experimental way to exit the probe when no switch is found in the discover process.

The patches are based on the current net-next.

I looked at the patches and they bring DSA in a better direction. For future submissions, could you CC people who recently worked on DSA, like Andrew Lunn, Guenter Roeck, Vivien Didelot and myself? We can typically give your patches a try fairly quickly.

In case you are seriously considering making DSA a loadable module, there were an earlier attempt here:

http://comments.gmane.org/gmane.linux.network/345803

Thanks!

Quoted 9 lines

Neil Armstrong (3):
net: dsa: Use devm_ prefixed allocations
net: dsa: complete dsa_switch_destroy calls
net: dsa: exit probe if no switch were found

 net/dsa/dsa.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 60 insertions(+), 7 deletions(-)

Quoted 15 lines · Florian Fainelli

Quoted 8 lines · Neil Armstrong

In order to cleanly unbind the dsa core, either as a module removal, or a platform device unbind, switch the allocation the their devm_ counterparts and complete the destroy functions.

The last patch is an experimental way to exit the probe when no switch is found in the discover process.

The patches are based on the current net-next.

I looked at the patches and they bring DSA in a better direction. For future submissions, could you CC people who recently worked on DSA, like Andrew Lunn, Guenter Roeck, Vivien Didelot and myself? We can typically give your patches a try fairly quickly.

Quoted 18 lines

In case you are seriously considering making DSA a loadable module, there were an earlier attempt here:

http://comments.gmane.org/gmane.linux.network/345803

Thanks!

Quoted 9 lines

Neil Armstrong (3):
net: dsa: Use devm_ prefixed allocations
net: dsa: complete dsa_switch_destroy calls
net: dsa: exit probe if no switch were found

 net/dsa/dsa.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 60 insertions(+), 7 deletions(-)

Hi All,

Thanks for the tests and reviews.

My first intent is to make dynamic unbind/bind reliable, the reliable loadable module support is a more complex target, but starting with unbind is a simpler start.

Should I re-post with the missing people, the Tested-by & without the RFC tag ?

Quoted 8 lines · Neil Armstrong

In order to cleanly unbind the dsa core, either as a module removal, or a platform device unbind, switch the allocation the their devm_ counterparts and complete the destroy functions.

The last patch is an experimental way to exit the probe when no switch is found in the discover process.

The patches are based on the current net-next.

I looked at the patches and they bring DSA in a better direction. For future submissions, could you CC people who recently worked on DSA, like Andrew Lunn, Guenter Roeck, Vivien Didelot and myself? We can typically give your patches a try fairly quickly.

In case you are seriously considering making DSA a loadable module, there were an earlier attempt here:

http://comments.gmane.org/gmane.linux.network/345803

Thanks!

Quoted 9 lines

Neil Armstrong (3):
net: dsa: Use devm_ prefixed allocations
net: dsa: complete dsa_switch_destroy calls
net: dsa: exit probe if no switch were found

 net/dsa/dsa.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 60 insertions(+), 7 deletions(-)