ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning
Subsystems (2)
PATCH 1/1 ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning
48ffb94 ("ACPICA: AcpiGetSleepTypeData: Allow \_Sx to return either 1 or 2 integers") changed the error handling in AcpiGetSleepTypeData such that
ACPI Exception: AE_NOT_FOUND, While evaluating Sleep State [\_S1_] (20130517/hwxface-571)
is displayed on systems not implementing individual ACPI \_Sx sleep states. Since these states are optional the loud warning is incorrect. This patch changes the kernel to the older behaviour of not warning on a missing \_Sx.
Before patch:
[root@dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State"
ACPI Exception: AE_NOT_FOUND, While evaluating Sleep State [\_S1_] (20130517/hwxface-571) ACPI Exception: AE_NOT_FOUND, While evaluating Sleep State [\_S2_] (20130517/hwxface-571) ACPI Exception: AE_NOT_FOUND, While evaluating Sleep State [\_S3_] (20130517/hwxface-571)
[root@dell-pem520-03 ~]#
After patch:
[root@dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State" [root@dell-pem520-03 ~]#
--- drivers/acpi/acpica/hwxface.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/acpi/acpica/hwxface.c +6 -4
@@ -508,6 +508,7 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)ACPI_CAST_PTR (char, acpi_gbl_sleep_state_names[sleep_state]); status =acpi_ns_evaluate (info);if (ACPI_FAILURE (status)) { +/* \_Sx states are optional */ goto cleanup; }
@@ -517,7 +518,7 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)ACPI_ERROR ((AE_INFO ,"No Sleep State object returned from [%s]" , info->relative_pathname)); status =AE_AML_NO_RETURN_VALUE ; - goto cleanup; + goto cleanup1; }/* Return object must be of type Package */
@@ -526,7 +527,7 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)ACPI_ERROR ((AE_INFO ,"Sleep State return object is not a Package" )); status =AE_AML_OPERAND_TYPE ; - goto cleanup1; + goto cleanup2; }/*
@@ -570,16 +571,17 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)break ; } -cleanup1: +cleanup2:acpi_ut_remove_reference (info->return_object); -cleanup: +cleanup1:if (ACPI_FAILURE (status)) {ACPI_EXCEPTION ((AE_INFO , status,"While evaluating Sleep State [%s]" , info->relative_pathname)); } +cleanup:ACPI_FREE (info);return_ACPI_STATUS (status); }
Signature · 1 line
1.7.9.3
Moore
I seem to remember that this came up a long time ago.
Perhaps someone else will remember.
Quoted 105 lines
-----Original Message-----
From: Prarit Bhargava [mailto:prarit(a)redhat.com]
Sent: Thursday, October 01, 2015 10:29 AM
To: devel(a)acpica.org
Cc: Prarit Bhargava; Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-acpi(a)vger.kernel.org
Subject: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning48ffb94 ("ACPICA: AcpiGetSleepTypeData: Allow \_Sx to return either 1 or 2 integers") changed the error handling in AcpiGetSleepTypeData such that
ACPI Exception:
AE_NOT_FOUND, While evaluating Sleep State [\_S1_] (20130517/hwxface-571)is displayed on systems not implementing individual ACPI \_Sx sleep states.
Since these states are optional the loud warning is incorrect. This patch changes the kernel to the older behaviour of not warning on a missing \_Sx.Before patch:
[root(a)dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State"
ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S1_]
(20130517/hwxface-571) ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S2_] (20130517/hwxface-571) ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S3_] (20130517/hwxface-571) [root(a)dell-pem520-03 ~]#After patch:
[root(a)dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State" [root(a)dell-pem520-03 ~]#
Fixes 48ffb94 ("ACPICA: AcpiGetSleepTypeData: Allow \_Sx to return either1 or 2 integers")
Cc: Robert Moore <robert.moore(a)intel.com>
Cc: Lv Zheng <lv.zheng(a)intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki(a)intel.com>
Cc: Len Brown <lenb(a)kernel.org>
Cc: linux-acpi(a)vger.kernel.orgSigned-off-by Prarit Bhargava <prarit(a)redhat.com>--- drivers/acpi/acpica/hwxface.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)drivers/acpi/acpica/hwxface.c +2
-1@@ -508,6 +508,7 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)ACPI_CAST_PTR (char, acpi_gbl_sleep_state_names[sleep_state]); status =acpi_ns_evaluate (info);if (ACPI_FAILURE (status)) { +/* \_Sx states are optional */ goto cleanup; }@@ -517,7 +518,7 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)ACPI_ERROR ((AE_INFO ,"No Sleep State object returned from [%s]", info->relative_pathname)); status =AE_AML_NO_RETURN_VALUE ; - goto cleanup; + goto cleanup1; }/* Return object must be of type Package */ @@ -526,7 +527,7 @@
acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)drivers/acpi/acpica/hwxface.c +4
-3ACPI_ERROR ((AE_INFO ,"Sleep State return object is not a Package" )); status =AE_AML_OPERAND_TYPE ; - goto cleanup1; + goto cleanup2; }/* @@ -570,16 +571,17 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)break ; } -cleanup1: +cleanup2:acpi_ut_remove_reference (info->return_object); -cleanup: +cleanup1:if (ACPI_FAILURE (status)) {ACPI_EXCEPTION ((AE_INFO , status,"While evaluating Sleep State [%s]" , info->relative_pathname)); } +cleanup:ACPI_FREE (info);return_ACPI_STATUS (status);}
--
1.7.9.3
Quoted 4 lines · Robert
I seem to remember that this came up a long time ago.
Perhaps someone else will remember.
I can't recall, sorry.
Quoted 105 lines
Quoted 105 lines
-----Original Message-----
From: Prarit Bhargava [mailto:[email protected]]
Sent: Thursday, October 01, 2015 10:29 AM
To: [email protected]
Cc: Prarit Bhargava; Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; [email protected]
Subject: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning48ffb94 ("ACPICA: AcpiGetSleepTypeData: Allow \_Sx to return either 1 or 2 integers") changed the error handling in AcpiGetSleepTypeData such that
ACPI Exception:
AE_NOT_FOUND, While evaluating Sleep State [\_S1_] (20130517/hwxface-571)is displayed on systems not implementing individual ACPI \_Sx sleep states.
Since these states are optional the loud warning is incorrect. This patch changes the kernel to the older behaviour of not warning on a missing \_Sx.Before patch:
[root@dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State"
ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S1_]
(20130517/hwxface-571) ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S2_] (20130517/hwxface-571) ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S3_] (20130517/hwxface-571) [root@dell-pem520-03 ~]#After patch:
[root@dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State" [root@dell-pem520-03 ~]#
Fixes 48ffb94 ("ACPICA: AcpiGetSleepTypeData: Allow \_Sx to return either1 or 2 integers")
Cc: Robert Moore <[email protected]>
Cc: Lv Zheng <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Cc: Len Brown <[email protected]>
Cc: [email protected]Signed-off-by Prarit Bhargava <[email protected]>--- drivers/acpi/acpica/hwxface.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)drivers/acpi/acpica/hwxface.c +2
-1@@ -508,6 +508,7 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)ACPI_CAST_PTR (char, acpi_gbl_sleep_state_names[sleep_state]); status =acpi_ns_evaluate (info);if (ACPI_FAILURE (status)) { +/* \_Sx states are optional */ goto cleanup; }@@ -517,7 +518,7 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)ACPI_ERROR ((AE_INFO ,"No Sleep State object returned from [%s]", info->relative_pathname)); status =AE_AML_NO_RETURN_VALUE ; - goto cleanup; + goto cleanup1; }/* Return object must be of type Package */ @@ -526,7 +527,7 @@
acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)
ACPI_ERROR((AE_INFO,
"Sleep State return object is not a Package"));
status =AE_AML_OPERAND_TYPE;drivers/acpi/acpica/hwxface.c +4
-3- goto cleanup1; + goto cleanup2; }/* @@ -570,16 +571,17 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)break ; } -cleanup1: +cleanup2:acpi_ut_remove_reference (info->return_object); -cleanup: +cleanup1:if (ACPI_FAILURE (status)) {ACPI_EXCEPTION ((AE_INFO , status,"While evaluating Sleep State [%s]" , info->relative_pathname)); } +cleanup:ACPI_FREE (info);return_ACPI_STATUS (status);}
--
1.7.9.3
Quoted 7 lines · Rafael J. Wysocki
Quoted 4 lines · Robert
I seem to remember that this came up a long time ago.
Perhaps someone else will remember.
I can't recall, sorry.
FWIW, a google search on these warnings yields tonnes of comments about them, but with no resolution AFAICT.
P.
Moore
It would be easy to remove (or partially remove) the warning. Hopefully the calling code will handle AE_NOT_FOUND correctly.
Quoted 23 lines
-----Original Message-----
From: Prarit Bhargava [mailto:prarit(a)redhat.com]
Sent: Wednesday, October 07, 2015 8:29 AM
To: Wysocki, Rafael J; Moore, Robert; devel(a)acpica.org
Cc: Zheng, Lv; Len Brown; linux-acpi(a)vger.kernel.org; Box, David E
Subject: Re: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warningQuoted 7 lines · Rafael J. Wysocki
Quoted 4 lines · Robert
I seem to remember that this came up a long time ago.
Perhaps someone else will remember.
I can't recall, sorry.
FWIW, a google search on these warnings yields tonnes of comments about them, but with no resolution AFAICT.
P.
Quoted 2 lines · Robert
It would be easy to remove (or partially remove) the warning. Hopefully the calling code will handle
AE_NOT_FOUNDcorrectly.
In the specific case of the \_Sx sleep states the code does handle the AE_NOT_FOUND correctly. The issue is solely the warning being displayed when there should be no warning.
P.
Moore
I'm thinking that AE_NOT_FOUND should not generate a warning, but any other exception should.
Quoted 20 lines
-----Original Message-----
From: Prarit Bhargava [mailto:prarit(a)redhat.com]
Sent: Wednesday, October 07, 2015 8:57 AM
To: Moore, Robert; Wysocki, Rafael J; devel(a)acpica.org
Cc: Zheng, Lv; Len Brown; linux-acpi(a)vger.kernel.org; Box, David E
Subject: Re: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warningQuoted 1 line · Robert
It would be easy to remove (or partially remove) the warning. Hopefully
the calling code will handle
AE_NOT_FOUNDcorrectly.Quoted 1 line
In the specific case of the \_Sx sleep states the code does handle the
AE_NOT_FOUNDcorrectly. The issue is solely the warning being displayed when there should be no warning.P.
PATCH 1/1 ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]
48ffb94 ("ACPICA: AcpiGetSleepTypeData: Allow \_Sx to return either 1 or 2 integers") changed the error handling in AcpiGetSleepTypeData such that
ACPI Exception: AE_NOT_FOUND, While evaluating Sleep State [\_S1_] (20130517/hwxface-571)
is displayed on systems not implementing individual ACPI \_Sx sleep states. Since these states are optional the loud warning is incorrect. This patch changes the kernel to the older behaviour of not warning on a not found \_Sx.
Before patch:
[root@dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State"
ACPI Exception: AE_NOT_FOUND, While evaluating Sleep State [\_S1_] (20130517/hwxface-571) ACPI Exception: AE_NOT_FOUND, While evaluating Sleep State [\_S2_] (20130517/hwxface-571) ACPI Exception: AE_NOT_FOUND, While evaluating Sleep State [\_S3_] (20130517/hwxface-571)
[root@dell-pem520-03 ~]#
After patch:
[root@dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State" [root@dell-pem520-03 ~]#
v2: Suggested by Robert Moore: Do not warn on AE_NOT_FOUND, otherwise warn loudly
--- drivers/acpi/acpica/hwxface.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)
drivers/acpi/acpica/hwxface.c +10 -5
@@ -507,9 +507,13 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b) info->relative_pathname =ACPI_CAST_PTR (char, acpi_gbl_sleep_state_names[sleep_state]); status =acpi_ns_evaluate (info); -if (ACPI_FAILURE (status)) { +if (status ==AE_NOT_FOUND ) { +/* \_Sx states are optional */ goto cleanup; } +if (ACPI_FAILURE (status)) { + goto cleanup1; + }/* Must have a return object */
@@ -517,7 +521,7 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)ACPI_ERROR ((AE_INFO ,"No Sleep State object returned from [%s]" , info->relative_pathname)); status =AE_AML_NO_RETURN_VALUE ; - goto cleanup; + goto cleanup1; }/* Return object must be of type Package */
@@ -526,7 +530,7 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)ACPI_ERROR ((AE_INFO ,"Sleep State return object is not a Package" )); status =AE_AML_OPERAND_TYPE ; - goto cleanup1; + goto cleanup2; }/*
@@ -570,16 +574,17 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)break ; } -cleanup1: +cleanup2:acpi_ut_remove_reference (info->return_object); -cleanup: +cleanup1:if (ACPI_FAILURE (status)) {ACPI_EXCEPTION ((AE_INFO , status,"While evaluating Sleep State [%s]" , info->relative_pathname)); } +cleanup:ACPI_FREE (info);return_ACPI_STATUS (status); }
Signature · 1 line
1.7.9.3
Moore
Re: [Devel] [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]
We'll do the ACPICA version of this, although with probably with some changes. Thanks,
Bob
Quoted 114 lines
-----Original Message-----
From: Prarit Bhargava [mailto:prarit(a)redhat.com]
Sent: Wednesday, October 07, 2015 11:51 AM
To: devel(a)acpica.org
Cc: Prarit Bhargava; Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-acpi(a)vger.kernel.org
Subject: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]48ffb94 ("ACPICA: AcpiGetSleepTypeData: Allow \_Sx to return either 1 or 2 integers") changed the error handling in AcpiGetSleepTypeData such that
ACPI Exception:
AE_NOT_FOUND, While evaluating Sleep State [\_S1_] (20130517/hwxface-571)is displayed on systems not implementing individual ACPI \_Sx sleep states.
Since these states are optional the loud warning is incorrect. This patch changes the kernel to the older behaviour of not warning on a not found \_Sx.Before patch:
[root(a)dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State"
ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S1_]
(20130517/hwxface-571) ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S2_] (20130517/hwxface-571) ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S3_] (20130517/hwxface-571) [root(a)dell-pem520-03 ~]#After patch:
[root(a)dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State" [root(a)dell-pem520-03 ~]#
v2: Suggested by Robert Moore: Do not warn on
AE_NOT_FOUND, otherwise warn loudlyFixes 48ffb94 ("ACPICA: AcpiGetSleepTypeData: Allow \_Sx to return either1 or 2 integers")
Cc: Robert Moore <robert.moore(a)intel.com>
Cc: Lv Zheng <lv.zheng(a)intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki(a)intel.com>
Cc: Len Brown <lenb(a)kernel.org>
Cc: linux-acpi(a)vger.kernel.org
Signed-off-by: Prarit Bhargava <prarit(a)redhat.com>--- drivers/acpi/acpica/hwxface.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)drivers/acpi/acpica/hwxface.c +6
-2@@ -507,9 +507,13 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b) info->relative_pathname =ACPI_CAST_PTR (char, acpi_gbl_sleep_state_names[sleep_state]); status =acpi_ns_evaluate (info); -if (ACPI_FAILURE (status)) { +if (status ==AE_NOT_FOUND ) { +/* \_Sx states are optional */ goto cleanup; } +if (ACPI_FAILURE (status)) { + goto cleanup1; + }/* Must have a return object */ @@ -517,7 +521,7 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)ACPI_ERROR ((AE_INFO ,"No Sleep State object returned from [%s]", info->relative_pathname)); status =AE_AML_NO_RETURN_VALUE ; - goto cleanup; + goto cleanup1; }/* Return object must be of type Package */ @@ -526,7 +530,7 @@
acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)drivers/acpi/acpica/hwxface.c +4
-3ACPI_ERROR ((AE_INFO ,"Sleep State return object is not a Package" )); status =AE_AML_OPERAND_TYPE ; - goto cleanup1; + goto cleanup2; }/* @@ -570,16 +574,17 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)break ; } -cleanup1: +cleanup2:acpi_ut_remove_reference (info->return_object); -cleanup: +cleanup1:if (ACPI_FAILURE (status)) {ACPI_EXCEPTION ((AE_INFO , status,"While evaluating Sleep State [%s]" , info->relative_pathname)); } +cleanup:ACPI_FREE (info);return_ACPI_STATUS (status);}
--
1.7.9.3
Re: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]
Quoted 2 lines · Robert
We'll do the ACPICA version of this, although with probably with some changes. Thanks,
Thanks Bob. If you could let me know when this lands in github(?) that would be great. I'll reference it in the backport upstream.
P.
Quoted 118 lines
Bob
Quoted 114 lines
-----Original Message-----
From: Prarit Bhargava [mailto:[email protected]]
Sent: Wednesday, October 07, 2015 11:51 AM
To: [email protected]
Cc: Prarit Bhargava; Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; [email protected]
Subject: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]48ffb94 ("ACPICA: AcpiGetSleepTypeData: Allow \_Sx to return either 1 or 2 integers") changed the error handling in AcpiGetSleepTypeData such that
ACPI Exception:
AE_NOT_FOUND, While evaluating Sleep State [\_S1_] (20130517/hwxface-571)is displayed on systems not implementing individual ACPI \_Sx sleep states.
Since these states are optional the loud warning is incorrect. This patch changes the kernel to the older behaviour of not warning on a not found \_Sx.Before patch:
[root@dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State"
ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S1_]
(20130517/hwxface-571) ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S2_] (20130517/hwxface-571) ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S3_] (20130517/hwxface-571) [root@dell-pem520-03 ~]#After patch:
[root@dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State" [root@dell-pem520-03 ~]#
v2: Suggested by Robert Moore: Do not warn on
AE_NOT_FOUND, otherwise warn loudlyFixes 48ffb94 ("ACPICA: AcpiGetSleepTypeData: Allow \_Sx to return either1 or 2 integers")
Cc Robert Moore <[email protected]>Cc Lv Zheng <[email protected]>Cc "Rafael J. Wysocki" <[email protected]>Cc Len Brown <[email protected]>Signed-off-by Prarit Bhargava <[email protected]>--- drivers/acpi/acpica/hwxface.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)drivers/acpi/acpica/hwxface.c +6
-2@@ -507,9 +507,13 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b) info->relative_pathname =ACPI_CAST_PTR (char, acpi_gbl_sleep_state_names[sleep_state]); status =acpi_ns_evaluate (info); -if (ACPI_FAILURE (status)) { +if (status ==AE_NOT_FOUND ) { +/* \_Sx states are optional */ goto cleanup; } +if (ACPI_FAILURE (status)) { + goto cleanup1; + }/* Must have a return object */ @@ -517,7 +521,7 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)ACPI_ERROR ((AE_INFO ,"No Sleep State object returned from [%s]", info->relative_pathname)); status =AE_AML_NO_RETURN_VALUE ; - goto cleanup; + goto cleanup1; }/* Return object must be of type Package */ @@ -526,7 +530,7 @@
acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)drivers/acpi/acpica/hwxface.c +4
-3ACPI_ERROR ((AE_INFO ,"Sleep State return object is not a Package" )); status =AE_AML_OPERAND_TYPE ; - goto cleanup1; + goto cleanup2; }/* @@ -570,16 +574,17 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)break ; } -cleanup1: +cleanup2:acpi_ut_remove_reference (info->return_object); -cleanup: +cleanup1:if (ACPI_FAILURE (status)) {ACPI_EXCEPTION ((AE_INFO , status,"While evaluating Sleep State [%s]" , info->relative_pathname)); } +cleanup:ACPI_FREE (info);return_ACPI_STATUS (status);}
--
1.7.9.3
Zheng
Re: [Devel] [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]
Why don't you fix this in the invoker side?
For example:
If (acpi_get_handle())
acpi_evaluate_object()
So that the AE_NOT_FOUND warning can still be kept for the real troubles? There are really scenarios that such warning is useful for catching bugs.
Thanks and best regards
-Lv
Quoted 140 lines
-----Original Message-----
From: linux-acpi-owner(a)vger.kernel.org [mailto:linux-acpi-owner(a)vger.kernel.org] On Behalf Of Prarit Bhargava
Sent: Thursday, October 08, 2015 10:23 PM
To: Moore, Robert; devel(a)acpica.org
Cc: Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-acpi(a)vger.kernel.org
Subject: Re: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]Quoted 2 lines · Robert
We'll do the ACPICA version of this, although with probably with some changes. Thanks,
Thanks Bob. If you could let me know when this lands in github(?) that would be great. I'll reference it in the backport upstream.
P.
Quoted 111 lines
Bob
Quoted 108 lines
-----Original Message-----
From: Prarit Bhargava [mailto:prarit(a)redhat.com]
Sent: Wednesday, October 07, 2015 11:51 AM
To: devel(a)acpica.org
Cc: Prarit Bhargava; Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-acpi(a)vger.kernel.org
Subject: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]48ffb94 ("ACPICA: AcpiGetSleepTypeData: Allow \_Sx to return either 1 or 2 integers") changed the error handling in AcpiGetSleepTypeData such that
ACPI Exception:
AE_NOT_FOUND, While evaluating Sleep State [\_S1_] (20130517/hwxface-571)is displayed on systems not implementing individual ACPI \_Sx sleep states.
Since these states are optional the loud warning is incorrect. This patch changes the kernel to the older behaviour of not warning on a not found \_Sx.Before patch:
[root(a)dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State"
ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S1_]
(20130517/hwxface-571) ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S2_] (20130517/hwxface-571) ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S3_] (20130517/hwxface-571) [root(a)dell-pem520-03 ~]#After patch:
[root(a)dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State" [root(a)dell-pem520-03 ~]#
v2: Suggested by Robert Moore: Do not warn on
AE_NOT_FOUND, otherwise warn loudlyFixes 48ffb94 ("ACPICA: AcpiGetSleepTypeData: Allow \_Sx to return either1 or 2 integers")
Cc: Robert Moore <robert.moore(a)intel.com>
Cc: Lv Zheng <lv.zheng(a)intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki(a)intel.com>
Cc: Len Brown <lenb(a)kernel.org>
Cc: linux-acpi(a)vger.kernel.org
Signed-off-by: Prarit Bhargava <prarit(a)redhat.com>--- drivers/acpi/acpica/hwxface.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)drivers/acpi/acpica/hwxface.c +6
-2@@ -507,9 +507,13 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b) info->relative_pathname =ACPI_CAST_PTR (char, acpi_gbl_sleep_state_names[sleep_state]); status =acpi_ns_evaluate (info); -if (ACPI_FAILURE (status)) { +if (status ==AE_NOT_FOUND ) { +/* \_Sx states are optional */ goto cleanup; } +if (ACPI_FAILURE (status)) { + goto cleanup1; + }/* Must have a return object */ @@ -517,7 +521,7 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)ACPI_ERROR ((AE_INFO ,"No Sleep State object returned from [%s]", info->relative_pathname)); status =AE_AML_NO_RETURN_VALUE ; - goto cleanup; + goto cleanup1; }/* Return object must be of type Package */ @@ -526,7 +530,7 @@
acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)drivers/acpi/acpica/hwxface.c +3
-3ACPI_ERROR ((AE_INFO ,"Sleep State return object is not a Package" )); status =AE_AML_OPERAND_TYPE ; - goto cleanup1; + goto cleanup2; }/* @@ -570,16 +574,17 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)break ; } -cleanup1: +cleanup2:acpi_ut_remove_reference (info->return_object); -cleanup: +cleanup1:if (ACPI_FAILURE (status)) {ACPI_EXCEPTION ((AE_INFO , status,"While evaluating Sleep State [%s]" , info->relative_pathname)); }Quoted 7 lines
Quoted 6 lines
drivers/acpi/acpica/hwxface.c +1
-0+cleanup:ACPI_FREE (info);return_ACPI_STATUS (status);}
--
1.7.9.3--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Zheng
Re: [Devel] [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]
Please ignore this.
The fix is against the caller.
Thanks and best regards
-Lv
Quoted 161 lines
-----Original Message-----
From: Devel [mailto:devel-bounces(a)acpica.org] On Behalf Of Zheng, Lv
Sent: Friday, October 09, 2015 10:02 AM
To: Prarit Bhargava; Moore, Robert; devel(a)acpica.org
Cc: linux-acpi(a)vger.kernel.org; Wysocki, Rafael J
Subject: Re: [Devel] [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]Why don't you fix this in the invoker side?
For example:
If (acpi_get_handle())
acpi_evaluate_object()
So that theAE_NOT_FOUNDwarning can still be kept for the real troubles? There are really scenarios that such warning is useful for catching bugs.Thanks and best regards
-LvQuoted 136 lines
-----Original Message-----
From: linux-acpi-owner(a)vger.kernel.org [mailto:linux-acpi-owner(a)vger.kernel.org] On Behalf Of Prarit Bhargava
Sent: Thursday, October 08, 2015 10:23 PM
To: Moore, Robert; devel(a)acpica.org
Cc: Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-acpi(a)vger.kernel.org
Subject: Re: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]Quoted 2 lines · Robert
We'll do the ACPICA version of this, although with probably with some changes. Thanks,
Thanks Bob. If you could let me know when this lands in github(?) that would be great. I'll reference it in the backport upstream.
P.
Quoted 111 lines
Bob
Quoted 108 lines
-----Original Message-----
From: Prarit Bhargava [mailto:prarit(a)redhat.com]
Sent: Wednesday, October 07, 2015 11:51 AM
To: devel(a)acpica.org
Cc: Prarit Bhargava; Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-acpi(a)vger.kernel.org
Subject: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]48ffb94 ("ACPICA: AcpiGetSleepTypeData: Allow \_Sx to return either 1 or 2 integers") changed the error handling in AcpiGetSleepTypeData such that
ACPI Exception:
AE_NOT_FOUND, While evaluating Sleep State [\_S1_] (20130517/hwxface-571)is displayed on systems not implementing individual ACPI \_Sx sleep states.
Since these states are optional the loud warning is incorrect. This patch changes the kernel to the older behaviour of not warning on a not found \_Sx.Before patch:
[root(a)dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State"
ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S1_]
(20130517/hwxface-571) ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S2_] (20130517/hwxface-571) ACPI Exception:AE_NOT_FOUND, While evaluating Sleep State [\_S3_] (20130517/hwxface-571) [root(a)dell-pem520-03 ~]#After patch:
[root(a)dell-pem520-03 ~]# dmesg | grep "While evaluating Sleep State" [root(a)dell-pem520-03 ~]#
v2: Suggested by Robert Moore: Do not warn on
AE_NOT_FOUND, otherwise warn loudlyFixes 48ffb94 ("ACPICA: AcpiGetSleepTypeData: Allow \_Sx to return either1 or 2 integers")
Cc: Robert Moore <robert.moore(a)intel.com>
Cc: Lv Zheng <lv.zheng(a)intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki(a)intel.com>
Cc: Len Brown <lenb(a)kernel.org>
Cc: linux-acpi(a)vger.kernel.org
Signed-off-by: Prarit Bhargava <prarit(a)redhat.com>--- drivers/acpi/acpica/hwxface.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-)drivers/acpi/acpica/hwxface.c +6
-2@@ -507,9 +507,13 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b) info->relative_pathname =ACPI_CAST_PTR (char, acpi_gbl_sleep_state_names[sleep_state]); status =acpi_ns_evaluate (info); -if (ACPI_FAILURE (status)) { +if (status ==AE_NOT_FOUND ) { +/* \_Sx states are optional */ goto cleanup; } +if (ACPI_FAILURE (status)) { + goto cleanup1; + }/* Must have a return object */ @@ -517,7 +521,7 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)ACPI_ERROR ((AE_INFO ,"No Sleep State object returned from [%s]", info->relative_pathname)); status =AE_AML_NO_RETURN_VALUE ; - goto cleanup; + goto cleanup1; }/* Return object must be of type Package */ @@ -526,7 +530,7 @@
acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)drivers/acpi/acpica/hwxface.c +3
-3ACPI_ERROR ((AE_INFO ,"Sleep State return object is not a Package" )); status =AE_AML_OPERAND_TYPE ; - goto cleanup1; + goto cleanup2; }/* @@ -570,16 +574,17 @@ acpi_get_sleep_type_data(u8 sleep_state, u8 *sleep_type_a, u8 *sleep_type_b)break ; } -cleanup1: +cleanup2:acpi_ut_remove_reference (info->return_object); -cleanup: +cleanup1:if (ACPI_FAILURE (status)) {ACPI_EXCEPTION ((AE_INFO , status,"While evaluating Sleep State [%s]" , info->relative_pathname)); }Quoted 7 lines
Quoted 6 lines
drivers/acpi/acpica/hwxface.c +1
-0+cleanup:ACPI_FREE (info);return_ACPI_STATUS (status);}
--
1.7.9.3Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo(a)vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html_______________________________________________
Devel mailing list
Devel(a)acpica.org
https://lists.acpica.org/mailman/listinfo/devel
Re: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]
Quoted 17 lines · Lv
Please ignore this.
The fix is against the caller.Thanks and best regards
-LvQuoted 11 lines
-----Original Message-----
From: Devel [mailto:[email protected]] On Behalf Of Zheng, Lv
Sent: Friday, October 09, 2015 10:02 AM
To: Prarit Bhargava; Moore, Robert; [email protected]
Cc: [email protected]; Wysocki, Rafael J
Subject: Re: [Devel] [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]Why don't you fix this in the invoker side?
For example:
If (acpi_get_handle())
acpi_evaluate_object()
That seems like a sloppy workaround an actual bug in ACPICA.
Quoted 1 line
Quoted 1 line
So that the
AE_NOT_FOUNDwarning can still be kept for the real troubles?
The code is warning 100% of the time on something that is optional.
Quoted 2 lines
Quoted 2 lines
There are really scenarios that such warning is useful for catching bugs.
What scenario is possible where this causes a problem? Issuing an error on something that is optional is not a good idea.
P.
Moore
Re: [Devel] [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]
I have no issues with the original solution. We don't warn on other ACPI_NOT_FOUND exceptions.
Quoted 45 lines
-----Original Message-----
From: Prarit Bhargava [mailto:prarit(a)redhat.com]
Sent: Friday, October 09, 2015 4:30 AM
To: Zheng, Lv; Moore, Robert; devel(a)acpica.org
Cc: linux-acpi(a)vger.kernel.org; Wysocki, Rafael J
Subject: Re: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]Quoted 18 lines · Lv
Please ignore this.
The fix is against the caller.Thanks and best regards
-LvQuoted 12 lines
-----Original Message-----
From: Devel [mailto:devel-bounces(a)acpica.org] On Behalf Of Zheng, Lv
Sent: Friday, October 09, 2015 10:02 AM
To: Prarit Bhargava; Moore, Robert; devel(a)acpica.org
Cc: linux-acpi(a)vger.kernel.org; Wysocki, Rafael J
Subject: Re: [Devel] [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]Why don't you fix this in the invoker side?
For example:
If (acpi_get_handle())
acpi_evaluate_object()That seems like a sloppy workaround an actual bug in ACPICA.
Quoted 1 line
Quoted 1 line
So that the
AE_NOT_FOUNDwarning can still be kept for the realtroubles?
The code is warning 100% of the time on something that is optional.
Quoted 1 line
Quoted 1 line
There are really scenarios that such warning is useful for catching
bugs.
Quoted 1 line
Quoted 1 line
What scenario is possible where this causes a problem? Issuing an error on something that is optional is not a good idea.
P.
Zheng
Re: [Devel] [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]
In reply to Prarit BhargavaHi,
Quoted 6 lines
From: Prarit Bhargava [mailto:prarit(a)redhat.com]
Sent: Friday, October 09, 2015 7:30 PMQuoted 2 lines · Lv
Please ignore this.
The fix is against the caller.
As I said, the previous email is sent due to lack of confirmation. So you needn't reply the previous message.
Thanks
-Lv
Quoted 25 lines
Quoted 11 lines
Thanks and best regards
-LvQuoted 7 lines
From: Devel [mailto:devel-bounces(a)acpica.org] On Behalf Of Zheng, Lv
Sent: Friday, October 09, 2015 10:02 AMWhy don't you fix this in the invoker side?
For example:
If (acpi_get_handle())
acpi_evaluate_object()That seems like a sloppy workaround an actual bug in ACPICA.
Quoted 1 line
Quoted 1 line
So that the
AE_NOT_FOUNDwarning can still be kept for the real troubles?The code is warning 100% of the time on something that is optional.
Quoted 2 lines
Quoted 2 lines
There are really scenarios that such warning is useful for catching bugs.
What scenario is possible where this causes a problem? Issuing an error on something that is optional is not a good idea.
P.
Zheng
Re: [Devel] [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]
In reply to Prarit BhargavaHi,
Quoted 13 lines
From: Prarit Bhargava [mailto:prarit(a)redhat.com]
Sent: Friday, October 09, 2015 7:30 PMQuoted 9 lines · Lv
Please ignore this.
The fix is against the caller.Thanks and best regards
-LvQuoted 3 lines
From: Devel [mailto:devel-bounces(a)acpica.org] On Behalf Of Zheng, Lv
Sent: Friday, October 09, 2015 10:02 AM
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines
Why don't you fix this in the invoker side?
For example:
If (acpi_get_handle())
acpi_evaluate_object()That seems like a sloppy workaround an actual bug in ACPICA.
So let me ignore this which is a reply for a useless question.
Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
So that the
AE_NOT_FOUNDwarning can still be kept for the real troubles?The code is warning 100% of the time on something that is optional.
Let me ignore this which is a reply for a useless question.
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
There are really scenarios that such warning is useful for catching bugs.
What scenario is possible where this causes a problem? Issuing an error on something that is optional is not a good idea.
There are several scenarios, let me say some known stuffs about the module level code support.
In AML grammar, module level code (non-object-definition AML opcodes outside of a control method) is legal.
While it is supported in ACPICA in a split way:
1. In the early stage, table loading code only executes those object definition opcodes and links all "if/else/while" AML fragments together.
2. In the late stage, object initialization code will execute such AML fragments before invoking all _INI methods.
1. Since code is not executed in the Windows compliant order during the early table loading stage, some objects are not defined while they should.
2. Even worse, during the early stage, ACPICA may fail the whole table loading process due to AE_NOT_FOUND, leaving us partial initialized objects (the ACPICA AML interpreter implements 2 phases to parse a table to complete the table loading). Such issue is worked around by deleting the namespace objects created during the early stage if an exception (AE_NOT_FOUND) is encountered.
So you can see, such kind of error is sometime useful for catching AML interpreter issues or BIOS bugs.
Thanks and best regards
-Lv
Moore
Re: [Devel] [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]
I'm a bit confused. What does the execution of the _Sx methods have to do with module-level code? Obviously, many times the _Sx objects are implemented as simply named objects, but the table load doesn't care what is and what isn't present.
Quoted 73 lines
-----Original Message-----
From: Zheng, Lv
Sent: Friday, October 09, 2015 6:38 PM
To: Prarit Bhargava; Moore, Robert; devel(a)acpica.org
Cc: linux-acpi(a)vger.kernel.org; Wysocki, Rafael J
Subject: RE: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]Hi,
Quoted 14 lines
From: Prarit Bhargava [mailto:prarit(a)redhat.com]
Sent: Friday, October 09, 2015 7:30 PMQuoted 10 lines · Lv
Please ignore this.
The fix is against the caller.Thanks and best regards
-LvQuoted 4 lines
From: Devel [mailto:devel-bounces(a)acpica.org] On Behalf Of Zheng, Lv
Sent: Friday, October 09, 2015 10:02 AMQuoted 6 lines
Quoted 4 lines
Quoted 4 lines
Why don't you fix this in the invoker side?
For example:
If (acpi_get_handle())
acpi_evaluate_object()That seems like a sloppy workaround an actual bug in ACPICA.
So let me ignore this which is a reply for a useless question.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
So that the
AE_NOT_FOUNDwarning can still be kept for the realtroubles?
Quoted 2 lines
The code is warning 100% of the time on something that is optional.
Let me ignore this which is a reply for a useless question.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
There are really scenarios that such warning is useful for catching
bugs.
Quoted 4 lines
Quoted 1 line
Quoted 1 line
What scenario is possible where this causes a problem? Issuing an error on something that is optional is not a good idea.
There are several scenarios, let me say some known stuffs about the module level code support.
In AML grammar, module level code (non-object-definition AML opcodes outside of a control method) is legal.
While it is supported in ACPICA in a split way:
1. In the early stage, table loading code only executes those object definition opcodes and links all "if/else/while" AML fragments together.
2. In the late stage, object initialization code will execute such AML fragments before invoking all_INImethods.1. Since code is not executed in the Windows compliant order during the early table loading stage, some objects are not defined while they should.
2. Even worse, during the early stage, ACPICA may fail the whole table loading process due toAE_NOT_FOUND, leaving us partial initialized objects (the ACPICA AML interpreter implements 2 phases to parse a table to complete the table loading).
Such issue is worked around by deleting the namespace objects created during the early stage if an exception (AE_NOT_FOUND) is encountered.So you can see, such kind of error is sometime useful for catching AML interpreter issues or BIOS bugs.
Thanks and best regards
-Lv
Zheng
Re: [Devel] [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]
Hi, Bob
Quoted 10 lines
-----Original Message-----
From: Moore, Robert
Sent: Wednesday, October 14, 2015 5:00 AM
To: Zheng, Lv; Prarit Bhargava; devel(a)acpica.org
Cc: linux-acpi(a)vger.kernel.org; Wysocki, Rafael J
Subject: RE: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]I'm a bit confused. What does the execution of the
_Sxmethods have to do with module-level code? Obviously, many times the_Sxobjects are implemented as simply named objects, but the table load doesn't care what is and what isn't present.
The AE_NOT_FOUND for _Sx should have been fixed.
What we are talking is not related to the _Sx warning.
I was just replying Prarit that why such kind of warning messages could be useful.
Thanks and best regards
-Lv
Quoted 74 lines
Quoted 74 lines
-----Original Message-----
From: Zheng, Lv
Sent: Friday, October 09, 2015 6:38 PM
To: Prarit Bhargava; Moore, Robert; devel(a)acpica.org
Cc: linux-acpi(a)vger.kernel.org; Wysocki, Rafael J
Subject: RE: [PATCH] ACPICA: AcpiGetSleepTypeData: Failure to find \_Sx should not result in a loud warning [v2]Hi,
Quoted 14 lines
From: Prarit Bhargava [mailto:prarit(a)redhat.com]
Sent: Friday, October 09, 2015 7:30 PMQuoted 10 lines · Lv
Please ignore this.
The fix is against the caller.Thanks and best regards
-LvQuoted 4 lines
From: Devel [mailto:devel-bounces(a)acpica.org] On Behalf Of Zheng, Lv
Sent: Friday, October 09, 2015 10:02 AMQuoted 6 lines
Quoted 4 lines
Quoted 4 lines
Why don't you fix this in the invoker side?
For example:
If (acpi_get_handle())
acpi_evaluate_object()That seems like a sloppy workaround an actual bug in ACPICA.
So let me ignore this which is a reply for a useless question.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
So that the
AE_NOT_FOUNDwarning can still be kept for the realtroubles?
Quoted 2 lines
The code is warning 100% of the time on something that is optional.
Let me ignore this which is a reply for a useless question.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
There are really scenarios that such warning is useful for catching
bugs.
Quoted 4 lines
Quoted 1 line
Quoted 1 line
What scenario is possible where this causes a problem? Issuing an error on something that is optional is not a good idea.
There are several scenarios, let me say some known stuffs about the module level code support.
In AML grammar, module level code (non-object-definition AML opcodes outside of a control method) is legal.
While it is supported in ACPICA in a split way:
1. In the early stage, table loading code only executes those object definition opcodes and links all "if/else/while" AML fragments together.
2. In the late stage, object initialization code will execute such AML fragments before invoking all_INImethods.1. Since code is not executed in the Windows compliant order during the early table loading stage, some objects are not defined while they should.
2. Even worse, during the early stage, ACPICA may fail the whole table loading process due toAE_NOT_FOUND, leaving us partial initialized objects (the ACPICA AML interpreter implements 2 phases to parse a table to complete the table loading).
Such issue is worked around by deleting the namespace objects created during the early stage if an exception (AE_NOT_FOUND) is encountered.So you can see, such kind of error is sometime useful for catching AML interpreter issues or BIOS bugs.
Thanks and best regards
-Lv