Skip to contentSkip to conversation

net: dsa: complete and fix the dsa unbinding

PATCH In review Neil Armstrong 2 participants 2 messages Oct 6, 2015 – Oct 7, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v3 cover net: dsa: complete and fix the dsa unbinding

In order to cleanly unbind the dsa core, either as a module removal, or a platform device unbind, switch the allocation the their devm_ counterparts and complete the destroy functions.

First, the missing kfree were added, the remove function were completed then kfree were removed in favor to devm_ calls.

The last patch is an way to cleanly exit the probe when no switch is found in the discover process.

The patches are based on the current net.

v3:
- make checkpatch happy with 1/5 & 5/5
- fix 5/5 exit path with a goto

Neil Armstrong (5):
net: dsa: add missing kfree on remove
net: dsa: add missing dsa_switch mdiobus remove
net: dsa: complete dsa_switch_destroy
net: dsa: switch to devm_ calls and remove kfree calls
net: dsa: exit probe if no switch were found

 net/dsa/dsa.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 59 insertions(+), 11 deletions(-)
Signature · 1 line
1.9.1
maintainer
#1 lore raw

From: Neil Armstrong <[email protected]>
Date: Tue, 6 Oct 2015 15:39:42 +0100

Quoted 7 lines

In order to cleanly unbind the dsa core, either as a module removal, or a platform device unbind, switch the allocation the their devm_ counterparts and complete the destroy functions.

First, the missing kfree were added, the remove function were completed then kfree were removed in favor to devm_ calls.

Quoted 8 lines

The last patch is an way to cleanly exit the probe when no switch is found in the discover process.

The patches are based on the current net.

v3:
- make checkpatch happy with 1/5 & 5/5
- fix 5/5 exit path with a goto

Series applied, thanks Neil.