Skip to contentSkip to conversation

SSP frame iu defines

DISCUSSION John Garry 4 participants 6 messages Oct 8, 2015 – Oct 13, 2015 SCSI

lore
Share & tools
lore

John Garry

author
#0 lore raw

Hi,

For a new driver I am preparing for a SAS controller, I need defintions for the SSP command and TMF iu structures. Currently these are defined in the following:
ssp_command_iu, ssp_task_iu: drivers/scsi/aic94xx_sas.h
ssp_cmd_iu, ssp_task_iu: drivers/scsi/isci/sas.h

I plan to move them to include/scsi/sas.h . Any objections?

Thanks,
John

#1 lore raw
Quoted 9 lines · On Thursday 08 October 2015 15:17:49 John Garry wrote:

Hi,

For a new driver I am preparing for a SAS controller, I need defintions for the SSP command and TMF iu structures. Currently these are defined in the following:
ssp_command_iu, ssp_task_iu: drivers/scsi/aic94xx_sas.h ssp_cmd_iu, ssp_task_iu: drivers/scsi/isci/sas.h

I plan to move them to include/scsi/sas.h . Any objections?

Hi John,

I think a question like this is better asked by sending a patch, to make it easier to see what the resulting change is.

Arnd

author
#2 lore raw
Quoted 9 lines · Arnd Bergmann
Quoted 8 lines · On Thursday 08 October 2015 15:17:49 John Garry wrote:

Hi,

For a new driver I am preparing for a SAS controller, I need defintions for the SSP command and TMF iu structures. Currently these are defined in the following:
ssp_command_iu, ssp_task_iu: drivers/scsi/aic94xx_sas.h ssp_cmd_iu, ssp_task_iu: drivers/scsi/isci/sas.h

Quoted 10 lines
Quoted 1 line

I plan to move them to include/scsi/sas.h . Any objections?

Hi John,

I think a question like this is better asked by sending a patch, to make it easier to see what the resulting change is.

Arnd

OK, can I put this together.
I feel that the code may get messy due to byte-ordering difference in isci versions.

Regards,
John

#3 lore raw
Quoted 19 lines · John Garry
Quoted 18 lines · Arnd Bergmann
Quoted 11 lines · On Thursday 08 October 2015 15:17:49 John Garry wrote:

Hi,

For a new driver I am preparing for a SAS controller, I need defintions
for the SSP command and TMF iu structures. Currently these are defined
in the following:
ssp_command_iu, ssp_task_iu: drivers/scsi/aic94xx_sas.h ssp_cmd_iu, ssp_task_iu: drivers/scsi/isci/sas.h

I plan to move them to include/scsi/sas.h . Any objections?

Hi John,

I think a question like this is better asked by sending a patch, to make it easier to see what the resulting change is.

Quoted 7 lines
Quoted 3 lines

Arnd

OK, can I put this together.
I feel that the code may get messy due to byte-ordering difference in isci versions.

Then define a standard version, and use the appropriate conversion macros in the driver itself.

Cheers,

Hannes

Signature · 9 lines
Dr. Hannes Reinecke		               zSeries & Storage
[email protected]			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer
#4 lore raw
In reply to John Garry
Quoted 17 lines · John Garry
Quoted 16 lines · Arnd Bergmann
Quoted 9 lines · On Thursday 08 October 2015 15:17:49 John Garry wrote:

Hi,

For a new driver I am preparing for a SAS controller, I need defintions for the SSP command and TMF iu structures. Currently these are defined in the following:
ssp_command_iu, ssp_task_iu: drivers/scsi/aic94xx_sas.h ssp_cmd_iu, ssp_task_iu: drivers/scsi/isci/sas.h

I plan to move them to include/scsi/sas.h . Any objections?

Hi John,

I think a question like this is better asked by sending a patch, to make it easier to see what the resulting change is.

Quoted 6 lines
Quoted 3 lines

Arnd

OK, can I put this together.
I feel that the code may get messy due to byte-ordering difference in isci versions.

That's why we develop with the show me the code model. Rather than arguing theoretically about whether something should or should not be done, you propose the actual change. If it looks like a dog's breakfast and all attempts to clean it up fail, chances are it's a bad change and it won't go in. However, if it looks good, chances are it will.

James

author
#5 lore raw
Quoted 14 lines
Quoted 4 lines

OK, can I put this together.
I feel that the code may get messy due to byte-ordering difference in isci versions.

That's why we develop with the show me the code model. Rather than arguing theoretically about whether something should or should not be done, you propose the actual change. If it looks like a dog's breakfast and all attempts to clean it up fail, chances are it's a bad change and it won't go in. However, if it looks good, chances are it will.

James

Quoted 7 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

.

There is a patch for this in "[PATCH 01/25] [SCSI] sas: centralise ssp frame information units".

Thanks,
John