I have a large patch in the 2000 lines. What to do?
Hi!
I have a large patch in the 2000 lines, which replaces the macro BITn to BIT(n) in multiple files.
Is it worth to split this patch into several parts?
Is it sufficient to place the changes in each file in a separate part of patchset?
Quoted 8 lines · Ivan Safonov
Hi!
I have a large patch in the 2000 lines, which replaces the macro BITn to BIT(n) in multiple files.
I will recommend sending RFC patch first and
Get the community comments.
If they like your patch then divide the patch based on logic rather than lines of codes.
Quoted 10 lines
Is it worth to split this patch into several parts?
Is it sufficient to place the changes in each file in a separate part of patchset?_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Quoted 11 lines · Anish Kumar
Quoted 8 lines · Ivan Safonov
Hi!
I have a large patch in the 2000 lines, which replaces the macro BITn to BIT(n) in multiple files.
I will recommend sending RFC patch first and
Get the community comments.
No, we just ignore RFC patches, we have too many "real" patches to deal with.
Quoted 2 lines
If they like your patch then divide the patch based on logic rather than lines of codes.
Quoted 1 line
Is it worth to split this patch into several parts?
Yes.
Quoted 2 lines
Quoted 2 lines
Is it sufficient to place the changes in each file in a separate part of patchset?
Make it one-patch-per-driver.
But note, cleanup patches like this are usually ignored by most subsystems, be aware that this type of thing is only usually accepted in the drivers/staging/ portion of the kernel.
good luck!
greg k-h
Quoted 21 lines · Greg KH
Quoted 9 lines · Anish Kumar
Quoted 7 lines · Ivan Safonov
Hi!
I have a large patch in the 2000 lines, which replaces the macro BITn to BIT(n) in multiple files.
I will recommend sending RFC patch first and
Get the community comments.No, we just ignore RFC patches, we have too many "real" patches to deal with.
Quoted 2 lines
If they like your patch then divide the patch based on logic rather than lines of codes.
Quoted 1 line
Is it worth to split this patch into several parts?
Yes.
Quoted 2 lines
Quoted 2 lines
Is it sufficient to place the changes in each file in a separate part of patchset?
Make it one-patch-per-driver.
Quoted 7 lines
But note, cleanup patches like this are usually ignored by most subsystems, be aware that this type of thing is only usually accepted in the
drivers/staging/portion of the kernel.good luck!
greg k-h
The catch is that this patch is only to one driver.
Quoted 26 lines · Ivan Safonov
Quoted 25 lines · Greg KH
Quoted 9 lines · Anish Kumar
Quoted 7 lines · Ivan Safonov
Hi!
I have a large patch in the 2000 lines, which replaces the macro BITn to BIT(n) in multiple files.
I will recommend sending RFC patch first and
Get the community comments.No, we just ignore RFC patches, we have too many "real" patches to deal with.
Quoted 2 lines
If they like your patch then divide the patch based on logic rather than lines of codes.
Quoted 1 line
Is it worth to split this patch into several parts?
Yes.
Quoted 2 lines
Quoted 2 lines
Is it sufficient to place the changes in each file in a separate part of patchset?
Make it one-patch-per-driver.
But note, cleanup patches like this are usually ignored by most subsystems, be aware that this type of thing is only usually accepted in the
drivers/staging/portion of the kernel.
Quoted 5 lines
Quoted 3 lines
good luck!
greg k-h
The catch is that this patch is only to one driver.
You know, providing specifics is always nice when asking questions...
If it's just one driver, and you think the patch is correct, just send it in as normal, in one patch, as it should be "easy" to understand.
But again, remember that these types of "cleanups" are not always appreciated for some portions of the kernel (again, you were not specific so I can't be specific back...)
greg k-h
I believe that it was answered.
What is the recommendation when I change a structure in a include file and this change causes a lots of new changes, for example?
Julio Cesar Faracco
2015-10-10 11:14 GMT-03:00 Greg KH <[email protected]>:
Quoted 48 lines · Ivan Safonov
Quoted 26 lines · Greg KH
Quoted 25 lines · Anish Kumar
Quoted 9 lines
Quoted 7 lines · Ivan Safonov
Hi!
I have a large patch in the 2000 lines, which replaces the macro BITn to BIT(n) in multiple files.
I will recommend sending RFC patch first and
Get the community comments.No, we just ignore RFC patches, we have too many "real" patches to deal with.
Quoted 2 lines
If they like your patch then divide the patch based on logic rather than lines of codes.
Quoted 1 line
Is it worth to split this patch into several parts?
Yes.
Quoted 2 lines
Quoted 2 lines
Is it sufficient to place the changes in each file in a separate part of patchset?
Make it one-patch-per-driver.
But note, cleanup patches like this are usually ignored by most subsystems, be aware that this type of thing is only usually accepted in the
drivers/staging/portion of the kernel.Quoted 5 lines
Quoted 3 lines
good luck!
greg k-h
The catch is that this patch is only to one driver.
You know, providing specifics is always nice when asking questions...
If it's just one driver, and you think the patch is correct, just send it in as normal, in one patch, as it should be "easy" to understand.
But again, remember that these types of "cleanups" are not always appreciated for some portions of the kernel (again, you were not specific so I can't be specific back...)
greg k-h
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies at kernelnewbies.org
http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
Quoted 3 lines · Julio Faracco
What is the recommendation when I change a structure in a include file and this change causes a lots of new changes, for example?
You do the change in a way that does not cause build failures and spread the patches out over all subsystems to fix things up.
Do you have a specific example you were thinking of so that I can show how it can be done in this way?
thanks,
greg k-h