Skip to contentSkip to conversation

ibcacheedit.c: Eliminate unused parameter passed to update_switchportguids

PATCH Applied Hal Rosenstock 2 participants 2 messages Oct 13, 2015 1 message not in the archive InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH 1/1 ibcacheedit.c: Eliminate unused parameter passed to update_switchportguids

src/ibcacheedit.c: In function ?update_switchportguids?:
src/ibcacheedit.c:168: warning: unused parameter ?guid?

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

---

src/ibcacheedit.c +3 -3
index 983c0ab..b520839 100644
@@ -165,7 +165,7 @@ static int process_opt(void *context, int ch, char *optarg)
 	return 0;
 }
 
-static void update_switchportguids(ibnd_node_t *node, uint64_t guid)
+static void update_switchportguids(ibnd_node_t *node)
 {
 	ibnd_port_t *port;
 	int p;

@@ -191,7 +191,7 @@ static void replace_node_guid(ibnd_node_t *node, void *user_data)
 		 * switches, so update port guids too
 		 */
 		if (node->type == IB_NODE_SWITCH)
-			update_switchportguids(node, guids->after);
+			update_switchportguids(node);
 
 		guids->found++;
 	}

@@ -229,7 +229,7 @@ static void replace_portguid(ibnd_node_t *node, void *user_data)
 		 */
 		if (node->guid == guids->before) {
 			node->guid = guids->after;
-			update_switchportguids(node, guids->after);
+			update_switchportguids(node);
 			guids->found++;
 		}
 	}

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 561CFB2A.1030103-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

Applied
#2 lore raw
Quoted 5 lines · Hal Rosenstock

src/ibcacheedit.c: In function ?update_switchportguids?:
src/ibcacheedit.c:168: warning: unused parameter ?guid?

Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

Thanks applied,
Ira

Quoted 24 lines

---

src/ibcacheedit.c +2 -2
index 983c0ab..b520839 100644
@@ -165,7 +165,7 @@ static int process_opt(void *context, int ch, char *optarg)
 	return 0;
 }
 
-static void update_switchportguids(ibnd_node_t *node, uint64_t guid)
+static void update_switchportguids(ibnd_node_t *node)
 {
 	ibnd_port_t *port;
 	int p;

@@ -191,7 +191,7 @@ static void replace_node_guid(ibnd_node_t *node, void *user_data)
 		 * switches, so update port guids too
 		 */
 		if (node->type == IB_NODE_SWITCH)
-			update_switchportguids(node, guids->after);
+			update_switchportguids(node);
 
 		guids->found++;
 	}

src/ibcacheedit.c static void replace_portguid(ibnd_node_t *node, void *user_data) · line 235

Quoted 8 lines
src/ibcacheedit.c +1 -1
@@ -229,7 +229,7 @@ static void replace_portguid(ibnd_node_t *node, void *user_data)
 		 */
 		if (node->guid == guids->before) {
 			node->guid = guids->after;
-			update_switchportguids(node, guids->after);
+			update_switchportguids(node);
 			guids->found++;
 		}
 	}

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html