Skip to contentSkip to conversation

net: change the env name to use const

PATCH New Josh Wu 3 participants 5 messages Sep 1, 2015 – Oct 29, 2015 Networking

lore
Share & tools
lore

Josh Wu

author
#0 lore raw

PATCH 1/1 net: change the env name to use const

As we don't modify the 'name' parameter, so change it to const.

Signed-off-by Josh Wu <[email protected]>

---

 include/net.h | 4 ++--
 net/eth.c     | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
include/net.h +2 -2
index d09bec9..133fee4 100644
@@ -229,8 +229,8 @@ void eth_set_current(void);		/* set nterface to ethcur var */
 
 int eth_get_dev_index(void);		/* get the device index */
 void eth_parse_enetaddr(const char *addr, uchar *enetaddr);
-int eth_getenv_enetaddr(char *name, uchar *enetaddr);
-int eth_setenv_enetaddr(char *name, const uchar *enetaddr);
+int eth_getenv_enetaddr(const char *name, uchar *enetaddr);
+int eth_setenv_enetaddr(const char *name, const uchar *enetaddr);
 
 /*
  * Get the hardware address for an ethernet interface .
net/eth.c +2 -2
index d3ec8d6..8e146d2 100644
@@ -31,13 +31,13 @@ void eth_parse_enetaddr(const char *addr, uchar *enetaddr)
 	}
 }
 
-int eth_getenv_enetaddr(char *name, uchar *enetaddr)
+int eth_getenv_enetaddr(const char *name, uchar *enetaddr)
 {
 	eth_parse_enetaddr(getenv(name), enetaddr);
 	return is_valid_ethaddr(enetaddr);
 }
 
-int eth_setenv_enetaddr(char *name, const uchar *enetaddr)
+int eth_setenv_enetaddr(const char *name, const uchar *enetaddr)
 {
 	char buf[20];
Signature · 1 line
1.9.1
author
#3 lore raw

PATCH 1/1 net: change the env name to use const

Hi, Joe

Quoted 5 lines · Joe Hershberger
Quoted 3 lines · Josh Wu

As we don't modify the 'name' parameter, so change it to const.

Signed-off-by Josh Wu <[email protected]>
Acked-by Joe Hershberger <[email protected]>

Thanks for the Ack.
It seems I didn't see this patch in your git tree, or I missed something?

Best Regards,
Josh Wu