Skip to contentSkip to conversation

thermal: exynos: Fix register read in TMU

PATCH New Krzysztof Kozlowski 2 participants 2 messages Oct 12, 2015 – Oct 16, 2015

Subsystems (3)
Arm Samsung Exynos Thermal Samsung thermal driver
lore
Share & tools
lore

Krzysztof Kozlowski

author
#0 lore raw

PATCH 1/1 thermal: exynos: Fix register read in TMU

From: Sudip Mukherjee <[email protected]>

The value of emul_con was getting overwritten if the selected soc is SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong register in the case of SOC_ARCH_EXYNOS5260.

Signed-off-by Sudip Mukherjee <[email protected]>
Reviewed-by Krzysztof Kozlowski <[email protected]>
Reviewed-by Chanwoo Choi <[email protected]>
Acked-by Lukasz Majewski <[email protected]>
Fixes 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU")
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/thermal/samsung/exynos_tmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/samsung/exynos_tmu.c +1 -1
index 0bae8cc6c23a..ca920b0ecf8f 100644
@@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data,
 
 	if (data->soc == SOC_ARCH_EXYNOS5260)
 		emul_con = EXYNOS5260_EMUL_CON;
-	if (data->soc == SOC_ARCH_EXYNOS5433)
+	else if (data->soc == SOC_ARCH_EXYNOS5433)
 		emul_con = EXYNOS5433_TMU_EMUL_CON;
 	else if (data->soc == SOC_ARCH_EXYNOS7)
 		emul_con = EXYNOS7_TMU_REG_EMUL_CON;
Signature · 1 line
1.9.1
Applied
#1 lore raw

PATCH 1/1 thermal: exynos: Fix register read in TMU

Quoted 21 lines · Krzysztof Kozlowski

From: Sudip Mukherjee <[email protected]>

The value of emul_con was getting overwritten if the selected soc is SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong register in the case of SOC_ARCH_EXYNOS5260.

Signed-off-by Sudip Mukherjee <[email protected]>
Reviewed-by Krzysztof Kozlowski <[email protected]>
Reviewed-by Chanwoo Choi <[email protected]>
Acked-by Lukasz Majewski <[email protected]>
Fixes 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU")
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/thermal/samsung/exynos_tmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/samsung/exynos_tmu.c +0 -0
index 0bae8cc6c23a..ca920b0ecf8f 100644

drivers/thermal/samsung/exynos_tmu.c static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data, · line 938

Quoted 8 lines
drivers/thermal/samsung/exynos_tmu.c +1 -1
@@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data,
 
 	if (data->soc == SOC_ARCH_EXYNOS5260)
 		emul_con = EXYNOS5260_EMUL_CON;
-	if (data->soc == SOC_ARCH_EXYNOS5433)
+	else if (data->soc == SOC_ARCH_EXYNOS5433)
 		emul_con = EXYNOS5433_TMU_EMUL_CON;
 	else if (data->soc == SOC_ARCH_EXYNOS7)
 		emul_con = EXYNOS7_TMU_REG_EMUL_CON;

Applied, thanks.

- Kukjin