staging: wilc1000: restore wilc_spi_dev variable

PATCH In review Arnd Bergmann 2 participants 2 messages Oct 16, 2015 – Oct 18, 2015 Staging

Share & tools

Arnd Bergmann

author

2015-10-16 20:05 UTC #0 lore raw

PATCH 1/1 staging: wilc1000: restore wilc_spi_dev variable

A recent change to wilc1000 accidentally deleted an important variable, so we now get a build error when the SPI mode is selected:

ERROR: "wilc_spi_dev" [drivers/staging/wilc1000/wilc1000.ko] undefined!

This partially reverts the broken commit to put the variable back.

Signed-off-by Arnd Bergmann <[email protected]>

Fixes 56293ff232b9 ("staging: wilc1000: linux_wlan_spi: include header")

---
Found on ARM randconfig builds.

drivers/staging/wilc1000/linux_wlan_spi.c +1 -0

index 760b72a9a6ff..039d06192d6b 100644
@@ -41,6 +41,7 @@
 
 static u32 SPEED = MIN_SPEED;
 
+struct spi_device *wilc_spi_dev;
 void linux_spi_deinit(void *vp);
 
 static int __init wilc_bus_probe(struct spi_device *spi)

Stanislav Kholmanskikh

2015-10-18 09:29 UTC #1 lore raw

Hi!

Quoted 11 lines · Arnd Bergmann

A recent change to wilc1000 accidentally deleted an important variable, so we now get a build error when the SPI mode is selected:
ERROR: "wilc_spi_dev" [drivers/staging/wilc1000/wilc1000.ko] undefined!
This partially reverts the broken commit to put the variable back.
Signed-off-by Arnd Bergmann <[email protected]>
Fixes 56293ff232b9 ("staging: wilc1000: linux_wlan_spi: include header")
---

I'm really sorry about it, will be more careful in the future.

Thank you for fixing this.