Skip to contentSkip to conversation

leds: leds-net48xx: Use devm_led_classdev_register

PATCH Applied Muhammad Falak R Wani 2 participants 2 messages Oct 16, 2015 – Oct 19, 2015

Subsystems (2)
LED Soekris NET48XX LED support
lore
Share & tools
lore

Muhammad Falak R Wani

author
#0 lore raw

PATCH 1/1 leds: leds-net48xx: Use devm_led_classdev_register

Use devm_led_classdev_register instead of led_classdev_register, removing the redundant net48xx_led_remove function.

Signed-off-by Muhammad Falak R Wani <[email protected]>
---
 drivers/leds/leds-net48xx.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
drivers/leds/leds-net48xx.c +1 -8
index ec3a2e8..0d214c2 100644
@@ -39,18 +39,11 @@ static struct led_classdev net48xx_error_led = {
 
 static int net48xx_led_probe(struct platform_device *pdev)
 {
-	return led_classdev_register(&pdev->dev, &net48xx_error_led);
-}
-
-static int net48xx_led_remove(struct platform_device *pdev)
-{
-	led_classdev_unregister(&net48xx_error_led);
-	return 0;
+	return devm_led_classdev_register(&pdev->dev, &net48xx_error_led);
 }
 
 static struct platform_driver net48xx_led_driver = {
 	.probe		= net48xx_led_probe,
-	.remove		= net48xx_led_remove,
 	.driver		= {
 		.name		= DRVNAME,
 	},
Signature · 1 line
1.9.1
Applied
#1 lore raw

Hi Muhammad,

Quoted 23 lines · Muhammad Falak R Wani

Use devm_led_classdev_register instead of led_classdev_register, removing the redundant net48xx_led_remove function.

Signed-off-by Muhammad Falak R Wani <[email protected]>
---
  drivers/leds/leds-net48xx.c | 9 +--------
  1 file changed, 1 insertion(+), 8 deletions(-)
drivers/leds/leds-net48xx.c +0 -6
index ec3a2e8..0d214c2 100644
@@ -39,18 +39,11 @@ static struct led_classdev net48xx_error_led = {
 
  static int net48xx_led_probe(struct platform_device *pdev)
  {
-	return led_classdev_register(&pdev->dev, &net48xx_error_led);
-}
-
-static int net48xx_led_remove(struct platform_device *pdev)
-{
-	led_classdev_unregister(&net48xx_error_led);

drivers/leds/leds-net48xx.c static struct led_classdev net48xx_error_led = { · line 49

Quoted 10 lines
drivers/leds/leds-net48xx.c +1 -2
-	return 0;
+	return devm_led_classdev_register(&pdev->dev, &net48xx_error_led);
  }
 
  static struct platform_driver net48xx_led_driver = {
  	.probe		= net48xx_led_probe,
-	.remove		= net48xx_led_remove,
  	.driver		= {
  		.name		= DRVNAME,
  	},

Applied, thanks.

Signature · 2 lines
Best Regards,
Jacek Anaszewski