Skip to contentSkip to conversation

bcm2835: Add Raspberry Pi thermal sensor to the device tree

PATCH New Lubomir Rintel 2 participants 2 messages Oct 11, 2015 – Oct 21, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bcm2835: Add Raspberry Pi thermal sensor to the device tree

Driven via the Raspberry Pi VideoCore 4 firmware interface.

Cc Stephen Warren <[email protected]>
Cc Lee Jones <[email protected]>
Cc Eric Anholt <[email protected]>
Cc devicetree at vger.kernel.org
Cc linux-rpi-kernel at lists.infradead.org
Cc linux-arm-kernel at lists.infradead.org

---
Needs the RPi firmware patchset from branch 'rpi-firmware' of
https://github.com/anholt/linux

 .../bindings/thermal/raspberrypi,bcm2835-thermal.txt        | 13 +++++++++++++
 arch/arm/boot/dts/bcm2835-rpi.dtsi                          |  5 +++++
 2 files changed, 18 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/thermal/raspberrypi,bcm2835-thermal.txt
Documentation/devicetree/bindings/thermal/raspberrypi,bcm2835-thermal.txt new file +13 -0
new file mode 100644
index 0000000..f323f35
@@ -0,0 +1,13 @@
+Raspberry Pi Broadcom BCM2835 thermal control
+
+Required properties:
+
+- compatible : should be "raspberrypi,bcm2835-thermal"
+- firmware : the Raspberry Pi firmware node
+
+Example:
+
+thermal {
+	compatible = "raspberrypi,bcm2835-thermal";
+	firmware = <&firmware>;
+};
arch/arm/boot/dts/bcm2835-rpi.dtsi +5 -0
index ab5474e..727bbf8 100644
@@ -20,6 +20,11 @@
 			compatible = "raspberrypi,bcm2835-firmware";
 			mboxes = <&mailbox>;
 		};
+
+		thermal {
+			compatible = "raspberrypi,bcm2835-thermal";
+			firmware = <&firmware>;
+		};
 	};
 };
 
Signature · 1 line
2.4.3
#1 lore raw

PATCH 1/1 bcm2835: Add Raspberry Pi thermal sensor to the device tree

Quoted 4 lines · Lubomir Rintel

Driven via the Raspberry Pi VideoCore 4 firmware interface.

 .../bindings/thermal/raspberrypi,bcm2835-thermal.txt        | 13 +++++++++++++
 arch/arm/boot/dts/bcm2835-rpi.dtsi                          |  5 +++++

There should be a separate patch for the DT binding and DT additions, but they can be in a series. As before, CC at least the DT binding to the DT binding maintainers.

Documentation/devicetree/bindings/thermal/raspberrypi,bcm2835-thermal.txt line 3

Quoted 5 lines
Documentation/devicetree/bindings/thermal/raspberrypi,bcm2835-thermal.txt +3 -0
 
+Raspberry Pi Broadcom BCM2835 thermal control
+
+Required properties:

This needs some more explanation of what this is intended to represent and do. For example, what services is this node (the driver instantiated by this node) expected to implement, and what firmware services is it expected to rely upon?