Skip to contentSkip to conversation

dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE)

PATCH New Vicente Olivert Riera 3 participants 9 messages Oct 20, 2015 – Oct 21, 2015

lore
Share & tools
lore

Vicente Olivert Riera

author
#0 lore raw

PATCH 1/3 dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE)

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/dhcpdump/dhcpdump.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
package/dhcpdump/dhcpdump.mk +2 -2
index 6b677a6..3584f4f 100644
@@ -16,8 +16,8 @@ DHCPDUMP_LIBS += `$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`
 endif
 
 define DHCPDUMP_BUILD_CMDS
-	$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) -D_GNU_SOURCE" \
-		LIBS="$(DHCPDUMP_LIBS)"
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) \
+		-D_GNU_SOURCE" LIBS="$(DHCPDUMP_LIBS)"
 endef
 
 define DHCPDUMP_INSTALL_TARGET_CMDS
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH 2/3 dhcpdump: add project URL

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/dhcpdump/Config.in |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
package/dhcpdump/Config.in +2 -0
index 1840e34..2368a46 100644
@@ -3,3 +3,5 @@ config BR2_PACKAGE_DHCPDUMP
 	select BR2_PACKAGE_LIBPCAP
 	help
 	  A tool for monitoring dhcp requests using tcpdump.
+
+	  http://www.mavetju.org/
Signature · 1 line
1.7.1
#3 lore raw

PATCH 2/3 dhcpdump: add project URL

In reply to Vicente Olivert Riera
Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/dhcpdump/Config.in |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
package/dhcpdump/Config.in +0 -0
index 1840e34..2368a46 100644

package/dhcpdump/Config.in config BR2_PACKAGE_DHCPDUMP · line 7

Quoted 5 lines
package/dhcpdump/Config.in +2 -0
@@ -3,3 +3,5 @@ config BR2_PACKAGE_DHCPDUMP
 	select BR2_PACKAGE_LIBPCAP
 	help
 	  A tool for monitoring dhcp requests using tcpdump.
+
+	  http://www.mavetju.org/

Actually, this is more like a personal page. I've changed it to
http://www.mavetju.org/unix/general.php instead.

Signature · 1 line
Bye, Peter Korsgaard
author
#4 lore raw

PATCH 3/3 dhcpdump: add a hash file

In reply to Vicente Olivert Riera
Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/dhcpdump/dhcpdump.hash |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
 create mode 100644 package/dhcpdump/dhcpdump.hash
package/dhcpdump/dhcpdump.hash new file +2 -0
new file mode 100644
index 0000000..36040c8
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 6d5eb9418162fb738bc56e4c1682ce7f7392dd96e568cc996e44c28de7f77190  dhcpdump-1.8.tar.gz
Signature · 1 line
1.7.1
#6 lore raw

PATCH 1/3 dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE)

In reply to Vicente Olivert Riera
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

Signed-off-by Vicente Olivert Riera <[email protected]>

A more detailed commit message would be good. Is this just for consistency or does it fix anything? (E.G. does the build system execute anything from HOST_DIR)?

Quoted 26 lines
---
 package/dhcpdump/dhcpdump.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
package/dhcpdump/dhcpdump.mk +2 -2
index 6b677a6..3584f4f 100644
@@ -16,8 +16,8 @@ DHCPDUMP_LIBS += `$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`
 endif
 
 define DHCPDUMP_BUILD_CMDS
-	$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) -D_GNU_SOURCE" \
-		LIBS="$(DHCPDUMP_LIBS)"
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) \
+		-D_GNU_SOURCE" LIBS="$(DHCPDUMP_LIBS)"
 endef
 
 define DHCPDUMP_INSTALL_TARGET_CMDS
Signature · 6 lines
1.7.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 1 line
Bye, Peter Korsgaard
author
#7 lore raw

PATCH 1/3 dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE)

Hello Peter,

Quoted 7 lines · Peter Korsgaard
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

Signed-off-by Vicente Olivert Riera <[email protected]>

A more detailed commit message would be good. Is this just for consistency or does it fix anything? (E.G. does the build system execute anything from HOST_DIR)?

No, it's just for consistency.

Regards,

Vincent.

Quoted 29 lines
Quoted 27 lines
---
 package/dhcpdump/dhcpdump.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
package/dhcpdump/dhcpdump.mk +2 -2
index 6b677a6..3584f4f 100644
@@ -16,8 +16,8 @@ DHCPDUMP_LIBS += `$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`
 endif
 
 define DHCPDUMP_BUILD_CMDS
-	$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) -D_GNU_SOURCE" \
-		LIBS="$(DHCPDUMP_LIBS)"
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS) \
+		-D_GNU_SOURCE" LIBS="$(DHCPDUMP_LIBS)"
 endef
 
 define DHCPDUMP_INSTALL_TARGET_CMDS
Signature · 6 lines
1.7.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
#8 lore raw

PATCH 1/3 dhcpdump: add $(TARGET_MAKE_ENV) before $(MAKE)

In reply to Vicente Olivert Riera

Dear Vicente Olivert Riera,

Quoted 4 lines · Vicente Olivert Riera
Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/dhcpdump/dhcpdump.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Applied after slightly tweaking the commit log following Peter's comment, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com