Skip to contentSkip to conversation

dts: keystone: Use new "ti,keystone-i2c" compatible

PATCH In review Alexander Sverdlin 5 participants 7 messages Sep 14, 2015 – Oct 21, 2015 1 message not in the archive

Subsystems (2)
Device tree bindings I2C subsystem host drivers
lore
Share & tools
lore

Alexander Sverdlin

author
#0 lore raw

PATCH v2 1/1 dts: keystone: Use new "ti,keystone-i2c" compatible

Now as "i2c-davinci" driver has special handling for Keystone it's time to switch the device tree to use new "compatible" property. Old one is left for backwards- compatibility.

Signed-off-by Alexander Sverdlin <[email protected]>

---

Changes in v2:
- As suggested by Mark Rutland, kept the old "compatible" for backwards- compatibility

 arch/arm/boot/dts/keystone.dtsi |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/keystone.dtsi +3 -3
index 72816d6..abd7455 100644
@@ -106,7 +106,7 @@
 		};
 
 		i2c0: i2c@2530000 {
-			compatible = "ti,davinci-i2c";
+			compatible = "ti,keystone-i2c", "ti,davinci-i2c";
 			reg = <0x02530000 0x400>;
 			clock-frequency = <100000>;
 			clocks = <&clki2c>;

@@ -116,7 +116,7 @@
 		};
 
 		i2c1: i2c@2530400 {
-			compatible = "ti,davinci-i2c";
+			compatible = "ti,keystone-i2c", "ti,davinci-i2c";
 			reg = <0x02530400 0x400>;
 			clock-frequency = <100000>;
 			clocks = <&clki2c>;

@@ -126,7 +126,7 @@
 		};
 
 		i2c2: i2c@2530800 {
-			compatible = "ti,davinci-i2c";
+			compatible = "ti,keystone-i2c", "ti,davinci-i2c";
 			reg = <0x02530800 0x400>;
 			clock-frequency = <100000>;
 			clocks = <&clki2c>;
#1 lore raw
Quoted 5 lines · Alexander Sverdlin

Now as "i2c-davinci" driver has special handling for Keystone it's time to switch the device tree to use new "compatible" property. Old one is left for backwards- compatibility.

Signed-off-by Alexander Sverdlin <[email protected]>

Shall I take this one or shall it go via the davinci tree?

#2 lore raw
Quoted 9 lines · Wolfram Sang
Quoted 5 lines · Alexander Sverdlin

Now as "i2c-davinci" driver has special handling for Keystone it's time to switch the device tree to use new "compatible" property. Old one is left for backwards- compatibility.

Signed-off-by Alexander Sverdlin <[email protected]>

Shall I take this one or shall it go via the davinci tree?

To: Sekhar

Signature · 2 lines
regards,
-grygorii
#3 lore raw
Quoted 11 lines · Grygorii Strashko
Quoted 10 lines · Wolfram Sang
Quoted 7 lines · Alexander Sverdlin

Now as "i2c-davinci" driver has special handling for Keystone it's time to switch
the device tree to use new "compatible" property. Old one is left for backwards-
compatibility.

Signed-off-by Alexander Sverdlin <[email protected]>

Shall I take this one or shall it go via the davinci tree?

I don't have the patch in my mailbox now. But as I remember this is a driver only patch and should go via i2c tree.

Thanks,
Sekhar

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#5 lore raw

Hi!

Quoted 10 lines · EXT Sekhar Nori
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines

Now as "i2c-davinci" driver has special handling for Keystone it's

Quoted 8 lines
Quoted 6 lines
Quoted 6 lines

time to switch
the device tree to use new "compatible" property. Old one is left for backwards-
compatibility.

Signed-off-by Alexander Sverdlin <[email protected]>

Shall I take this one or shall it go via the davinci tree?

I don't have the patch in my mailbox now. But as I remember this is a

You can review it here:
http://patchwork.ozlabs.org/patch/517321/

Quoted 1 line

driver only patch and should go via i2c tree.

It's a DT change, because we agreed (with Grygorii) that new "compatible" is more future proof.

Signature · 7 lines
Best regards,
Alexander Sverdlin.
Sent from my pdp-11
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#6 lore raw
In reply to Alexander Sverdlin
Quoted 6 lines · Alexander Sverdlin

Now as "i2c-davinci" driver has special handling for Keystone it's time to switch the device tree to use new "compatible" property. Old one is left for backwards- compatibility.

Signed-off-by Alexander Sverdlin <[email protected]>

---

To: Santosh
Cc: Murali, Sekhar

Seems this patch is Keystone 2 specific.

Quoted 40 lines

Changes in v2:
- As suggested by Mark Rutland, kept the old "compatible" for backwards- compatibility

  arch/arm/boot/dts/keystone.dtsi |    6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/keystone.dtsi +3 -3
index 72816d6..abd7455 100644
@@ -106,7 +106,7 @@
  		};
 
  		i2c0: i2c@2530000 {
-			compatible = "ti,davinci-i2c";
+			compatible = "ti,keystone-i2c", "ti,davinci-i2c";
  			reg = <0x02530000 0x400>;
  			clock-frequency = <100000>;
  			clocks = <&clki2c>;

@@ -116,7 +116,7 @@
  		};
 
  		i2c1: i2c@2530400 {
-			compatible = "ti,davinci-i2c";
+			compatible = "ti,keystone-i2c", "ti,davinci-i2c";
  			reg = <0x02530400 0x400>;
  			clock-frequency = <100000>;
  			clocks = <&clki2c>;

@@ -126,7 +126,7 @@
  		};
 
  		i2c2: i2c@2530800 {
-			compatible = "ti,davinci-i2c";
+			compatible = "ti,keystone-i2c", "ti,davinci-i2c";
  			reg = <0x02530800 0x400>;
  			clock-frequency = <100000>;
  			clocks = <&clki2c>;
Signature · 2 lines
regards,
-grygorii
#7 lore raw
Quoted 10 lines · Grygorii Strashko
Quoted 8 lines · Alexander Sverdlin

Now as "i2c-davinci" driver has special handling for Keystone it's time to switch
the device tree to use new "compatible" property. Old one is left for backwards-
compatibility.

Signed-off-by Alexander Sverdlin <[email protected]>

---

Will pick it up. Thanks !!

Regards,
Santosh