Skip to contentSkip to conversation

mmc: dw_mmc: NULL dereference in error message

PATCH In review Dan Carpenter 2 participants 2 messages Oct 22, 2015 – Oct 23, 2015

Subsystems (3)
Kernel janitors MMC, SD and SDIO Synopsys DesignWare MMC/SD/SDIO driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 mmc: dw_mmc: NULL dereference in error message

The "host->dms->ch" pointer is NULL here so we can't use it to print the error message.

Signed-off-by Dan Carpenter <[email protected]>
drivers/mmc/host/dw_mmc.c +1 -3
index 6e600e8..f877b2c 100644
@@ -752,9 +752,7 @@ static int dw_mci_edmac_init(struct dw_mci *host)
 
 	host->dms->ch = dma_request_slave_channel(host->dev, "rx-tx");
 	if (!host->dms->ch) {
-		dev_err(host->dev,
-			"Failed to get external DMA channel %d\n",
-			host->dms->ch->chan_id);
+		dev_err(host->dev, "Failed to get external DMA channel.\n");
 		kfree(host->dms);
 		host->dms = NULL;
 		return -ENXIO;
maintainer
#1 lore raw

Hi,

Thanks for pointing out.
I will pick this patch at my repository.

Best Regards,
Jaehoon Chung

Quoted 21 lines · Dan Carpenter

The "host->dms->ch" pointer is NULL here so we can't use it to print the error message.

Signed-off-by Dan Carpenter <[email protected]>
drivers/mmc/host/dw_mmc.c +1 -3
index 6e600e8..f877b2c 100644
@@ -752,9 +752,7 @@ static int dw_mci_edmac_init(struct dw_mci *host)
 
 	host->dms->ch = dma_request_slave_channel(host->dev, "rx-tx");
 	if (!host->dms->ch) {
-		dev_err(host->dev,
-			"Failed to get external DMA channel %d\n",
-			host->dms->ch->chan_id);
+		dev_err(host->dev, "Failed to get external DMA channel.\n");
 		kfree(host->dms);
 		host->dms = NULL;
 		return -ENXIO;