Skip to contentSkip to conversation

smdk2410: clean up checkpatch issues

PATCH New Minkyu Kang 1 participant 2 messages Oct 23, 2015 – Nov 2, 2015

lore
Share & tools
lore

Minkyu Kang

author
#0 lore raw

PATCH 3/5 smdk2410: clean up checkpatch issues

This patch will fix these checkpatch issues.

ERROR: spaces required around that '==' (ctx:VxV)
+#if FCLK_SPEED==0 /* Fout = 203MHz, Fin = 12MHz for Audio */

ERROR: spaces required around that '==' (ctx:VxV)
+#elif FCLK_SPEED==1 /* Fout = 202.8MHz */

ERROR: spaces required around that '==' (ctx:VxV)
+#if USB_CLOCK==0

ERROR: spaces required around that '==' (ctx:VxV)
+#elif USB_CLOCK==1

CHECK: spaces required around that ':' (ctx:VxV)
+ "bne 1b":"=r" (loops):"0" (loops));

Signed-off-by Minkyu Kang <[email protected]>
---
 board/samsung/smdk2410/smdk2410.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
board/samsung/smdk2410/smdk2410.c +5 -5
index b75a0e3..6e678c7 100644
@@ -18,11 +18,11 @@ DECLARE_GLOBAL_DATA_PTR;
 
 #define FCLK_SPEED 1
 
-#if FCLK_SPEED==0		/* Fout = 203MHz, Fin = 12MHz for Audio */
+#if (FCLK_SPEED == 0)		/* Fout = 203MHz, Fin = 12MHz for Audio */
 #define M_MDIV	0xC3
 #define M_PDIV	0x4
 #define M_SDIV	0x1
-#elif FCLK_SPEED==1		/* Fout = 202.8MHz */
+#elif (FCLK_SPEED == 1)		/* Fout = 202.8MHz */
 #define M_MDIV	0xA1
 #define M_PDIV	0x3
 #define M_SDIV	0x1

@@ -30,11 +30,11 @@ DECLARE_GLOBAL_DATA_PTR;
 
 #define USB_CLOCK 1
 
-#if USB_CLOCK==0
+#if (USB_CLOCK == 0)
 #define U_M_MDIV	0xA1
 #define U_M_PDIV	0x3
 #define U_M_SDIV	0x1
-#elif USB_CLOCK==1
+#elif (USB_CLOCK == 1)
 #define U_M_MDIV	0x48
 #define U_M_PDIV	0x3
 #define U_M_SDIV	0x2

@@ -44,7 +44,7 @@ static inline void pll_delay(unsigned long loops)
 {
 	__asm__ volatile ("1:\n"
 	  "subs %0, %1, #1\n"
-	  "bne 1b":"=r" (loops):"0" (loops));
+	  "bne 1b" : "=r" (loops) : "0" (loops));
 }
 
 /*
Signature · 5 lines
1.7.9.5

-- 
Thanks,
Minkyu Kang.
author
#1 lore raw

PATCH 3/5 smdk2410: clean up checkpatch issues

Quoted 17 lines · Minkyu Kang

This patch will fix these checkpatch issues.

ERROR: spaces required around that '==' (ctx:VxV)
+#if FCLK_SPEED==0 /* Fout = 203MHz, Fin = 12MHz for Audio */

ERROR: spaces required around that '==' (ctx:VxV)
+#elif FCLK_SPEED==1 /* Fout = 202.8MHz */

ERROR: spaces required around that '==' (ctx:VxV)
+#if USB_CLOCK==0

ERROR: spaces required around that '==' (ctx:VxV)
+#elif USB_CLOCK==1

CHECK: spaces required around that ':' (ctx:VxV)

(quoted diff) +1 -0
+	  "bne 1b":"=r" (loops):"0" (loops));
Quoted 5 lines
Signed-off-by Minkyu Kang <[email protected]>
---
 board/samsung/smdk2410/smdk2410.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

applied to u-boot-samsung.

Thanks,
Minkyu Kang.