Skip to contentSkip to conversation

i2c: i801: Add support for Intel Broxton

PATCH Applied Jarkko Nikula 3 participants 4 messages Oct 22, 2015 – Oct 26, 2015

Subsystems (2)
I2C subsystem host drivers I2C/smbus controller drivers for pc
lore
Share & tools
lore

Jarkko Nikula

author
#0 lore raw

PATCH 1/1 i2c: i801: Add support for Intel Broxton

This patch adds the SMBUS PCI ID of Intel Broxton.

Signed-off-by Jarkko Nikula <[email protected]>

---
This goes on top of Mika's "[PATCH] i2c: i801: Add support for Intel DNV":
http://marc.info/?l=linux-i2c&m=144474010421111&w=2

---
 drivers/i2c/busses/i2c-i801.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/i2c/busses/i2c-i801.c +3 -0
index 47c2ddf76264..d8219bc2ac4e 100644
@@ -61,6 +61,7 @@
  * Sunrise Point-H (PCH) 	0xa123  32	hard	yes	yes	yes
  * Sunrise Point-LP (PCH)	0x9d23	32	hard	yes	yes	yes
  * DNV (SOC)			0x19df	32	hard	yes	yes	yes
+ * Broxton (SOC)		0x5ad4	32	hard	yes	yes	yes
  *
  * Features supported by this driver:
  * Software PEC				no

@@ -204,6 +205,7 @@
 #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS	0xa123
 #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS	0x9d23
 #define PCI_DEVICE_ID_INTEL_DNV_SMBUS			0x19df
+#define PCI_DEVICE_ID_INTEL_BROXTON_SMBUS		0x5ad4
 
 struct i801_mux_config {
 	char *gpio_chip;

@@ -866,6 +868,7 @@ static const struct pci_device_id i801_ids[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMBUS) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BROXTON_SMBUS) },
 	{ 0, }
 };
Signature · 1 line
2.6.1
#2 lore raw
In reply to Jarkko Nikula

Hi Jarkko,

Quoted 23 lines · Jarkko Nikula

This patch adds the SMBUS PCI ID of Intel Broxton.

Signed-off-by Jarkko Nikula <[email protected]>

---
This goes on top of Mika's "[PATCH] i2c: i801: Add support for Intel DNV":
http://marc.info/?l=linux-i2c&m=144474010421111&w=2

---
 drivers/i2c/busses/i2c-i801.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/i2c/busses/i2c-i801.c +1 -0
index 47c2ddf76264..d8219bc2ac4e 100644
@@ -61,6 +61,7 @@
  * Sunrise Point-H (PCH) 	0xa123  32	hard	yes	yes	yes
  * Sunrise Point-LP (PCH)	0x9d23	32	hard	yes	yes	yes
  * DNV (SOC)			0x19df	32	hard	yes	yes	yes
+ * Broxton (SOC)		0x5ad4	32	hard	yes	yes	yes
  *
  * Features supported by this driver:
  * Software PEC				no

drivers/i2c/busses/i2c-i801.c line 208

Quoted 4 lines
drivers/i2c/busses/i2c-i801.c +1 -0
@@ -204,6 +205,7 @@
 #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS	0xa123
 #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS	0x9d23
 #define PCI_DEVICE_ID_INTEL_DNV_SMBUS			0x19df
+#define PCI_DEVICE_ID_INTEL_BROXTON_SMBUS		0x5ad4

Can you please get this added to pci.ids?

http://pci-ids.ucw.cz/read/PC/8086

drivers/i2c/busses/i2c-i801.c static const struct pci_device_id i801_ids[] = { · line 874

Quoted 10 lines
drivers/i2c/busses/i2c-i801.c +1 -0
 struct i801_mux_config {
 	char *gpio_chip;

@@ -866,6 +868,7 @@ static const struct pci_device_id i801_ids[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMBUS) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BROXTON_SMBUS) },
 	{ 0, }
 };

Does this one not have FEATURE_TCO as DNV does? If it does, you'll need to add a line for it in the switch block in i801_probe().

Please also update Documentation/i2c/busses/i2c-i801 and drivers/i2c/busses/Kconfig.

Thanks,

Signature · 2 lines
Jean Delvare
SUSE L3 Support
author
#3 lore raw

Hi

Quoted 10 lines · Jean Delvare

drivers/i2c/busses/i2c-i801.c line 208

Quoted 5 lines
drivers/i2c/busses/i2c-i801.c +1 -0
@@ -204,6 +205,7 @@
  #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS	0xa123
  #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS	0x9d23
  #define PCI_DEVICE_ID_INTEL_DNV_SMBUS			0x19df
+#define PCI_DEVICE_ID_INTEL_BROXTON_SMBUS		0x5ad4

Can you please get this added to pci.ids?

http://pci-ids.ucw.cz/read/PC/8086

We seems to miss quite many other recent IDs too. I'll take this forward.

Quoted 5 lines
Quoted 5 lines
drivers/i2c/busses/i2c-i801.c +0 -0
  struct i801_mux_config {
  	char *gpio_chip;

@@ -866,6 +868,7 @@ static const struct pci_device_id i801_ids[] = {
  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS) },
  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS) },
Quoted 9 lines

drivers/i2c/busses/i2c-i801.c static const struct pci_device_id i801_ids[] = { · line 874

Quoted 5 lines
drivers/i2c/busses/i2c-i801.c +1 -0
  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_DNV_SMBUS) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_BROXTON_SMBUS) },
  	{ 0, }
  };

Does this one not have FEATURE_TCO as DNV does? If it does, you'll need to add a line for it in the switch block in i801_probe().

No, it's specific to sunrisepoint and dnv only at the moment.

Quoted 3 lines

Please also update Documentation/i2c/busses/i2c-i801 and drivers/i2c/busses/Kconfig.

Ok, will do.

Signature · 1 line
Jarkko