Skip to contentSkip to conversation

Staging: android: uapi: fixed comment block coding style error in ion.h

PATCH Superseded Dzonatans Melgalvis 2 participants 2 messages Oct 25, 2015 – Oct 26, 2015 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: android: uapi: fixed comment block coding style error in ion.h

Fixed checkpatch.pl warning about comment block coding style.

---
 drivers/staging/android/uapi/ion.h | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
drivers/staging/android/uapi/ion.h +8 -6
index 68a14b4..11df59f 100644
@@ -56,13 +56,15 @@ enum ion_heap_type {
  * allocation flags - the lower 16 bits are used by core ion, the upper 16
  * bits are reserved for use by the heaps themselves.
  */
-#define ION_FLAG_CACHED 1		/* mappings of this buffer should be
-					   cached, ion will do cache
-					   maintenance when the buffer is
-					   mapped for dma */
+#define ION_FLAG_CACHED 1		/*  mappings of this buffer should be
+					 *  cached, ion will do cache
+					 *  maintenance when the buffer is
+					 *  mapped for dma
+					 */
 #define ION_FLAG_CACHED_NEEDS_SYNC 2	/* mappings of this buffer will created
-					   at mmap time, if this is set
-					   caches must be managed manually */
+					 *  at mmap time, if this is set
+					 *  caches must be managed manually
+					 */
 
 /**
  * DOC: Ion Userspace API
Signature · 1 line
2.1.4
#1 lore raw
Quoted 2 lines · Dzonatans Melgalvis

Fixed checkpatch.pl warning about comment block coding style.

The right aligned comments aren't great style.
How about moving the comments (with the correct style) right above the macro they are describing.

Quoted 32 lines
---
  drivers/staging/android/uapi/ion.h | 14 ++++++++------
  1 file changed, 8 insertions(+), 6 deletions(-)
drivers/staging/android/uapi/ion.h +8 -6
index 68a14b4..11df59f 100644
@@ -56,13 +56,15 @@ enum ion_heap_type {
   * allocation flags - the lower 16 bits are used by core ion, the upper 16
   * bits are reserved for use by the heaps themselves.
   */
-#define ION_FLAG_CACHED 1		/* mappings of this buffer should be
-					   cached, ion will do cache
-					   maintenance when the buffer is
-					   mapped for dma */
+#define ION_FLAG_CACHED 1		/*  mappings of this buffer should be
+					 *  cached, ion will do cache
+					 *  maintenance when the buffer is
+					 *  mapped for dma
+					 */
  #define ION_FLAG_CACHED_NEEDS_SYNC 2	/* mappings of this buffer will created
-					   at mmap time, if this is set
-					   caches must be managed manually */
+					 *  at mmap time, if this is set
+					 *  caches must be managed manually
+					 */
 
  /**
   * DOC: Ion Userspace API