Skip to contentSkip to conversation

rfkill: new package

PATCH Superseded Viacheslav Volkov 2 participants 3 messages Oct 27, 2015

v2 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 rfkill: new package

Add rfkill package.

---
 package/Config.in          |  1 +
 package/rfkill/Config.in   |  7 +++++++
 package/rfkill/rfkill.hash |  2 ++
 package/rfkill/rfkill.mk   | 20 ++++++++++++++++++++
 4 files changed, 30 insertions(+)
 create mode 100644 package/rfkill/Config.in
 create mode 100644 package/rfkill/rfkill.hash
 create mode 100644 package/rfkill/rfkill.mk
package/Config.in +1 -0
index 10ff94e..9933514 100644
@@ -403,6 +403,7 @@ endif
 	source "package/pps-tools/Config.in"
 	source "package/pulseview/Config.in"
 	source "package/read-edid/Config.in"
+	source "package/rfkill/Config.in"
 	source "package/rng-tools/Config.in"
 	source "package/rpi-userland/Config.in"
 	source "package/rtl8188eu/Config.in"
package/rfkill/Config.in new file +7 -0
new file mode 100644
index 0000000..b7a676e
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_RFKILL
+	bool "rfkill"
+	help
+	  rfkill is a small userspace tool to query the state of the rfkill
+	  switches.
+
+	  https://wireless.wiki.kernel.org/en/users/documentation/rfkill
package/rfkill/rfkill.hash new file +2 -0
new file mode 100644
index 0000000..21be0a2
@@ -0,0 +1,2 @@
+# From: https://www.kernel.org/pub/software/network/rfkill/sha256sums.asc
+sha256	e0ae3004215e39a6c5c36e0726558740728d16f67ebdb8bea621250f6091d86a  rfkill-0.5.tar.xz
package/rfkill/rfkill.mk new file +20 -0
new file mode 100644
index 0000000..b377c03
@@ -0,0 +1,20 @@
+################################################################################
+#
+# rfkill
+#
+################################################################################
+
+RFKILL_VERSION = 0.5
+RFKILL_SOURCE = rfkill-$(RFKILL_VERSION).tar.xz
+RFKILL_SITE = https://www.kernel.org/pub/software/network/rfkill
+
+define RFKILL_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) \
+		VERSION_SUFFIX="-br"
+endef
+
+define RFKILL_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 755 $(@D)/rfkill $(TARGET_DIR)/usr/bin/rfkill
+endef
+
+$(eval $(generic-package))
Signature · 1 line
2.6.1
#1 lore raw

PATCH v2 1/1 rfkill: new package

Dear Viacheslav Volkov,

your patch now looks much better. I have some comments about minor details.

The first one, you didn't marked your previous patch as superseded in Patchwork.

Quoted 4 lines · Viacheslav Volkov

Add rfkill package.

---

I was expecting a changelog here. Please read:

http://buildroot.org/manual.html#submitting-patches

Scroll down until "21.5.2. Patch revision changelog".

Quoted 27 lines
 package/Config.in          |  1 +
 package/rfkill/Config.in   |  7 +++++++
 package/rfkill/rfkill.hash |  2 ++
 package/rfkill/rfkill.mk   | 20 ++++++++++++++++++++
 4 files changed, 30 insertions(+)
 create mode 100644 package/rfkill/Config.in
 create mode 100644 package/rfkill/rfkill.hash
 create mode 100644 package/rfkill/rfkill.mk
package/Config.in +1 -0
index 10ff94e..9933514 100644
@@ -403,6 +403,7 @@ endif
 	source "package/pps-tools/Config.in"
 	source "package/pulseview/Config.in"
 	source "package/read-edid/Config.in"
+	source "package/rfkill/Config.in"
 	source "package/rng-tools/Config.in"
 	source "package/rpi-userland/Config.in"
 	source "package/rtl8188eu/Config.in"
package/rfkill/Config.in new file +0 -0
new file mode 100644
index 0000000..b7a676e

package/rfkill/Config.in line 4

Quoted 4 lines
package/rfkill/Config.in new file +4 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_RFKILL
+	bool "rfkill"
+	help
+	  rfkill is a small userspace tool to query the state of the rfkill

That line is not wrapped to 72 characters length if we consider the tab as 8 characters wide. The trailing "rfkill" word should be placed in the next line.

package/rfkill/Config.in line 7

Quoted 3 lines
package/rfkill/Config.in new file +3 -0
+	  switches.
+
+	  https://wireless.wiki.kernel.org/en/users/documentation/rfkill

Add a trailing slash (/) to that URL.

Regards,

Vincent.

#2 lore raw

PATCH v2 1/1 rfkill: new package

Dear Viacheslav Volkov,

Quoted 3 lines · Vicente Olivert Riera

package/rfkill/Config.in line 7

Quoted 1 line
package/rfkill/Config.in new file +1 -0
+	  https://wireless.wiki.kernel.org/en/users/documentation/rfkill

Add a trailing slash (/) to that URL.

Ignore that one.

Sorry,

Vincent.