Skip to contentSkip to conversation

uclibc: get rid of ARC's uClibc fork

PATCH New Alexey Brodkin 5 participants 8 messages Oct 27, 2015

lore
Share & tools
lore

Alexey Brodkin

author
#0 lore raw

PATCH 1/1 uclibc: get rid of ARC's uClibc fork

For quite some time all ARC changes have been pushed upstream. So both uClibc master branch and uClibc-ng have full ARC support including the most recent changes.

I.e. finally we have reached the point when there's no need in Synopsys fork of uClibc on GitHub and it will soon be obsoleted and removed at some pint of time.

Now since vanilla uClibc hasn't seen any releases for many years we cannot really use it for ARC. Fortunately there exists uClibc-ng and Waldemar cuts releases regularly - that works perfectly fine for us.

That patch removes all mentions of ARC's uClibc which in turn makes uClibc-ng default libc for ARC.

Cc Waldemar Brodkorb <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Signed-off-by Alexey Brodkin <[email protected]>
---
 package/uclibc/Config.in                           |   9 -
 ...nptl-remove-duplicate-vfork-in-libpthread.patch | 722 ---------------------
 ...e-memset-so-it-could-be-used-without-doub.patch |  81 ---
 package/uclibc/uclibc.mk                           |   3 -
 4 files changed, 815 deletions(-)
 delete mode 100644 package/uclibc/arc-2015.06/0001-nptl-remove-duplicate-vfork-in-libpthread.patch
 delete mode 100644 package/uclibc/arc-2015.06/0002-ARCv2-update-memset-so-it-could-be-used-without-doub.patch
package/uclibc/Config.in +0 -9
index ff6dffd..21d8ddc 100644
@@ -29,13 +29,6 @@ choice
 		select BR2_UCLIBC_VERSION_SUPPORTS_NPTL if !BR2_x86_i386
 		depends on !(BR2_arc || BR2_mips64 || BR2_mips64el || BR2_xtensa)
 
-	config BR2_UCLIBC_VERSION_ARC_GIT
-		bool "uClibc Git ARC"
-		select BR2_UCLIBC_VERSION_SUPPORTS_LINUXTHREADS
-		select BR2_UCLIBC_VERSION_SUPPORTS_LINUXTHREADS_OLD
-		select BR2_UCLIBC_VERSION_SUPPORTS_NPTL
-		depends on BR2_arc
-
 	config BR2_UCLIBC_VERSION_NG
 		bool "uClibc-ng"
 		select BR2_UCLIBC_VERSION_SUPPORTS_LINUXTHREADS if BR2_m68k

@@ -64,7 +57,6 @@ config BR2_USE_UCLIBC_SNAPSHOT
 config BR2_UCLIBC_VERSION_STRING
 	string
 	default "0.9.33.2"	if BR2_UCLIBC_VERSION_0_9_33
-	default "arc-2015.06" if BR2_UCLIBC_VERSION_ARC_GIT
 	default "1.0.8"		if BR2_UCLIBC_VERSION_NG
 	default BR2_USE_UCLIBC_SNAPSHOT	if BR2_UCLIBC_VERSION_SNAPSHOT
 

@@ -72,7 +64,6 @@ config BR2_UCLIBC_CONFIG
 	string "uClibc configuration file to use?"
 	default "package/uclibc/uClibc-0.9.33.config" if BR2_UCLIBC_VERSION_0_9_33
 	default "package/uclibc/uClibc-ng.config" if BR2_UCLIBC_VERSION_NG
-	default "package/uclibc/uClibc-snapshot.config" if BR2_UCLIBC_VERSION_ARC_GIT
 	default "package/uclibc/uClibc-snapshot.config" if BR2_UCLIBC_VERSION_SNAPSHOT
 	help
 	  Some people may wish to use their own modified uClibc configuration
package/uclibc/arc-2015.06/0001-nptl-remove-duplicate-vfork-in-libpthread.patch deleted +0 -722

722 lines not on this page · raw message

package/uclibc/arc-2015.06/0002-ARCv2-update-memset-so-it-could-be-used-without-doub.patch deleted +0 -81

81 lines not on this page · raw message

package/uclibc/uclibc.mk +0 -3
index 7ff98b0..c62a40f 100644
@@ -15,9 +15,6 @@ BR_NO_CHECK_HASH_FOR += $(UCLIBC_SOURCE)
 else ifeq ($(BR2_UCLIBC_VERSION_NG),y)
 UCLIBC_SITE = http://downloads.uclibc-ng.org/releases/$(UCLIBC_VERSION)
 UCLIBC_SOURCE = uClibc-ng-$(UCLIBC_VERSION).tar.xz
-else ifeq ($(BR2_UCLIBC_VERSION_ARC_GIT),y)
-UCLIBC_SITE = $(call github,foss-for-synopsys-dwc-arc-processors,uClibc,$(UCLIBC_VERSION))
-UCLIBC_SOURCE = uClibc-$(UCLIBC_VERSION).tar.gz
 else
 UCLIBC_SITE = http://www.uclibc.org/downloads
 UCLIBC_SOURCE = uClibc-$(UCLIBC_VERSION).tar.xz
Signature · 1 line
2.4.3
#1 lore raw

PATCH 1/1 uclibc: get rid of ARC's uClibc fork

Quoted 2 lines · Alexey Brodkin

For quite some time all ARC changes have been pushed upstream. So both uClibc master branch

In that case, perhaps the snapshot version should be enabled for ARC?

Quoted 11 lines

and uClibc-ng have full ARC support
including the most recent changes.

I.e. finally we have reached the point when there's no need in Synopsys fork of uClibc on GitHub and it will soon be obsoleted and removed at some pint of time.

Now since vanilla uClibc hasn't seen any releases for many years we cannot really use it for ARC. Fortunately there exists uClibc-ng and Waldemar cuts releases regularly - that works perfectly fine for us.

Quoted 6 lines

That patch removes all mentions of ARC's uClibc which in turn makes uClibc-ng default libc for ARC.

Cc Waldemar Brodkorb <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Signed-off-by Alexey Brodkin <[email protected]>

... but that can be done independently of this patch, so:

Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

[snip]

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#2 lore raw

PATCH 1/1 uclibc: get rid of ARC's uClibc fork

Arnout,

Quoted 5 lines · Arnout Vandecappelle
Quoted 2 lines · Alexey Brodkin

For quite some time all ARC changes have been pushed upstream. So both uClibc master branch

In that case, perhaps the snapshot version should be enabled for ARC?

To be honest, I am wondering if this snapshot thing is really useful in any way. Is anyone really using this ? Why do we have this for uClibc and not for any other package ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 uclibc: get rid of ARC's uClibc fork

Quoted 4 lines · Thomas Petazzoni

Arnout,

Quoted 1 line · Arnout Vandecappelle

On 27-10-15 16:16, Alexey Brodkin wrote:

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

For quite some time all ARC changes have been pushed upstream. So both uClibc master branch

In that case, perhaps the snapshot version should be enabled for ARC?

To be honest, I am wondering if this snapshot thing is really useful in any way. Is anyone really using this ? Why do we have this for uClibc and not for any other package ?

I guess because buildroot was started as a build system for uClibc... The
initial version of buildroot (ffde94bd2) even only supported snapshot.

Now that there are actual releases of uClibc, I see little reason to support
snapshots. And you anyway can still use _OVERRIDE_SRCDIR.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#4 lore raw

PATCH 1/1 uclibc: get rid of ARC's uClibc fork

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Hi,

Quoted 11 lines
Quoted 5 lines
Quoted 1 line

In that case, perhaps the snapshot version should be enabled for ARC?

To be honest, I am wondering if this snapshot thing is really useful in any way. Is anyone really using this ? Why do we have this for uClibc and not for any other package ?

I guess because buildroot was started as a build system for uClibc... The
initial version of buildroot (ffde94bd2) even only supported snapshot.

Now that there are actual releases of uClibc, I see little reason to support
snapshots. And you anyway can still use _OVERRIDE_SRCDIR.

I agree, we have also dropped snapshot support for busybox and gcc.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 uclibc: get rid of ARC's uClibc fork

In reply to Alexey Brodkin

Hi,
Alexey Brodkin wrote,

Quoted 8 lines

For quite some time all ARC changes have been pushed upstream. So both uClibc master branch and uClibc-ng have full ARC support including the most recent changes.

I.e. finally we have reached the point when there's no need in Synopsys fork of uClibc on GitHub and it will soon be obsoleted and removed at some pint of time.

Quoted 6 lines

Now since vanilla uClibc hasn't seen any releases for many years we cannot really use it for ARC. Fortunately there exists uClibc-ng and Waldemar cuts releases regularly - that works perfectly fine for us.

That patch removes all mentions of ARC's uClibc which in turn makes uClibc-ng default libc for ARC.

I vote for it :=)

Acked-by Waldemar Brodkorb <[email protected]>

best regards
Waldemar

#6 lore raw

PATCH 1/1 uclibc: get rid of ARC's uClibc fork

In reply to Alexey Brodkin
Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Alexey" == Alexey Brodkin <[email protected]> writes:

For quite some time all ARC changes have been pushed upstream. So both uClibc master branch and uClibc-ng have full ARC support including the most recent changes.

I.e. finally we have reached the point when there's no need in Synopsys fork of uClibc on GitHub and it will soon be obsoleted and removed at some pint of time.

Now since vanilla uClibc hasn't seen any releases for many years we cannot really use it for ARC. Fortunately there exists uClibc-ng and Waldemar cuts releases regularly - that works perfectly fine for us.

Quoted 6 lines

That patch removes all mentions of ARC's uClibc which in turn makes uClibc-ng default libc for ARC.

Cc Waldemar Brodkorb <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Signed-off-by Alexey Brodkin <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH 1/1 uclibc: get rid of ARC's uClibc fork

In reply to Alexey Brodkin

Dear Alexey Brodkin,

Quoted 12 lines · Alexey Brodkin

For quite some time all ARC changes have been pushed upstream. So both uClibc master branch and uClibc-ng have full ARC support including the most recent changes.

I.e. finally we have reached the point when there's no need in Synopsys fork of uClibc on GitHub and it will soon be obsoleted and removed at some pint of time.

Now since vanilla uClibc hasn't seen any releases for many years we cannot really use it for ARC. Fortunately there exists uClibc-ng and Waldemar cuts releases regularly - that works perfectly fine for us.

Quoted 6 lines

That patch removes all mentions of ARC's uClibc which in turn makes uClibc-ng default libc for ARC.

Cc Waldemar Brodkorb <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Signed-off-by Alexey Brodkin <[email protected]>

Excellent, thanks for doing this! And thanks to Waldemar for bringing back some sanity to the uClibc world :)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com