Skip to contentSkip to conversation

Makefile: Remove 'quiet' variable

PATCH New Cédric Marie 4 participants 4 messages Oct 8, 2015 – Oct 28, 2015 Kbuild

lore
Share & tools
lore

Cédric Marie

author
#0 lore raw

PATCH v2 1/1 Makefile: Remove 'quiet' variable

'quiet' variable is set and exported, but it is not used. We can safely remove it.

This variable is inherited from the Makefile of the Linux kernel, and is not used in Buildroot.

In support/scripts/mkmakefile, 'quiet' value is checked, but the test is always true ('quiet' is never set to silent_), so the test can be removed as well.

Signed-off-by C?dric Marie <[email protected]>

---
Changes v1 -> v2:
- KBUILD_VERBOSE must not be removed, it is used for packages based on Kbuild.

Title of PATCH v1 was:
Makefile: Remove KBUILD_VERBOSE and quiet

In order to describe how the verbosity level is managed in different infrastructures, comments will be added in Makefile (suggested by Arnout). It will be provided in a separate patch.

Arnout also suggested not to export 'Q', which seems to be Buildroot internal. This will also be provided in a separate patch, if confirmed.

---
 Makefile                   | 4 +---
 support/scripts/mkmakefile | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)
Makefile +1 -3
index 181d446..470ea65 100644
@@ -226,14 +226,12 @@ ifndef KBUILD_VERBOSE
 endif
 
 ifeq ($(KBUILD_VERBOSE),1)
-  quiet =
   Q =
 ifndef VERBOSE
   VERBOSE = 1
 endif
 export VERBOSE
 else
-  quiet = quiet_
   Q = @
 endif
 

@@ -245,7 +243,7 @@ SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
 # kconfig uses CONFIG_SHELL
 CONFIG_SHELL := $(SHELL)
 
-export SHELL CONFIG_SHELL quiet Q KBUILD_VERBOSE
+export SHELL CONFIG_SHELL Q KBUILD_VERBOSE
 
 ifndef HOSTAR
 HOSTAR := ar
support/scripts/mkmakefile +1 -3
index 833be6a..37162a3 100755
@@ -15,9 +15,7 @@ if test -e $2/Makefile && ! grep -q Automatically $2/Makefile
 then
 	exit 0
 fi
-if [ "${quiet}" != "silent_" ]; then
-	echo "  GEN     $2/Makefile"
-fi
+echo "  GEN     $2/Makefile"
 
 cat << EOF > $2/Makefile
 # Automatically generated by $0: don't edit
Signature · 1 line
2.6.1
#1 lore raw

PATCH v2 1/1 Makefile: Remove 'quiet' variable

Quoted 11 lines · C?dric Marie

'quiet' variable is set and exported, but it is not used. We can safely remove it.

This variable is inherited from the Makefile of the Linux kernel, and is not used in Buildroot.

In support/scripts/mkmakefile, 'quiet' value is checked, but the test is always true ('quiet' is never set to silent_), so the test can be removed as well.

Signed-off-by C?dric Marie <[email protected]>
Reviewed-by "James Knight" <[email protected]>
#2 lore raw

PATCH v2 1/1 Makefile: Remove 'quiet' variable

In reply to Cédric Marie
Quoted 11 lines · C?dric Marie

'quiet' variable is set and exported, but it is not used. We can safely remove it.

This variable is inherited from the Makefile of the Linux kernel, and is not used in Buildroot.

In support/scripts/mkmakefile, 'quiet' value is checked, but the test is always true ('quiet' is never set to silent_), so the test can be removed as well.

Signed-off-by C?dric Marie <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 64 lines

---
Changes v1 -> v2:
- KBUILD_VERBOSE must not be removed, it is used for packages based on Kbuild.

Title of PATCH v1 was:
Makefile: Remove KBUILD_VERBOSE and quiet

In order to describe how the verbosity level is managed in different infrastructures, comments will be added in Makefile (suggested by Arnout). It will be provided in a separate patch.

Arnout also suggested not to export 'Q', which seems to be Buildroot internal. This will also be provided in a separate patch, if confirmed.

---
 Makefile                   | 4 +---
 support/scripts/mkmakefile | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)
Makefile +1 -3
index 181d446..470ea65 100644
@@ -226,14 +226,12 @@ ifndef KBUILD_VERBOSE
 endif
 
 ifeq ($(KBUILD_VERBOSE),1)
-  quiet =
   Q =
 ifndef VERBOSE
   VERBOSE = 1
 endif
 export VERBOSE
 else
-  quiet = quiet_
   Q = @
 endif
 

@@ -245,7 +243,7 @@ SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \
 # kconfig uses CONFIG_SHELL
 CONFIG_SHELL := $(SHELL)
 
-export SHELL CONFIG_SHELL quiet Q KBUILD_VERBOSE
+export SHELL CONFIG_SHELL Q KBUILD_VERBOSE
 
 ifndef HOSTAR
 HOSTAR := ar
support/scripts/mkmakefile +1 -3
index 833be6a..37162a3 100755
@@ -15,9 +15,7 @@ if test -e $2/Makefile && ! grep -q Automatically $2/Makefile
 then
 	exit 0
 fi
-if [ "${quiet}" != "silent_" ]; then
-	echo "  GEN     $2/Makefile"
-fi
+echo "  GEN     $2/Makefile"
 
 cat << EOF > $2/Makefile
 # Automatically generated by $0: don't edit
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#3 lore raw

PATCH v2 1/1 Makefile: Remove 'quiet' variable

In reply to Cédric Marie
Quoted 22 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"C?dric" == C?dric Marie <[email protected]> writes:

'quiet' variable is set and exported, but it is not used. We can safely remove it.

This variable is inherited from the Makefile of the Linux kernel, and is not used in Buildroot.

In support/scripts/mkmakefile, 'quiet' value is checked, but the test is always true ('quiet' is never set to silent_), so the test can be removed as well.

Signed-off-by C?dric Marie <[email protected]>

---
Changes v1 -> v2:
- KBUILD_VERBOSE must not be removed, it is used for packages based on Kbuild.

Title of PATCH v1 was:
Makefile: Remove KBUILD_VERBOSE and quiet

Quoted 6 lines

In order to describe how the verbosity level is managed in different infrastructures, comments will be added in Makefile (suggested by Arnout). It will be provided in a separate patch.

Arnout also suggested not to export 'Q', which seems to be Buildroot internal. This will also be provided in a separate patch, if confirmed.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard