Skip to contentSkip to conversation

net: dsa: mv88e6xxx: add common remove function

RFC PATCH In review Neil Armstrong 1 participant 1 message Oct 29, 2015

Subsystems (3)
Networking Network drivers Networking DSA
lore
Share & tools
lore

Neil Armstrong

author
#0 lore raw

RFC PATCH v3 3/5 net: dsa: mv88e6xxx: add common remove function

With the previously introduced remove callback, add a mv88e6xxx common remove function to cleanup all resources.

Signed-off-by Neil Armstrong <[email protected]>
---
 drivers/net/dsa/mv88e6xxx.c | 8 ++++++++
 drivers/net/dsa/mv88e6xxx.h | 1 +
 2 files changed, 9 insertions(+)
drivers/net/dsa/mv88e6xxx.c +8 -0
index b1b14f5..3bd63f1 100644
@@ -2083,6 +2083,14 @@ int mv88e6xxx_setup_common(struct dsa_switch *ds)
 	return 0;
 }
 
+void mv88e6xxx_remove_common(struct dsa_switch *ds)
+{
+	struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
+
+	cancel_work_sync(&ps->bridge_work);
+	flush_work(&ps->bridge_work);
+}
+
 int mv88e6xxx_setup_global(struct dsa_switch *ds)
 {
 	struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
drivers/net/dsa/mv88e6xxx.h +1 -0
index 6f9ed5d..60acaaf 100644
@@ -417,6 +417,7 @@ struct mv88e6xxx_hw_stat {
 int mv88e6xxx_switch_reset(struct dsa_switch *ds, bool ppu_active);
 int mv88e6xxx_setup_ports(struct dsa_switch *ds);
 int mv88e6xxx_setup_common(struct dsa_switch *ds);
+void mv88e6xxx_remove_common(struct dsa_switch *ds);
 int mv88e6xxx_setup_global(struct dsa_switch *ds);
 int __mv88e6xxx_reg_read(struct mii_bus *bus, int sw_addr, int addr, int reg);
 int mv88e6xxx_reg_read(struct dsa_switch *ds, int addr, int reg);
Signature · 1 line
1.9.1