Skip to contentSkip to conversation

please pull u-boot-samsung master

U-Boot New Minkyu Kang 4 participants 8 messages Nov 3, 2015 – Nov 5, 2015

lore
Share & tools
lore
#0 lore raw

Dear Tom,

The following changes since commit 0e067a65f57189703668826d9841fea477026bf6:

x86: Select the ns16550 debug UART for minnowmax, chromebook_link (2015-10-30 18:04:14 -0400)

are available in the git repository at:

http://git.denx.de/u-boot-samsung

for you to fetch changes up to de5f9733f653091d4b227914d04432099a6448dc:

samsung: clean up checkpatch issues (2015-11-02 10:38:22 +0900)

----------------------------------------------------------------
Minkyu Kang (5):
arm: exynos: clean up checkpatch issues
smdkv310: clean up checkpatch issues
smdk2410: clean up checkpatch issues
odroid: clean up checkpatch issues
samsung: clean up checkpatch issues

Przemyslaw Marczak (16):
samsung: board/misc: check returned pointer for get_board_type() calls
s5p: cpu_info: print "cpu-model" if exists in dts
Peach-Pi: dts: add cpu-model string
Exynos5422/5800: set cpu id to 0x5422
dm: pmic: add s2mps11 PMIC I/O driver
dm: regulator: add function device_get_supply_regulator()
dm: adc: add simple ADC uclass implementation
dm: adc: add Exynos54xx compatible ADC driver
Odroid-XU3: enable s2mps11 PMIC support
Exynos54xx: dts: add ADC node
Odroid-XU3: dts: enable ADC, with request for pre-reloc bind
exynos5-dt-types: add board detection for Odroid XU3/XU3L/XU4.
sandbox: add ADC driver
sandbox: add ADC unit tests
Exynos4412: pinmux: disable pull for MMC pins
s5p sdhci: call pinmux for card's gpio pins before use them

 arch/arm/cpu/armv7/s5p-common/cpu_info.c   |   14 +-
 arch/arm/dts/exynos5422-odroidxu3.dts      |   12 +
 arch/arm/dts/exynos54xx.dtsi               |    7 +
 arch/arm/dts/exynos5800-peach-pi.dts       |    1 +
 arch/arm/mach-exynos/clock.c               |   16 +-
 arch/arm/mach-exynos/clock_init_exynos5.c  |    2 +-
 arch/arm/mach-exynos/common_setup.h        |    4 +-
 arch/arm/mach-exynos/dmc_init_ddr3.c       |    8 +-
 arch/arm/mach-exynos/include/mach/adc.h    |   44 +++
 arch/arm/mach-exynos/include/mach/cpu.h    |    6 +-
 arch/arm/mach-exynos/include/mach/gpio.h   |    4 +-
 arch/arm/mach-exynos/pinmux.c              |    4 +-
 arch/arm/mach-exynos/power.c               |    2 +-
 arch/sandbox/dts/sandbox_pmic.dtsi         |    2 +-
 arch/sandbox/dts/test.dts                  |    6 +
 board/samsung/common/Makefile              |    5 +-
 board/samsung/common/board.c               |    4 +-
 board/samsung/common/exynos5-dt-types.c    |  196 +++++++++++++
 board/samsung/common/exynos5-dt.c          |   12 +
 board/samsung/common/misc.c                |   10 +-
 board/samsung/odroid/odroid.c              |   15 +-
 board/samsung/smdk2410/smdk2410.c          |   10 +-
 board/samsung/smdkv310/smdkv310.c          |    8 +-
 configs/odroid-xu3_defconfig               |    5 +
 configs/sandbox_defconfig                  |    2 +
 doc/device-tree-bindings/adc/adc.txt       |   62 +++++
 doc/device-tree-bindings/exynos/soc.txt    |   21 ++
 doc/device-tree-bindings/pmic/s2mps11.txt  |   17 ++
 drivers/Kconfig                            |    2 +
 drivers/Makefile                           |    1 +
 drivers/adc/Kconfig                        |   30 ++
 drivers/adc/Makefile                       |   10 +
 drivers/adc/adc-uclass.c                   |  409 ++++++++++++++++++++++++++++
 drivers/adc/exynos-adc.c                   |  145 ++++++++++
 drivers/adc/sandbox.c                      |  174 ++++++++++++
 drivers/mmc/s5p_sdhci.c                    |   14 +-
 drivers/power/pmic/Kconfig                 |   14 +
 drivers/power/pmic/Makefile                |    1 +
 drivers/power/pmic/s2mps11.c               |   62 +++++
 drivers/power/regulator/regulator-uclass.c |    7 +
 include/adc.h                              |  288 ++++++++++++++++++++
 include/configs/odroid_xu3.h               |   12 +
 include/dm/uclass-id.h                     |    1 +
 include/power/regulator.h                  |   16 ++
 include/power/s2mps11.h                    |  109 ++++++++
 include/power/sandbox_pmic.h               |    4 +
 include/samsung/exynos5-dt-types.h         |   27 ++
 test/dm/Makefile                           |    1 +
 test/dm/adc.c                              |  165 +++++++++++
 49 files changed, 1935 insertions(+), 56 deletions(-)
 create mode 100644 board/samsung/common/exynos5-dt-types.c
 create mode 100644 doc/device-tree-bindings/adc/adc.txt
 create mode 100644 doc/device-tree-bindings/exynos/soc.txt
 create mode 100644 doc/device-tree-bindings/pmic/s2mps11.txt
 create mode 100644 drivers/adc/Kconfig
 create mode 100644 drivers/adc/Makefile
 create mode 100644 drivers/adc/adc-uclass.c
 create mode 100644 drivers/adc/exynos-adc.c
 create mode 100644 drivers/adc/sandbox.c
 create mode 100644 drivers/power/pmic/s2mps11.c
 create mode 100644 include/adc.h
 create mode 100644 include/power/s2mps11.h
 create mode 100644 include/samsung/exynos5-dt-types.h
 create mode 100644 test/dm/adc.c
Signature · 2 lines
Thanks,
Minkyu Kang.
#1 lore raw
Quoted 6 lines · Minkyu Kang

Dear Tom,

The following changes since commit 0e067a65f57189703668826d9841fea477026bf6:

x86: Select the ns16550 debug UART for minnowmax, chromebook_link (2015-10-30 18:04:14 -0400)

Quoted 8 lines

are available in the git repository at:

http://git.denx.de/u-boot-samsung

for you to fetch changes up to de5f9733f653091d4b227914d04432099a6448dc:

samsung: clean up checkpatch issues (2015-11-02 10:38:22 +0900)

NAK:

+(sandbox) ../drivers/adc/sandbox.c:11:25: fatal error: sandbox-adc.h: No such file or directory +(sandbox) #include <sandbox-adc.h>
+(sandbox) ^
+(sandbox) compilation terminated.
+(sandbox) make[3]: *** [drivers/adc/sandbox.o] Error 1
+(sandbox) make[2]: *** [drivers/adc] Error 2
+(sandbox) make[1]: *** [drivers] Error 2

"sandbox: add ADC unit tests" is missing adding sandbox-adc.h

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151103/5cdf67c9/attachment.sig>
#2 lore raw

Dear Przemyslaw Marczak,

2015? 11? 4? ???, Tom Rini<[email protected]>?? ??? ???:

Quoted 30 lines · Minkyu Kang
Quoted 4 lines

Dear Tom,

The following changes since commit

0e067a65f57189703668826d9841fea477026bf6:

Quoted 2 lines

x86: Select the ns16550 debug UART for minnowmax, chromebook_link

(2015-10-30 18:04:14 -0400)

Quoted 9 lines

are available in the git repository at:

http://git.denx.de/u-boot-samsung

for you to fetch changes up to de5f9733f653091d4b227914d04432099a6448dc:

samsung: clean up checkpatch issues (2015-11-02 10:38:22 +0900)

NAK:

+(sandbox) ../drivers/adc/sandbox.c:11:25: fatal error: sandbox-adc.h: No such file or directory

(quoted diff) +6 -0
+(sandbox)  #include <sandbox-adc.h>
+(sandbox)                          ^
+(sandbox) compilation terminated.
+(sandbox) make[3]: *** [drivers/adc/sandbox.o] Error 1
+(sandbox) make[2]: *** [drivers/adc] Error 2
+(sandbox) make[1]: *** [drivers] Error 2
Quoted 3 lines

"sandbox: add ADC unit tests" is missing adding sandbox-adc.h

Could you please check it?

Quoted 3 lines

--
Tom

Thanks,
Minkyu Kang.

Signature · 2 lines
Thanks.
Minkyu Kang.
#3 lore raw

Hello Minkyu,

Quoted 44 lines · Minkyu Kang

Dear Przemyslaw Marczak,

2015? 11? 4? ???, Tom Rini<[email protected]

    On Tue, Nov 03, 2015 at 02:02:57PM +0900, Minkyu Kang wrote:

     > Dear Tom,
     >
     > The following changes since commit
    0e067a65f57189703668826d9841fea477026bf6:
     >
     >   x86: Select the ns16550 debug UART for minnowmax,
    chromebook_link (2015-10-30 18:04:14 -0400)
     >
     > are available in the git repository at:
     >
     > http://git.denx.de/u-boot-samsung
     >
     > for you to fetch changes up to
    de5f9733f653091d4b227914d04432099a6448dc:
     >
     >   samsung: clean up checkpatch issues (2015-11-02 10:38:22 +0900)
     >

    NAK:

    +(sandbox) ../drivers/adc/sandbox.c:11:25: fatal error:
    sandbox-adc.h: No such file or directory
    +(sandbox)  #include <sandbox-adc.h>
    +(sandbox)                          ^
    +(sandbox) compilation terminated.
    +(sandbox) make[3]: *** [drivers/adc/sandbox.o] Error 1
    +(sandbox) make[2]: *** [drivers/adc] Error 2
    +(sandbox) make[1]: *** [drivers] Error 2

    "sandbox: add ADC unit tests" is missing adding sandbox-adc.h

Could you please check it?

    --
    Tom
Quoted 7 lines

Thanks,
Minkyu Kang.

--
Thanks.
Minkyu Kang.

Sorry for this mistake. I have this file locally, so it build properly for me.

Is that good to you if I send you a patch with this missing file, to squash with one commit? Or do you prefer V3 of the whole patch-set?

Best regards,

Signature · 4 lines
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
#4 lore raw

Dear Przemyslaw Marczak,

Quoted 57 lines · Przemyslaw Marczak

Hello Minkyu,

Quoted 44 lines · Minkyu Kang

Dear Przemyslaw Marczak,

2015? 11? 4? ???, Tom Rini<[email protected]

    On Tue, Nov 03, 2015 at 02:02:57PM +0900, Minkyu Kang wrote:

     > Dear Tom,
     >
     > The following changes since commit
    0e067a65f57189703668826d9841fea477026bf6:
     >
     >   x86: Select the ns16550 debug UART for minnowmax,
    chromebook_link (2015-10-30 18:04:14 -0400)
     >
     > are available in the git repository at:
     >
     > http://git.denx.de/u-boot-samsung
     >
     > for you to fetch changes up to
    de5f9733f653091d4b227914d04432099a6448dc:
     >
     >   samsung: clean up checkpatch issues (2015-11-02 10:38:22 +0900)
     >

    NAK:

    +(sandbox) ../drivers/adc/sandbox.c:11:25: fatal error:
    sandbox-adc.h: No such file or directory
    +(sandbox)  #include <sandbox-adc.h>
    +(sandbox)                          ^
    +(sandbox) compilation terminated.
    +(sandbox) make[3]: *** [drivers/adc/sandbox.o] Error 1
    +(sandbox) make[2]: *** [drivers/adc] Error 2
    +(sandbox) make[1]: *** [drivers] Error 2

    "sandbox: add ADC unit tests" is missing adding sandbox-adc.h

Could you please check it?

    --
    Tom
Quoted 8 lines

Thanks,
Minkyu Kang.

--
Thanks.
Minkyu Kang.

Quoted 6 lines

Sorry for this mistake. I have this file locally, so it build properly for me.

Is that good to you if I send you a patch with this missing file, to squash with one commit? Or do you prefer V3 of the whole patch-set?

If squash your patch then I should do push forced. I think it's not a good way.
I will merge your patch separately.

Thanks,
Minkyu Kang.

Signature · 2 lines
from. prom.
www.promsoft.net
#5 lore raw

Hello Minkyu,

Quoted 75 lines · Minkyu Kang

Dear Przemyslaw Marczak,

On 4 November 2015 at 18:37, Przemyslaw Marczak <[email protected] <mailto:[email protected]>> wrote:

    Hello Minkyu,

    On 11/04/2015 03:05 AM, Minkyu Kang wrote:

        Dear Przemyslaw Marczak,

        2015? 11? 4? ???, Tom Rini<[email protected]
        <mailto:[email protected]>

             On Tue, Nov 03, 2015 at 02:02:57PM +0900, Minkyu Kang wrote:

              > Dear Tom,
              >
              > The following changes since commit
             0e067a65f57189703668826d9841fea477026bf6:
              >
              >   x86: Select the ns16550 debug UART for minnowmax,
             chromebook_link (2015-10-30 18:04:14 -0400)
              >
              > are available in the git repository at:
              >
              > http://git.denx.de/u-boot-samsung
              >
              > for you to fetch changes up to
             de5f9733f653091d4b227914d04432099a6448dc:
              >
              >   samsung: clean up checkpatch issues (2015-11-02
        10:38:22 +0900)
              >

             NAK:

             +(sandbox) ../drivers/adc/sandbox.c:11:25: fatal error:
             sandbox-adc.h: No such file or directory
             +(sandbox)  #include <sandbox-adc.h>
             +(sandbox)                          ^
             +(sandbox) compilation terminated.
             +(sandbox) make[3]: *** [drivers/adc/sandbox.o] Error 1
             +(sandbox) make[2]: *** [drivers/adc] Error 2
             +(sandbox) make[1]: *** [drivers] Error 2

             "sandbox: add ADC unit tests" is missing adding sandbox-adc.h


        Could you please check it?

             --
             Tom


        Thanks,
        Minkyu Kang.


        --
        Thanks.
        Minkyu Kang.


    Sorry for this mistake. I have this file locally, so it build
    properly for me.

    Is that good to you if I send you a patch with this missing file, to
    squash with one commit? Or do you prefer V3 of the whole patch-set?

If squash your patch then I should do push forced. I think it's not a good way.
I will merge your patch separately.

Quoted 5 lines

Thanks,
Minkyu Kang.
--
from. prom.
www.promsoft.net <http://www.promsoft.net>

Squashing would be better if we want prevent build break. This single file (include/sandbox-adc.h) will not conflict with any other, so it's easy to rebase it.
This is not a master tree, so I think that push with force will not cause any problems.

But if you really prefer to take it as a separate patch, then I will send one, with a proper commit message in a moment.

Best regards,

Signature · 4 lines
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
#6 lore raw

PATCH 1/1 sandbox: adc: Add missing header file

In reply to Minkyu Kang

Commit: sandbox: add ADC driver

adds the driver without its main header file.
It causes build brake for sandbox_defonfig.

This commit adds a missing header:
- include/sandbox-adc.h

---
 include/sandbox-adc.h | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 include/sandbox-adc.h
include/sandbox-adc.h new file +31 -0
new file mode 100644
index 0000000..79ff01c
@@ -0,0 +1,31 @@
+/*
+ * Copyright (C) 2015 Samsung Electronics
+ * Przemyslaw Marczak <[email protected]>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef _SANDBOX_ADC_H_
+#define _SANDBOX_ADC_H_
+
+#define SANDBOX_ADC_DEVNAME		"adc at 0"
+#define SANDBOX_ADC_DATA_MASK		0xffff /* 16-bits resolution */
+#define SANDBOX_ADC_CHANNELS		4
+#define SANDBOX_ADC_CHANNEL0_DATA	0x0
+#define SANDBOX_ADC_CHANNEL1_DATA	0x1000
+#define SANDBOX_ADC_CHANNEL2_DATA	0x2000
+#define SANDBOX_ADC_CHANNEL3_DATA	0x3000
+
+enum sandbox_adc_mode {
+	SANDBOX_ADC_MODE_SINGLE_CHANNEL = 0,
+	SANDBOX_ADC_MODE_MULTI_CHANNEL,
+};
+
+enum sandbox_adc_status {
+	SANDBOX_ADC_INACTIVE = 0,
+	SANDBOX_ADC_ACTIVE,
+};
+
+#define SANDBOX_ADC_VSS_VALUE		0
+
+#endif
Signature · 1 line
1.9.1
#7 lore raw

PATCH 1/1 sandbox: adc: Add missing header file

2015? 11? 5? ???, Przemyslaw Marczak<[email protected]>?? ??? ???:

Quoted 56 lines

Commit: sandbox: add ADC driver

adds the driver without its main header file.
It causes build brake for sandbox_defonfig.

This commit adds a missing header:
- include/sandbox-adc.h

Signed-off-by Przemyslaw Marczak <[email protected] <javascript:;>>
Cc Minkyu Kang <[email protected] <javascript:;>>
Cc Simon Glass <[email protected] <javascript:;>>
---
 include/sandbox-adc.h | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 include/sandbox-adc.h
include/sandbox-adc.h new file +31 -1
new file mode 100644
index 0000000..79ff01c
@@ -0,0 +1,31 @@
+/*
+ * Copyright (C) 2015 Samsung Electronics
+ * Przemyslaw Marczak <[email protected] <javascript:;>>
+ *
+ * SPDX-License-Identifier:    GPL-2.0+
+ */
+
+#ifndef _SANDBOX_ADC_H_
+#define _SANDBOX_ADC_H_
+
+#define SANDBOX_ADC_DEVNAME            "adc at 0"
+#define SANDBOX_ADC_DATA_MASK          0xffff /* 16-bits resolution */
+#define SANDBOX_ADC_CHANNELS           4
+#define SANDBOX_ADC_CHANNEL0_DATA      0x0
+#define SANDBOX_ADC_CHANNEL1_DATA      0x1000
+#define SANDBOX_ADC_CHANNEL2_DATA      0x2000
+#define SANDBOX_ADC_CHANNEL3_DATA      0x3000
+
+enum sandbox_adc_mode {
+       SANDBOX_ADC_MODE_SINGLE_CHANNEL = 0,
+       SANDBOX_ADC_MODE_MULTI_CHANNEL,
+};
+
+enum sandbox_adc_status {
+       SANDBOX_ADC_INACTIVE = 0,
+       SANDBOX_ADC_ACTIVE,
+};
+
+#define SANDBOX_ADC_VSS_VALUE          0
+
+#endif
--

1.9.1

Quoted 5 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de <javascript:;>
http://lists.denx.de/mailman/listinfo/u-boot

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

Signature · 2 lines
Thanks.
Minkyu Kang.