allow to enable all tracepoints via alias all
PATCH v2 1/1 allow to enable all tracepoints via alias all
From: Olga Krishtal <[email protected]>
This will produce a lot of noise but could be usefull when we do this for a shot perioud of time on customer side to examine unclear problem.
---
Changes from v1:
- proper mailing list targeted
trace/control.c | 3 +++ 1 file changed, 3 insertions(+)
trace/control.c +3 -0
@@ -35,6 +35,9 @@ TraceEvent *trace_event_name(const char *name)static bool pattern_glob (const char *pat,const char *ev) { +if (!(g_strcmp0 (pat,"all" ))) { +return true; + }while (*pat !='\0' && *ev !='\0' ) {if (*pat == *ev) { pat++;
Signature · 1 line
2.1.4
Quoted 21 lines · Denis V. Lunev
From: Olga Krishtal <[email protected]>
This will produce a lot of noise but could be usefull when we do this for a shot perioud of time on customer side to examine unclear problem.
Signed-off-by Olga Krishtal <[email protected]>Signed-off-by Denis V. Lunev <[email protected]>CC Paolo Bonzini <[email protected]>CC Stefan Hajnoczi <[email protected]>---
Changes from v1:
- proper mailing list targetedtrace/control.c | 3 +++ 1 file changed, 3 insertions(+)trace/control.c +0
-0
trace/control.c TraceEvent *trace_event_name(const char *name) · line 43
Quoted 9 lines
trace/control.c +3
-0@@ -35,6 +35,9 @@ TraceEvent *trace_event_name(const char *name)static bool pattern_glob (const char *pat,const char *ev) { +if (!(g_strcmp0 (pat,"all" ))) { +return true; + }while (*pat !='\0' && *ev !='\0' ) {if (*pat == *ev) { pat++;
What's wrong with '*'?
Quoted 24 lines · Markus Armbruster
Quoted 22 lines · Denis V. Lunev
From: Olga Krishtal <[email protected]>
This will produce a lot of noise but could be usefull when we do this for a shot perioud of time on customer side to examine unclear problem.
Signed-off-by Olga Krishtal <[email protected]>Signed-off-by Denis V. Lunev <[email protected]>CC Paolo Bonzini <[email protected]>CC Stefan Hajnoczi <[email protected]>---
Changes from v1:
- proper mailing list targetedtrace/control.c | 3 +++ 1 file changed, 3 insertions(+)trace/control.c +0
-0@@ -35,6 +35,9 @@ TraceEvent *trace_event_name(const char *name)
Quoted 9 lines
trace/control.c TraceEvent *trace_event_name(const char *name) · line 43
Quoted 8 lines
trace/control.c +3
-0static bool pattern_glob (const char *pat,const char *ev) { +if (!(g_strcmp0 (pat,"all" ))) { +return true; + }while (*pat !='\0' && *ev !='\0' ) {if (*pat == *ev) { pat++;What's wrong with '*'?
according to our tests plain '*' is not accepted. It accepts 'bdrv*' or 'qcow2*' but not single '*'. may be we are doing something wrong.
Den
Quoted 24 lines · Markus Armbruster
Quoted 22 lines · Denis V. Lunev
From: Olga Krishtal <[email protected]>
This will produce a lot of noise but could be usefull when we do this for a shot perioud of time on customer side to examine unclear problem.
Signed-off-by Olga Krishtal <[email protected]>Signed-off-by Denis V. Lunev <[email protected]>CC Paolo Bonzini <[email protected]>CC Stefan Hajnoczi <[email protected]>---
Changes from v1:
- proper mailing list targetedtrace/control.c | 3 +++ 1 file changed, 3 insertions(+)trace/control.c +0
-0@@ -35,6 +35,9 @@ TraceEvent *trace_event_name(const char *name)
Quoted 9 lines
trace/control.c TraceEvent *trace_event_name(const char *name) · line 43
Quoted 8 lines
trace/control.c +3
-0static bool pattern_glob (const char *pat,const char *ev) { +if (!(g_strcmp0 (pat,"all" ))) { +return true; + }while (*pat !='\0' && *ev !='\0' ) {if (*pat == *ev) { pat++;What's wrong with '*'?
you are right. I have done things wrong. This patch is not needed at all.