Skip to contentSkip to conversation

libtirpc: rpcgen is only built for host, don't install to target

PATCH New Phil Eichinger 3 participants 3 messages Nov 3, 2015

lore
Share & tools
lore

Phil Eichinger

author
#0 lore raw

PATCH 1/1 libtirpc: rpcgen is only built for host, don't install to target

rpcgen is only used to generate headers needed for compilation. Move it to noinst_PROGRAMS otherwise you may end up with a host-arch binary in your target.

Signed-off-by Phil Eichinger <[email protected]>
---
 package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch +1 -1
index ad14312..1cf8614 100644
@@ -87,7 +87,7 @@ index 0000000..2277b6f
 +	$(CPPFLAGS_FOR_BUILD) $(AM_CFLAGS) $(CFLAGS_FOR_BUILD)
 +LINK = $(CC_FOR_BUILD) $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) $(AM_LDFLAGS) $(LDFLAGS_FOR_BUILD) -o $@
 +
-+bin_PROGRAMS = rpcgen
++noinst_PROGRAMS = rpcgen
 +
 +rpcgen_SOURCES = \
 +	rpc_clntout.c \
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 libtirpc: rpcgen is only built for host, don't install to target

Quoted 5 lines · Phil Eichinger

rpcgen is only used to generate headers needed for compilation. Move it to noinst_PROGRAMS otherwise you may end up with a host-arch binary in your target.

Signed-off-by Phil Eichinger <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Note that nfs-utils-1.3.3 actually defines it in noinst_PROGRAMS.

Regards,
Arnout

Quoted 18 lines
---
 package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch +1 -1
index ad14312..1cf8614 100644
@@ -87,7 +87,7 @@ index 0000000..2277b6f
 +	$(CPPFLAGS_FOR_BUILD) $(AM_CFLAGS) $(CFLAGS_FOR_BUILD)
 +LINK = $(CC_FOR_BUILD) $(AM_CFLAGS) $(CFLAGS_FOR_BUILD) $(AM_LDFLAGS) $(LDFLAGS_FOR_BUILD) -o $@
 +
-+bin_PROGRAMS = rpcgen
++noinst_PROGRAMS = rpcgen
 +
 +rpcgen_SOURCES = \
 +	rpc_clntout.c \
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Applied
#2 lore raw

PATCH 1/1 libtirpc: rpcgen is only built for host, don't install to target

In reply to Phil Eichinger

Dear Phil Eichinger,

Quoted 8 lines · Phil Eichinger

rpcgen is only used to generate headers needed for compilation. Move it to noinst_PROGRAMS otherwise you may end up with a host-arch binary in your target.

Signed-off-by Phil Eichinger <[email protected]>
---
 package/libtirpc/0003-Add-rpcgen-program-from-nfs-utils-sources.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com