ARM: at91/dt: sama5d4: Add pinmux for 8-bit MMC0 bus
PATCH 1/1 ARM: at91/dt: sama5d4: Add pinmux for 8-bit MMC0 bus
Add pinmux for the 4 remaining signals used in 8-bit MMC 0 bus configuration.
--- arch/arm/boot/dts/sama5d4.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm/boot/dts/sama5d4.dtsi +8 -0
@@ -1651,6 +1651,14 @@ AT91_PIOC 9 AT91_PERIPH_B AT91_PINCTRL_PULL_UP /* MCI0_DB3, conflict with NAND_D4 */ >; }; + pinctrl_mmc0_dat4_7: mmc0_dat4_7 { + atmel,pins = + <AT91_PIOC 10 AT91_PERIPH_B AT91_PINCTRL_PULL_UP /* MCI0_DB1, conflict with NAND_D5 */ + AT91_PIOC 11 AT91_PERIPH_B AT91_PINCTRL_PULL_UP /* MCI0_DB2, conflict with NAND_D6 */ + AT91_PIOC 12 AT91_PERIPH_B AT91_PINCTRL_PULL_UP /* MCI0_DB3, conflict with NAND_D7 */ + AT91_PIOC 13 AT91_PERIPH_B AT91_PINCTRL_PULL_UP /* MCI0_DB3, conflict with NAND_D8 */ + >; + }; }; mmc1 {
Signature · 1 line
2.1.4
PATCH 1/1 ARM: at91/dt: sama5d4: Add pinmux for 8-bit MMC0 bus
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Le 02/11/2015 00:26, Marek Vasut a ?crit :
Quoted 9 lines
Add pinmux for the 4 remaining signals used in 8-bit MMC 0 bus configuration.
Signed-off-by Marek Vasut <[email protected]> Cc: Alexandre Belloni<[email protected]> Cc: Josh Wu <[email protected]> Cc: Nicolas Ferre <[email protected]> ---
arch/arm/boot/dts/sama5d4.dtsi| 8 ++++++++ 1 file changed, 8 insertions(+)
Quoted 6 lines
(quoted diff) +0
-0
b/arch/arm/boot/dts/sama5d4.dtsiindex 8d1de29..f9f6108 100644 ---a/arch/arm/boot/dts/sama5d4.dtsi+++b/arch/arm/boot/dts/sama5d4.dtsi@@ -1651,6 +1651,14 @@AT91_PIOC9AT91_PERIPH_BAT91_PINCTRL_PULL_UP/*MCI0_DB3, conflict withNAND_D4*/
Oh, I see an error over there: it's actually MCI0_DA3 in the comment! Idea for another patch ;-)
Quoted 3 lines
Quoted 1 line
; }; +
pinctrl_mmc0_dat4_7:mmc0_dat4_7{ + atmel,pins =(quoted diff) +1
-0+ <AT91_PIOC 10 AT91_PERIPH_B AT91_PINCTRL_PULL_UP /*
MCI0_DB1, conflict withNAND_D5*/
Ok, so here also, the error comes from the comment: it's MCI0_DA4 up to MCI0_DA7.
The "A" stands for "slot 0" that you would instantiate in your board's .dts
Quoted 7 lines
(quoted diff) +1
-0+ AT91_PIOC 11 AT91_PERIPH_B AT91_PINCTRL_PULL_UP /*
MCI0_DB2, conflict withNAND_D6*/ +AT91_PIOC12AT91_PERIPH_BAT91_PINCTRL_PULL_UP/*MCI0_DB3, conflict withNAND_D7*/ +AT91_PIOC13AT91_PERIPH_BAT91_PINCTRL_PULL_UP
/*MCI0_DB3, conflict withNAND_D8*/ + >; + }; };mmc1 {
So Marek, you can send a v2 of this patch or I can do these changes if you prefer, tell me.
Bye,
- --
Nicolas Ferre
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJWOcghAAoJEAf03oE53VmQ3z4H/RTx1W2kbDZ3cDSX22Tpn2ew BKGJYk4dvNGNO9NTxLDUxTVqfnp7hBzxCshEZ9QO3er6baAXDrCzGfaqBex9Dy9U lFpQxTgBMoudJdOci4KLqSghlZ2XVpv0uumtYEQL03rJ9jDyFhnvJhlaLbyVhqIC QG1MiObmLxAFQKQKnCJzA+AttxIPvtKmmrCUHumlOAvY0V0Do8kbNgq0dEc9/tRC 7jui2+v0ALm7+qDpsvKBa/VzTLZKKVjCMrWaAVWyBTp8XCmKWuljDSlhep66v3G6 EBV6d5SdcjOWnIFbaS5Px/HpT2yBV+RyegZk5Vejf0Jnxc7KK6YsJNxCsFbZ4TU= =th+u
-----END PGP SIGNATURE-----
PATCH 1/1 ARM: at91/dt: sama5d4: Add pinmux for 8-bit MMC0 bus
Quoted 10 lines · Nicolas Ferre
Le 02/11/2015 00:26, Marek Vasut a ?crit :
Quoted 9 lines
Add pinmux for the 4 remaining signals used in 8-bit MMC 0 bus configuration.
Signed-off-by Marek Vasut <[email protected]> Cc: Alexandre Belloni<[email protected]> Cc: Josh Wu <[email protected]> Cc: Nicolas Ferre <[email protected]> ---
arch/arm/boot/dts/sama5d4.dtsi| 8 ++++++++ 1 file changed, 8 insertions(+)
Quoted 9 lines
Quoted 6 lines
(quoted diff) +0
-0
b/arch/arm/boot/dts/sama5d4.dtsiindex 8d1de29..f9f6108 100644 ---a/arch/arm/boot/dts/sama5d4.dtsi+++b/arch/arm/boot/dts/sama5d4.dtsi@@ -1651,6 +1651,14 @@AT91_PIOC9AT91_PERIPH_BAT91_PINCTRL_PULL_UP/*MCI0_DB3, conflict withNAND_D4*/Oh, I see an error over there: it's actually
MCI0_DA3in the comment! Idea for another patch ;-)
Oh, nice catch. I created such patch and will submit it shortly.
Quoted 1 line
Quoted 1 line
Quoted 1 line
; }; +
pinctrl_mmc0_dat4_7:mmc0_dat4_7
{ + atmel,pins =
Quoted 2 lines
Review
Quoted 2 lines
(quoted diff) +1
-0+ <AT91_PIOC 10
AT91_PERIPH_B AT91_PINCTRL_PULL_UP /*
Quoted 7 lines
Quoted 1 line
MCI0_DB1, conflict withNAND_D5*/Ok, so here also, the error comes from the comment: it's
MCI0_DA4up toMCI0_DA7.The "A" stands for "slot 0" that you would instantiate in your board's .dts
Yep, I fixed this as well.
Quoted 1 line
Review
Quoted 1 line
(quoted diff) +1
-0+ AT91_PIOC 11
AT91_PERIPH_B AT91_PINCTRL_PULL_UP /*
Quoted 1 line
Quoted 1 line
MCI0_DB2, conflict withNAND_D6*/ +
AT91_PIOC 12
Quoted 2 lines
Quoted 2 lines
AT91_PERIPH_BAT91_PINCTRL_PULL_UP/*MCI0_DB3, conflict withNAND_D7*/ +
AT91_PIOC 13 AT91_PERIPH_B AT91_PINCTRL_PULL_UP
Quoted 1 line
Quoted 1 line
/*
MCI0_DB3, conflict withNAND_D8*/ +
>; + }; };
Quoted 5 lines
Quoted 2 lines
mmc1 {
So Marek, you can send a v2 of this patch or I can do these changes if you prefer, tell me.
V2 is on it's way once I test the fixes briefly.
Best regards,
Marek Vasut