Skip to contentSkip to conversation

package/nginx: fix a typo

PATCH New Noé Rubinstein 3 participants 4 messages Nov 4, 2015

lore
Share & tools
lore

Noé Rubinstein

author
#0 lore raw

PATCH 1/2 package/nginx: fix a typo

Signed-off-by No? Rubinstein <[email protected]>
---
 package/nginx/nginx.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/nginx/nginx.mk +1 -1
index 32a337c..8e23bd8 100644
@@ -19,7 +19,7 @@ NGINX_CONF_OPTS = \
 
 # www-data user and group are used for nginx. Because these user and group
 # are already set by buildroot, it is not necessary to redefine them.
-# See system/skeleton/passwd
+# See system/skeleton/etc/passwd
 #   username: www-data    uid: 33
 #   groupname: www-data   gid: 33
 #
Signature · 1 line
2.1.4
author
#1 lore raw

PATCH 2/2 package/python-web2py: fix permissions

The PYTHON_WEB2PY_PERMISSIONS table was using the user and group names instead of the uid and gid, causing makedevs to retrieve the uid and gid from the host system.

Signed-off-by No? Rubinstein <[email protected]>
---
 package/python-web2py/python-web2py.mk | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
package/python-web2py/python-web2py.mk +9 -1
index 313114a..db9ed8d 100644
@@ -32,8 +32,16 @@ define PYTHON_WEB2PY_INSTALL_INIT_SYSTEMD
 		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/web2py.service
 endef
 
+# www-data user and group are used for web2py. Because these user and group
+# are already set by buildroot, it is not necessary to redefine them.
+# See system/skeleton/etc/passwd
+#   username: www-data    uid: 33
+#   groupname: www-data   gid: 33
+#
+# So, we just need to create the directories used by web2py with the right
+# ownership.
 define PYTHON_WEB2PY_PERMISSIONS
-	/var/www/web2py  r  750  www-data  www-data  -  -  -  -  -
+	/var/www/web2py  r  750  33  33  -  -  -  -  -
 endef
 
 $(eval $(generic-package))
Signature · 1 line
2.1.4
#2 lore raw

PATCH 1/2 package/nginx: fix a typo

In reply to Noé Rubinstein

Dear No? Rubinstein,

Quoted 4 lines · No? Rubinstein
Signed-off-by No? Rubinstein <[email protected]>
---
 package/nginx/nginx.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Both patches applied, thanks!

For the second patch, it would be good if someone could modify makedevs to not accept user/group specified as strings, since resolving them from the host point of view doesn't make any sense.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/2 package/nginx: fix a typo

Quoted 8 lines · Thomas Petazzoni

Dear No? Rubinstein,

Quoted 4 lines · No? Rubinstein
Signed-off-by No? Rubinstein <[email protected]>
---
 package/nginx/nginx.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines

Both patches applied, thanks!

For the second patch, it would be good if someone could modify makedevs to not accept user/group specified as strings, since resolving them from the host point of view doesn't make any sense.

Or better yet, use the target passwd and group files...

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF