Skip to contentSkip to conversation

Intel device IDs Audio

PATCH In review Alexandra Yates 2 participants 4 messages Nov 4, 2015 – Nov 5, 2015 1 message not in the archive Sound

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [PATCH V2] Intel device IDs Audio

#1 lore raw

PATCH v2 1/1 Intel device IDs Audio

Adding Intel codename Lewisburg platform device IDs for audio.

---
 sound/pci/hda/hda_intel.c | 5 +++++
 1 file changed, 5 insertions(+)
sound/pci/hda/hda_intel.c +5 -0
index c38c68f..e8d1151 100644
@@ -2168,6 +2168,11 @@ static const struct pci_device_id azx_ids[] = {
 	/* ICH10 */
 	{ PCI_DEVICE(0x8086, 0x3a6e),
 	  .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_INTEL_ICH },
+	/* Lewisburg */
+	{ PCI_DEVICE(0x8086, 0xa1f0),
+	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
+	{ PCI_DEVICE(0x8086, 0xa270),
+	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
 	/* Generic Intel */
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_ANY_ID),
 	  .class = PCI_CLASS_MULTIMEDIA_HD_AUDIO << 8,
Signature · 1 line
1.9.1
#2 lore raw
Quoted 4 lines · Alexandra Yates

Adding Intel codename Lewisburg platform device IDs for audio.

Thanks. Though, I still believe the position after Wellsburg is best (which is the similar chip that has the same driver type and driver
caps bits), so I rearranged it. Also the subject was aligned.
And last but not least, Cc to stable was added.

Takashi

Quoted 24 lines
---
 sound/pci/hda/hda_intel.c | 5 +++++
 1 file changed, 5 insertions(+)
sound/pci/hda/hda_intel.c +5 -0
index c38c68f..e8d1151 100644
@@ -2168,6 +2168,11 @@ static const struct pci_device_id azx_ids[] = {
 	/* ICH10 */
 	{ PCI_DEVICE(0x8086, 0x3a6e),
 	  .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_INTEL_ICH },
+	/* Lewisburg */
+	{ PCI_DEVICE(0x8086, 0xa1f0),
+	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
+	{ PCI_DEVICE(0x8086, 0xa270),
+	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
 	/* Generic Intel */
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_ANY_ID),
 	  .class = PCI_CLASS_MULTIMEDIA_HD_AUDIO << 8,
Signature · 1 line
1.9.1
#3 lore raw

Takashi,

Quoted 12 lines · Takashi Iwai
Quoted 4 lines · Alexandra Yates

Adding Intel codename Lewisburg platform device IDs for audio.

Thanks. Though, I still believe the position after Wellsburg is best (which is the similar chip that has the same driver type and driver
caps bits), so I rearranged it. Also the subject was aligned.
And last but not least, Cc to stable was added.

Thank you for your review and making the additional changes. I'll keep your methodology for future reference.

Is this mean that the patch was accepted upstream?

Quoted 27 lines

Takashi

Quoted 24 lines
---
  sound/pci/hda/hda_intel.c | 5 +++++
  1 file changed, 5 insertions(+)
sound/pci/hda/hda_intel.c +5 -1
index c38c68f..e8d1151 100644
@@ -2168,6 +2168,11 @@ static const struct pci_device_id azx_ids[] = {
  	/* ICH10 */
  	{ PCI_DEVICE(0x8086, 0x3a6e),
  	  .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_INTEL_ICH },
+	/* Lewisburg */
+	{ PCI_DEVICE(0x8086, 0xa1f0),
+	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
+	{ PCI_DEVICE(0x8086, 0xa270),
+	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
  	/* Generic Intel */
  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_ANY_ID),
  	  .class = PCI_CLASS_MULTIMEDIA_HD_AUDIO << 8,
--

1.9.1

Signature · 2 lines
Thank you,
<Alexandra>
#4 lore raw
Quoted 17 lines · Alexandra Yates

Takashi,

Quoted 12 lines · Takashi Iwai
Quoted 4 lines · Alexandra Yates

Adding Intel codename Lewisburg platform device IDs for audio.

Thanks. Though, I still believe the position after Wellsburg is best (which is the similar chip that has the same driver type and driver
caps bits), so I rearranged it. Also the subject was aligned.
And last but not least, Cc to stable was added.

Quoted 4 lines

Thank you for your review and making the additional changes. I'll keep your methodology for future reference.

Is this mean that the patch was accepted upstream?

Yes :)

Takashi

Quoted 32 lines
Quoted 27 lines

Takashi

Quoted 24 lines
---
  sound/pci/hda/hda_intel.c | 5 +++++
  1 file changed, 5 insertions(+)
sound/pci/hda/hda_intel.c +5 -1
index c38c68f..e8d1151 100644
@@ -2168,6 +2168,11 @@ static const struct pci_device_id azx_ids[] = {
  	/* ICH10 */
  	{ PCI_DEVICE(0x8086, 0x3a6e),
  	  .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_INTEL_ICH },
+	/* Lewisburg */
+	{ PCI_DEVICE(0x8086, 0xa1f0),
+	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
+	{ PCI_DEVICE(0x8086, 0xa270),
+	  .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH },
  	/* Generic Intel */
  	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_ANY_ID),
  	  .class = PCI_CLASS_MULTIMEDIA_HD_AUDIO << 8,
--

1.9.1

Signature · 2 lines
Thank you,
<Alexandra>